Skip to contentSkip to conversation

PCI: aardvark: Remove redundant dev_err call in advk_pcie_probe()

PATCH New Wei Yongjun 3 participants 3 messages Jul 28, 2016 – Aug 22, 2016 PCI

lore
Share & tools
lore

Wei Yongjun

author
#0 lore raw

PATCH 1/1 PCI: aardvark: Remove redundant dev_err call in advk_pcie_probe()

There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message.

Signed-off-by Wei Yongjun <[email protected]>
---
 drivers/pci/host/pci-aardvark.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pci/host/pci-aardvark.c +1 -3
index ef9893f..05c33b5 100644
@@ -925,10 +925,8 @@ static int advk_pcie_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	pcie->base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(pcie->base)) {
-		dev_err(&pdev->dev, "Failed to map registers\n");
+	if (IS_ERR(pcie->base))
 		return PTR_ERR(pcie->base);
-	}
 
 	irq = platform_get_irq(pdev, 0);
 	ret = devm_request_irq(&pdev->dev, irq, advk_pcie_irq_handler,
#1 lore raw

PATCH 1/1 PCI: aardvark: Remove redundant dev_err call in advk_pcie_probe()

Hello,

Quoted 8 lines · Wei Yongjun

There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message.

Signed-off-by Wei Yongjun <[email protected]>
---
 drivers/pci/host/pci-aardvark.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by Thomas Petazzoni <[email protected]>

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 PCI: aardvark: Remove redundant dev_err call in advk_pcie_probe()

In reply to Wei Yongjun
Quoted 5 lines · Wei Yongjun

There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message.

Signed-off-by Wei Yongjun <[email protected]>

Applied with Thomas' reviewed-by to pci/host-aardvark for v4.9, thanks!

Quoted 27 lines
---
 drivers/pci/host/pci-aardvark.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/pci/host/pci-aardvark.c +1 -4
index ef9893f..05c33b5 100644
@@ -925,10 +925,8 @@ static int advk_pcie_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	pcie->base = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(pcie->base)) {
-		dev_err(&pdev->dev, "Failed to map registers\n");
+	if (IS_ERR(pcie->base))
 		return PTR_ERR(pcie->base);
-	}
 
 	irq = platform_get_irq(pdev, 0);
 	ret = devm_request_irq(&pdev->dev, irq, advk_pcie_irq_handler,
 
 
 
--

To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html