i2c: designware-baytrail: Fix the Kconfig dependency fix
PATCH v2 1/1 i2c: designware-baytrail: Fix the Kconfig dependency fix
Commit b4ad0510f5d9 ("i2c: designware-baytrail: another fixup for proper Kconfig dependencies") claims that the "Baytrail driver" isn't tristate. But in fact there is no such thing as a "Baytrail driver", i2c-designware-baytrail is not a stand-alone driver but an optional addition to the i2c-designware-platform driver, and that driver *is* tristate. So there is no reason why I2C_DESIGNWARE_BAYTRAIL couldn't be enabled when IOSF_MBI=m, as long as I2C_DESIGNWARE_PLATFORM=m too.
---
Changes since v1:
* Fixed Wolfram's Cc.
* Split the dependency line to avoid too long a line (suggested by Jarkko.)
* Added more Ccs.
drivers/i2c/busses/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/i2c/busses/Kconfig +2 -1
@@ -490,7 +490,8 @@ config I2C_DESIGNWARE_PCI config I2C_DESIGNWARE_BAYTRAIL bool "Intel Baytrail I2C semaphore support" - depends on I2C_DESIGNWARE_PLATFORM && IOSF_MBI=y && ACPI + depends on I2C_DESIGNWARE_PLATFORM && ACPI + depends on IOSF_MBI=y || IOSF_MBI=I2C_DESIGNWARE_PLATFORM help This driver enables managed host access to the PMIC I2C bus on select Intel BayTrail platforms using the X-Powers AXP288 PMIC. It allows
Signature · 2 lines
Jean Delvare SUSE L3 Support
Quoted 8 lines · Jean Delvare
Commit
b4ad0510f5d9("i2c: designware-baytrail: another fixup for properKconfigdependencies") claims that the "Baytrail driver" isn't tristate. But in fact there is no such thing as a "Baytrail driver", i2c-designware-baytrail is not a stand-alone driver but an optional addition to the i2c-designware-platform driver, and that driver *is* tristate. So there is no reason whyI2C_DESIGNWARE_BAYTRAILcouldn't be enabled when IOSF_MBI=m, as long as I2C_DESIGNWARE_PLATFORM=m too.
Quoted 8 lines
Signed-off-by Jean Delvare <[email protected]>Fixes b4ad0510f5d9 ("i2c: designware-baytrail: another fixup for proper Kconfig dependencies")Reviewed-by Jarkko Nikula <[email protected]>Cc Andy Shevchenko <[email protected]>Cc Mika Westerberg <[email protected]>Cc Randy Dunlap <[email protected]>Cc David E. Box <[email protected]>Cc Wolfram Sang <[email protected]>
I applied a patch from Jarkko on 19.6.2016 which also changed the dependencies. Not sure if it is equal to your change, but this patch doesn't apply anymore.
Hi Wolfram, Jarkko,
Quoted 18 lines · Wolfram Sang
Quoted 8 lines · Jean Delvare
Commit
b4ad0510f5d9("i2c: designware-baytrail: another fixup for properKconfigdependencies") claims that the "Baytrail driver" isn't tristate. But in fact there is no such thing as a "Baytrail driver", i2c-designware-baytrail is not a stand-alone driver but an optional addition to the i2c-designware-platform driver, and that driver *is* tristate. So there is no reason whyI2C_DESIGNWARE_BAYTRAILcouldn't be enabled when IOSF_MBI=m, as long as I2C_DESIGNWARE_PLATFORM=m too.Quoted 8 lines
Signed-off-by Jean Delvare <[email protected]>Fixes b4ad0510f5d9 ("i2c: designware-baytrail: another fixup for proper Kconfig dependencies")Reviewed-by Jarkko Nikula <[email protected]>Cc Andy Shevchenko <[email protected]>Cc Mika Westerberg <[email protected]>Cc Randy Dunlap <[email protected]>Cc David E. Box <[email protected]>Cc Wolfram Sang <[email protected]>
Quoted 3 lines
I applied a patch from Jarkko on 19.6.2016 which also changed the dependencies. Not sure if it is equal to your change, but this patch doesn't apply anymore.
As I understand it, Jarkko's patch sets the same dependencies my patch was setting, just expressed differently. So we are good, you can drop my patch.
Thanks,
Signature · 2 lines
Jean Delvare SUSE L3 Support
Quoted 8 lines
Quoted 4 lines
I applied a patch from Jarkko on 19.6.2016 which also changed the dependencies. Not sure if it is equal to your change, but this patch doesn't apply anymore.
As I understand it, Jarkko's patch sets the same dependencies my patch was setting, just expressed differently. So we are good, you can drop my patch.
Will do, thanks for the heads up!