drm/i915/opregion: proper handling of DIDL and CADL
Subsystems (2)
cover drm/i915/opregion: proper handling of DIDL and CADL
This is the next iteration of [1] and [2]. Please review and/or test, according to your abilities.
Thanks,
Jani.
[1] http://mid.mail-archive.com/[email protected]
[2] http://mid.mail-archive.com/[email protected]
Jani Nikula (2):
drm/i915: make i915 the source of acpi device ids for _DOD drm/i915/opregion: update cadl based on actually active outputs
drivers/gpu/drm/i915/i915_drv.h | 4 + drivers/gpu/drm/i915/intel_display.c | 6 ++ drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/gpu/drm/i915/intel_opregion.c | 157 +++++++++++++--------------------- 4 files changed, 74 insertions(+), 96 deletions(-)
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/2 drm/i915: make i915 the source of acpi device ids for _DOD
The graphics driver is supposed to define the DIDL, which are used for _DOD, not the BIOS. Restore that behaviour.
This is basically a revert of
commit 3143751ff51a163b77f7efd389043e038f3e008e
Author: Zhang Rui <[email protected]> Date: Mon Mar 29 15:12:16 2010 +0800
drm/i915: set DIDL using the ACPI video output device _ADR method return.
which went out of its way to cater to a specific BIOS, setting up DIDL based on _ADR method. Perhaps that approach worked on that specific machine, but on the machines I checked the _ADR method invents the device identifiers out of thin air if DIDL has not been set. The source for _ADR is also supposed to be the DIDL set by the driver, not the other way around.
With this, we'll also limit the number of outputs to what the driver actually has.
v2: do not set ACPI_DEVICE_ID_SCHEME in the device id (Peter Wu)
v3: Rebase
--- drivers/gpu/drm/i915/intel_drv.h | 3 ++ drivers/gpu/drm/i915/intel_opregion.c | 88 ++++++++++------------------------- 2 files changed, 27 insertions(+), 64 deletions(-)
drivers/gpu/drm/i915/intel_drv.h +3 -0
@@ -286,6 +286,9 @@ struct intel_connector {*/ struct intel_encoder *encoder; +/* ACPI device id for ACPI and driver cooperation */ +u32 acpi_device_id; +/* Reads out the current hw, returning true if the connector is enabled * and active (i.e. dpms ON state). */ bool (*get_hw_state)(struct intel_connector *);
drivers/gpu/drm/i915/intel_opregion.c +24 -64
122 lines not on this page · raw message
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/2 drm/i915/opregion: update cadl based on actually active outputs
In reply to Jani NikulaPreviously we've just shoved the first eight devices in DIDL to CADL (list of active outputs). Some of the active outputs may have been left outside of CADL. The problem is, some BIOS implementations prevent laptop brightness hotkey propagation if the flat panel is not active.
Now that we have connector to acpi device id mapping covered, we can update CADL based on which outputs are actually active.
v3: actually git add the dev->dev_priv change.
v4: update cadl in intel_shared_dpll_commit() if intel_state->modeset
(Maarten)
v5: use crtc mask, not ->active to determine active outputs (Maarten)
Move first cadl update to after hardware readout (Maarten)
--- drivers/gpu/drm/i915/i915_drv.h | 4 ++ drivers/gpu/drm/i915/intel_display.c | 6 +++ drivers/gpu/drm/i915/intel_opregion.c | 71 +++++++++++++++++++---------------- 3 files changed, 48 insertions(+), 33 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +4 -0
@@ -3610,6 +3610,8 @@ extern int intel_opregion_notify_encoder(struct intel_encoder *intel_encoder,extern int intel_opregion_notify_adapter (struct drm_i915_private *dev_priv,pci_power_t state);extern int intel_opregion_get_panel_type (struct drm_i915_private *dev_priv); +extern void intel_opregion_update_cadl (struct drm_i915_private *dev_priv, +unsigned int active_crtcs);#else static inline int intel_opregion_setup (struct drm_i915_private *dev) {return 0 ; }static inline void intel_opregion_register (struct drm_i915_private *dev_priv) { }
@@ -3631,6 +3633,8 @@ static inline int intel_opregion_get_panel_type(struct drm_i915_private *dev) {return -ENODEV ; } +static inline void intel_opregion_update_cadl (struct drm_i915_private *dev_priv, +unsigned int active_crtcs) { }#endif /* intel_acpi.c */
drivers/gpu/drm/i915/intel_display.c +6 -0
@@ -14537,6 +14537,10 @@ static int intel_atomic_commit(struct drm_device *dev, dev_priv->wm.distrust_bios_wm = false; dev_priv->wm.skl_results = intel_state->wm_results;intel_shared_dpll_commit (state); + +if (intel_state->modeset) +intel_opregion_update_cadl (dev_priv, intel_state->active_crtcs); +intel_atomic_track_fbs (state);if (nonblock)
@@ -16927,6 +16931,8 @@ intel_modeset_setup_hw_state(struct drm_device *dev)intel_display_set_init_power (dev_priv, false);intel_fbc_init_pipe_state (dev_priv); + +intel_opregion_update_cadl (dev_priv, dev_priv->active_crtcs); }void intel_display_resume (struct drm_device *dev)
drivers/gpu/drm/i915/intel_opregion.c +38 -33
97 lines not on this page · raw message
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/2] drm/i915/opregion: update cadl based on actually active outputs
Op 25-08-16 om 14:53 schreef Jani Nikula:
Quoted 8 lines
Previously we've just shoved the first eight devices in DIDL to CADL (list of active outputs). Some of the active outputs may have been left outside of CADL. The problem is, some BIOS implementations prevent laptop brightness hotkey propagation if the flat panel is not active.
Now that we have connector to acpi device id mapping covered, we can update CADL based on which outputs are actually active.
Quoted 7 lines
v3: actually git add the
dev->dev_privchange.v4: update cadl in
intel_shared_dpll_commit()ifintel_state->modeset
(Maarten)v5: use crtc mask, not ->active to determine active outputs (Maarten)
Move first cadl update to after hardware readout (Maarten)
Much better! I don't dare to do a thorough review of the non-atomicy parts, but idea looks good.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: warning for drm/i915/opregion: proper handling of DIDL and CADL
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/opregion: proper handling of DIDL and CADL
URL : https://patchwork.freedesktop.org/series/11565/
State : warning
== Summary ==
Series 11565v1 drm/i915/opregion: proper handling of DIDL and CADL
http://patchwork.freedesktop.org/api/1.0/series/11565/revisions/1/mbox/
Test gem_ringfill:
Subgroup basic-default-forked:
pass -> DMESG-WARN (fi-snb-2520m)
dmesg-warn -> PASS (fi-snb-2600)
Subgroup basic-default-hang:
dmesg-warn -> PASS (fi-snb-2520m)
pass -> DMESG-WARN (fi-snb-2600)fi-bdw-5557u total:252 pass:235 dwarn:0 dfail:0 fail:2 skip:15 fi-bsw-n3050 total:252 pass:205 dwarn:0 dfail:0 fail:1 skip:46 fi-byt-n2820 total:252 pass:207 dwarn:0 dfail:0 fail:3 skip:42 fi-hsw-4770k total:252 pass:228 dwarn:0 dfail:0 fail:2 skip:22 fi-hsw-4770r total:252 pass:224 dwarn:0 dfail:0 fail:2 skip:26 fi-ivb-3520m total:252 pass:220 dwarn:0 dfail:0 fail:1 skip:31 fi-skl-6260u total:252 pass:236 dwarn:0 dfail:0 fail:2 skip:14 fi-skl-6700k total:252 pass:222 dwarn:0 dfail:0 fail:2 skip:28 fi-snb-2520m total:252 pass:199 dwarn:8 dfail:0 fail:2 skip:43 fi-snb-2600 total:252 pass:199 dwarn:8 dfail:0 fail:2 skip:43
Results at /archive/results/CI_IGT_test/Patchwork_2431/
30de872fd5cf71a51994375fb4f76856c05b1c4c drm-intel-nightly: 2016y-08m-25d-11h-15m-39s UTC integration manifest 48dafce drm/i915/opregion: update cadl based on actually active outputs
b6f2e44 drm/i915: make i915 the source of acpi device ids for _DOD
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hello,
I applied these patches[1][2] to the latest kernel revision ( 4.8.0-rc3-g61c0457) but the brightness keys are not working on my laptop.
With the older patches from the 29th of June the brightness keys were working correctly.
Cheers,
[1] https://patchwork.freedesktop.org/patch/107280/
[2] https://patchwork.freedesktop.org/patch/107281/
Signature · 3 lines
Paolo Stivanin [email protected] Public Key ID: E71B7545
Quoted 22 lines · Jani Nikula
This is the next iteration of [1] and [2]. Please review and/or test, according to your abilities.
Thanks,
Jani.Cc Peter Wu <[email protected]>Cc Rainer Koenig <[email protected]>Cc Jan-Marek Glogowski <[email protected]>Cc Maarten Lankhorst <[email protected]>Cc Marcos Paulo de Souza <[email protected]>Cc Paolo Stivanin <[email protected]>[1]
http://mid.mail-archive.com/[email protected]
[2]
http://mid.mail-archive.com/[email protected]Jani Nikula (2):
drm/i915: make i915 the source of acpi device ids for_DODdrm/i915/opregion: update cadl based on actually active outputs
Quoted 10 lines
drivers/gpu/drm/i915/i915_drv.h | 4 + drivers/gpu/drm/i915/intel_display.c | 6 ++ drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/gpu/drm/i915/intel_opregion.c | 157 +++++++++++++--------------------- 4 files changed, 74 insertions(+), 96 deletions(-)Signature · 1 line
2.1.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 6 lines · Paolo Stivanin
Hello,
I applied these patches[1][2] to the latest kernel revision ( 4.8.0-rc3-g61c0457) but the brightness keys are not working on my laptop.
With the older patches from the 29th of June the brightness keys were working correctly.
Maarten, any ideas? The only changes are the change from crtc->active to active_crtcs, and the initialization change.
BR,
Jani.
Quoted 5 lines
Cheers,
[1] https://patchwork.freedesktop.org/patch/107280/
[2] https://patchwork.freedesktop.org/patch/107281/
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Op 25-08-16 om 20:56 schreef Paolo Stivanin:
Quoted 7 lines
Hello,
I applied these patches[1][2] to the latest kernel revision ( 4.8.0-rc3-g61c0457) but the brightness keys are not working on my laptop.
With the older patches from the 29th of June the brightness keys were working correctly.
Quoted 5 lines
Cheers,
[1] https://patchwork.freedesktop.org/patch/107280/
[2] https://patchwork.freedesktop.org/patch/107281/
Does it work after suspend?
~Maarten
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hello,
nope, also after suspend nothing changed.
I also tried using evtest before and after the patch and I got the same
result: nothing shows up when I press FN+F8/F9 (brightness)
Signature · 3 lines
Paolo Stivanin [email protected] Public Key ID: E71B7545
Quoted 8 lines · Maarten Lankhorst
Op 25-08-16 om 20:56 schreef Paolo Stivanin:
Quoted 7 lines
Hello,
I applied these patches[1][2] to the latest kernel revision ( 4.8.0-rc3-g61c0457) but the brightness keys are not working on my laptop.
With the older patches from the 29th of June the brightness keys were working correctly.
Quoted 9 lines
Quoted 5 lines
Cheers,
[1] https://patchwork.freedesktop.org/patch/107280/
[2] https://patchwork.freedesktop.org/patch/107281/Does it work after suspend?
~Maarten
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Paolo Stivanin
Hello,
nope, also after suspend nothing changed.
I also tried using evtest before and after the patch and I got the same
result: nothing shows up when I press FN+F8/F9 (brightness)
Hello,
Tested on an asus ux305FA, work only after fresh boot, not working after suspend/resume.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi Jani,
The method is somehow not reliable. At boot I was still able to capture brightness hotkeys (via acpi_listen). After starting SSDM and logging in, it still worked. Then I played a bit with PRIME output slaves, Xorg crashed at some points and hotkeys stopped working.
Inspection of CADL (via acpidbg) showed that it contained zeroes instead of 0x400. By poking more, suddenly the expected 0x400 value returned into CADL and hotkeys functioned again. At later moments it reverted to 0 again and hotkeys broke again.
Tracking down setters of active_crcts, I noticed that intel_modeset_readout_hw_state somehow does not detect eDP1 as active. Full dmesg log (9MiB) with drm.debug=0x1e (via sysfs) is available at
https://lekensteyn.nl/files/logs/journal-v4.8-rc3-183-g5e608a0-plus-2-cadl-patches.txt
Kind regards,
Peter
Quoted 29 lines · Jani Nikula
This is the next iteration of [1] and [2]. Please review and/or test, according to your abilities.
Thanks,
Jani.Cc Peter Wu <[email protected]>Cc Rainer Koenig <[email protected]>Cc Jan-Marek Glogowski <[email protected]>Cc Maarten Lankhorst <[email protected]>Cc Marcos Paulo de Souza <[email protected]>Cc Paolo Stivanin <[email protected]>[1] http://mid.mail-archive.com/[email protected]
[2] http://mid.mail-archive.com/[email protected]Jani Nikula (2):
drm/i915: make i915 the source of acpi device ids for_DODdrm/i915/opregion: update cadl based on actually active outputsdrivers/gpu/drm/i915/i915_drv.h | 4 + drivers/gpu/drm/i915/intel_display.c | 6 ++ drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/gpu/drm/i915/intel_opregion.c | 157 +++++++++++++--------------------- 4 files changed, 74 insertions(+), 96 deletions(-)Signature · 1 line
2.1.4
Signature · 7 lines
Kind regards, Peter Wu https://lekensteyn.nl _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Marcos Paulo de Souza
Tested-byHi Jani,
These patches made my brightness and screen off hot keys back to work.
Quoted 48 lines · Peter Wu
Hi Jani,
The method is somehow not reliable. At boot I was still able to capture brightness hotkeys (via
acpi_listen). After starting SSDM and logging in, it still worked. Then I played a bit with PRIME output slaves, Xorg crashed at some points and hotkeys stopped working.Inspection of CADL (via acpidbg) showed that it contained zeroes instead of
0x400. By poking more, suddenly the expected0x400value returned into CADL and hotkeys functioned again. At later moments it reverted to 0 again and hotkeys broke again.Tracking down setters of
active_crcts, I noticed thatintel_modeset_readout_hw_statesomehow does not detect eDP1 as active. Full dmesg log (9MiB) with drm.debug=0x1e (via sysfs) is available athttps://lekensteyn.nl/files/logs/journal-v4.8-rc3-183-g5e608a0-plus-2-cadl-patches.txt
Kind regards,
PeterQuoted 26 lines · Jani Nikula
This is the next iteration of [1] and [2]. Please review and/or test, according to your abilities.
Thanks,
Jani.Cc Peter Wu <[email protected]>Cc Rainer Koenig <[email protected]>Cc Jan-Marek Glogowski <[email protected]>Cc Maarten Lankhorst <[email protected]>Cc Marcos Paulo de Souza <[email protected]>Cc Paolo Stivanin <[email protected]>[1] http://mid.mail-archive.com/[email protected]
[2] http://mid.mail-archive.com/[email protected]Jani Nikula (2):
drm/i915: make i915 the source of acpi device ids for_DODdrm/i915/opregion: update cadl based on actually active outputsdrivers/gpu/drm/i915/i915_drv.h | 4 + drivers/gpu/drm/i915/intel_display.c | 6 ++ drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/gpu/drm/i915/intel_opregion.c | 157 +++++++++++++--------------------- 4 files changed, 74 insertions(+), 96 deletions(-)
Quoted 8 lines
Quoted 3 lines
Signature · 1 line
2.1.4Signature · 3 lines
Kind regards, Peter Wu https://lekensteyn.nl
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi Jani,
one quick questions: What happened to those CADL patches. I was expecting them to showup in the mainstream kernel.org kernel some day, but even in 4.9rc3 I cant't find them.
Best regards
Rainer
Am 25.08.2016 um 14:53 schrieb Jani Nikula:
Quoted 26 lines
This is the next iteration of [1] and [2]. Please review and/or test, according to your abilities.
Thanks,
Jani.Cc Peter Wu <[email protected]>Cc Rainer Koenig <[email protected]>Cc Jan-Marek Glogowski <[email protected]>Cc Maarten Lankhorst <[email protected]>Cc Marcos Paulo de Souza <[email protected]>Cc Paolo Stivanin <[email protected]>[1] http://mid.mail-archive.com/[email protected]
[2] http://mid.mail-archive.com/[email protected]Jani Nikula (2):
drm/i915: make i915 the source of acpi device ids for_DODdrm/i915/opregion: update cadl based on actually active outputsdrivers/gpu/drm/i915/i915_drv.h | 4 + drivers/gpu/drm/i915/intel_display.c | 6 ++ drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/gpu/drm/i915/intel_opregion.c | 157 +++++++++++++--------------------- 4 files changed, 74 insertions(+), 96 deletions(-)
Signature · 19 lines
Dipl.-Inf. (FH) Rainer Koenig Project Manager Linux Clients FJ EMEIA PR PSO PM&D CCD ENG SW OSS&C Fujitsu Technology Solutions Bürgermeister-Ullrich-Str. 100 86199 Augsburg Germany Telephone: +49-821-804-3321 Telefax: +49-821-804-2131 Mail: mailto:[email protected] Internet ts.fujtsu.com Company Details ts.fujitsu.com/imprint.html _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Rainer Koenig
Hi Jani,
one quick questions: What happened to those CADL patches. I was expecting them to showup in the mainstream kernel.org kernel some day, but even in 4.9rc3 I cant't find them.
Basically [1] and [2] happened, no idea what went wrong, and no time to debug.
BR,
Jani.
[1] http://mid.mail-archive.com/1472151415.3037046.706208097.7301895A@webmail.messagingengine.com
[2] http://mid.mail-archive.com/[email protected]
Quoted 31 lines
Best regards
RainerAm 25.08.2016 um 14:53 schrieb Jani Nikula:
Quoted 26 lines
This is the next iteration of [1] and [2]. Please review and/or test, according to your abilities.
Thanks,
Jani.Cc Peter Wu <[email protected]>Cc Rainer Koenig <[email protected]>Cc Jan-Marek Glogowski <[email protected]>Cc Maarten Lankhorst <[email protected]>Cc Marcos Paulo de Souza <[email protected]>Cc Paolo Stivanin <[email protected]>[1] http://mid.mail-archive.com/[email protected]
[2] http://mid.mail-archive.com/[email protected]Jani Nikula (2):
drm/i915: make i915 the source of acpi device ids for_DODdrm/i915/opregion: update cadl based on actually active outputsdrivers/gpu/drm/i915/i915_drv.h | 4 + drivers/gpu/drm/i915/intel_display.c | 6 ++ drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/gpu/drm/i915/intel_opregion.c | 157 +++++++++++++--------------------- 4 files changed, 74 insertions(+), 96 deletions(-)
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 9 lines · Jani Nikula
Quoted 5 lines · Rainer Koenig
Hi Jani,
one quick questions: What happened to those CADL patches. I was expecting them to showup in the mainstream kernel.org kernel some day, but even in 4.9rc3 I cant't find them.
Basically [1] and [2] happened, no idea what went wrong, and no time to debug.
Those, and virtually no positive feedback.
Quoted 39 lines
BR,
Jani.[1] http://mid.mail-archive.com/1472151415.3037046.706208097.7301895A@webmail.messagingengine.com
[2] http://mid.mail-archive.com/[email protected]Quoted 31 lines
Best regards
RainerAm 25.08.2016 um 14:53 schrieb Jani Nikula:
Quoted 26 lines
This is the next iteration of [1] and [2]. Please review and/or test, according to your abilities.
Thanks,
Jani.Cc Peter Wu <[email protected]>Cc Rainer Koenig <[email protected]>Cc Jan-Marek Glogowski <[email protected]>Cc Maarten Lankhorst <[email protected]>Cc Marcos Paulo de Souza <[email protected]>Cc Paolo Stivanin <[email protected]>[1] http://mid.mail-archive.com/[email protected]
[2] http://mid.mail-archive.com/[email protected]Jani Nikula (2):
drm/i915: make i915 the source of acpi device ids for_DODdrm/i915/opregion: update cadl based on actually active outputsdrivers/gpu/drm/i915/i915_drv.h | 4 + drivers/gpu/drm/i915/intel_display.c | 6 ++ drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/gpu/drm/i915/intel_opregion.c | 157 +++++++++++++--------------------- 4 files changed, 74 insertions(+), 96 deletions(-)
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Your patches fixed the problem in my Asus X450LCP. I'm also looking further to see these patches to land in master.
Thanks,
Quoted 54 lines · Jani Nikula
Quoted 9 lines · Jani Nikula
Quoted 5 lines · Rainer Koenig
Hi Jani,
one quick questions: What happened to those CADL patches. I was expecting them to showup in the mainstream kernel.org kernel some day, but even in 4.9rc3 I cant't find them.
Basically [1] and [2] happened, no idea what went wrong, and no time to debug.
Those, and virtually no positive feedback.
Quoted 5 lines
BR,
Jani.[1]
http://mid.mail-archive.com/1472151415.3037046.706208097.7301895A@webmail.messagingengine.com
Quoted 1 line
[2]
http://mid.mail-archive.com/[email protected]
Quoted 13 lines
Quoted 13 lines
Best regards
RainerAm 25.08.2016 um 14:53 schrieb Jani Nikula:
Quoted 6 lines
This is the next iteration of [1] and [2]. Please review and/or test, according to your abilities.
Thanks,
Jani.Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Cc Peter Wu <[email protected]>Cc Rainer Koenig <[email protected]>Cc Jan-Marek Glogowski <[email protected]>Cc Maarten Lankhorst <[email protected]>Cc Marcos Paulo de Souza <[email protected]>Cc Paolo Stivanin <[email protected]>[1]
http://mid.mail-archive.com/[email protected]
Quoted 1 line
Quoted 1 line
Quoted 1 line
[2]
http://mid.mail-archive.com/[email protected]
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Jani Nikula (2):
drm/i915: make i915 the source of acpi device ids for_DODdrm/i915/opregion: update cadl based on actually active outputsdrivers/gpu/drm/i915/i915_drv.h | 4 + drivers/gpu/drm/i915/intel_display.c | 6 ++ drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/gpu/drm/i915/intel_opregion.c | 157
Quoted 7 lines
+++++++++++++---------------------
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
4 files changed, 74 insertions(+), 96 deletions(-)--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi Jani,
this is sad and also bad news. Means that actually we don't have any driver which makes the brightness keys on the Fujitsu LIFEBOOK E7x6 series work.
On the other hand I saw that recent patches to intel_opregion.c introduced quirks based on the DMI strings for some machines. I consider this as a very bad idea, but if we do those crazy things, then is there a possibility to create similar quirks for the models we know that are working with your patch? ;-)
Best regards
Rainer
Am 25.08.2016 um 14:53 schrieb Jani Nikula:
Quoted 26 lines
This is the next iteration of [1] and [2]. Please review and/or test, according to your abilities.
Thanks,
Jani.Cc Peter Wu <[email protected]>Cc Rainer Koenig <[email protected]>Cc Jan-Marek Glogowski <[email protected]>Cc Maarten Lankhorst <[email protected]>Cc Marcos Paulo de Souza <[email protected]>Cc Paolo Stivanin <[email protected]>[1] http://mid.mail-archive.com/[email protected]
[2] http://mid.mail-archive.com/[email protected]Jani Nikula (2):
drm/i915: make i915 the source of acpi device ids for_DODdrm/i915/opregion: update cadl based on actually active outputsdrivers/gpu/drm/i915/i915_drv.h | 4 + drivers/gpu/drm/i915/intel_display.c | 6 ++ drivers/gpu/drm/i915/intel_drv.h | 3 + drivers/gpu/drm/i915/intel_opregion.c | 157 +++++++++++++--------------------- 4 files changed, 74 insertions(+), 96 deletions(-)
Signature · 19 lines
Dipl.-Inf. (FH) Rainer Koenig Project Manager Linux Clients FJ EMEIA PR PSO PM&D CCD ENG SW OSS&C Fujitsu Technology Solutions Bürgermeister-Ullrich-Str. 100 86199 Augsburg Germany Telephone: +49-821-804-3321 Telefax: +49-821-804-2131 Mail: mailto:[email protected] Internet ts.fujtsu.com Company Details ts.fujitsu.com/imprint.html _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 3 lines · Rainer Koenig
this is sad and also bad news. Means that actually we don't have any driver which makes the brightness keys on the Fujitsu LIFEBOOK E7x6 series work.
I hope we can make this work [1].
BR,
Jani.
[1] https://patchwork.freedesktop.org/series/15403/
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hello all,
@Jani Nikula: I just tried the patches you linked and they work *perfectly* on my notebook (Clevo P640RE). I also tried to suspend and resume the laptop and it works like a charm!
I applied the patches against the Linux kernel v4.8.8 taken from upstream.
Thanks again :)
Cheers,
Paolo
Signature · 3 lines
Paolo Stivanin [email protected] Public Key ID: E71B7545
Quoted 5 lines · Jani Nikula
Quoted 3 lines · Rainer Koenig
this is sad and also bad news. Means that actually we don't have any driver which makes the brightness keys on the Fujitsu LIFEBOOK E7x6 series work.
Quoted 9 lines
I hope we can make this work [1].
BR,
Jani.[1] https://patchwork.freedesktop.org/series/15403/
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Marcos Paulo de Souza
Tested-byHi,
Quoted 6 lines · Paolo Stivanin
Hello all,
@Jani Nikula: I just tried the patches you linked and they work *perfectly* on my notebook (Clevo P640RE). I also tried to suspend and resume the laptop and it works like a charm!
I applied the patches against the Linux kernel v4.8.8 taken from upstream.
I also tested here, and it fix the problem for me (the last patchset already fixed it, but it's importante to notice it still works). I hope to see this version merged.
Thanks a lot Jani.
Quoted 26 lines
Thanks again :)
Cheers,
Paolo
Signature · 3 lines
Paolo Stivanin [email protected] Public Key ID: E71B7545Quoted 14 lines · Jani Nikula
Quoted 3 lines · Rainer Koenig
this is sad and also bad news. Means that actually we don't have any driver which makes the brightness keys on the Fujitsu LIFEBOOK E7x6 series work.
I hope we can make this work [1].
BR,
Jani.[1] https://patchwork.freedesktop.org/series/15403/
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx