Skip to contentSkip to conversation

ARM: dts: imx7s-warp: Add Bluetooth support

PATCH Superseded Vanessa Maegima 2 participants 2 messages Aug 22, 2016 – Aug 29, 2016

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Vanessa Maegima

author
#0 lore raw

PATCH 1/1 ARM: dts: imx7s-warp: Add Bluetooth support

WaRP7 has a BCM4343 Bluetooth chip.

Add support for it.

Signed-off-by Vanessa Maegima <[email protected]>
---
 arch/arm/boot/dts/imx7s-warp.dts | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
arch/arm/boot/dts/imx7s-warp.dts +29 -0
index 92d9c85..6ce8953 100644
@@ -66,6 +66,16 @@
 		startup-delay-us = <200000>;
 	};
 
+	reg_bt: bt-reg {
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio5 17 GPIO_ACTIVE_HIGH>;
+		regulator-name = "bt_reg";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+	};
+
 	sound {
 		compatible = "simple-audio-card";
 		simple-audio-card,name = "imx7-sgtl5000";

@@ -228,6 +238,15 @@
 	status = "okay";
 };
 
+&uart3  {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart3>;
+	assigned-clocks = <&clks IMX7D_UART3_ROOT_SRC>;
+	assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>;
+	fsl,uart-has-rtscts;
+	status = "okay";
+};
+
 &usbotg1 {
 	dr_mode = "peripheral";
 	status = "okay";

@@ -302,6 +321,16 @@
 		>;
 	};
 
+	pinctrl_uart3: uart3grp {
+		fsl,pins = <
+			MX7D_PAD_UART3_TX_DATA__UART3_DCE_TX 0x79
+			MX7D_PAD_UART3_RX_DATA__UART3_DCE_RX 0x79
+			MX7D_PAD_UART3_CTS_B__UART3_DCE_CTS 0x79
+			MX7D_PAD_UART3_RTS_B__UART3_DCE_RTS 0x79
+			MX7D_PAD_SD2_DATA3__GPIO5_IO17 0x14 /*BT_REG_ON*/
+		>;
+	};
+
 	pinctrl_usdhc1: usdhc1grp {
 		fsl,pins = <
 			MX7D_PAD_SD1_CMD__SD1_CMD	0x59
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 ARM: dts: imx7s-warp: Add Bluetooth support

Quoted 14 lines · Vanessa Maegima

WaRP7 has a BCM4343 Bluetooth chip.

Add support for it.

Signed-off-by Vanessa Maegima <[email protected]>
---
 arch/arm/boot/dts/imx7s-warp.dts | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
arch/arm/boot/dts/imx7s-warp.dts +0 -0
index 92d9c85..6ce8953 100644

arch/arm/boot/dts/imx7s-warp.dts line 69

Quoted 4 lines
arch/arm/boot/dts/imx7s-warp.dts +1 -0
@@ -66,6 +66,16 @@
 		startup-delay-us = <200000>;
 	};
 
+	reg_bt: bt-reg {

Please name the fixed regulator like regulator-xxx.

arch/arm/boot/dts/imx7s-warp.dts line 76

Quoted 7 lines
arch/arm/boot/dts/imx7s-warp.dts +7 -0
+		compatible = "regulator-fixed";
+		enable-active-high;
+		gpio = <&gpio5 17 GPIO_ACTIVE_HIGH>;
+		regulator-name = "bt_reg";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-always-on;

Why should it be always-on?

Quoted 6 lines
arch/arm/boot/dts/imx7s-warp.dts +2 -0
+	};
+
 	sound {
 		compatible = "simple-audio-card";
 		simple-audio-card,name = "imx7-sgtl5000";

arch/arm/boot/dts/imx7s-warp.dts line 246

Quoted 9 lines
arch/arm/boot/dts/imx7s-warp.dts +6 -0
@@ -228,6 +238,15 @@
 	status = "okay";
 };
 
+&uart3  {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_uart3>;
+	assigned-clocks = <&clks IMX7D_UART3_ROOT_SRC>;
+	assigned-clock-parents = <&clks IMX7D_PLL_SYS_MAIN_240M_CLK>;
+	fsl,uart-has-rtscts;

This vendor specific property is deprecated. Please use generic one, uart-has-rtscts, instead.

Quoted 7 lines
arch/arm/boot/dts/imx7s-warp.dts +3 -0
+	status = "okay";
+};
+
 &usbotg1 {
 	dr_mode = "peripheral";
 	status = "okay";

arch/arm/boot/dts/imx7s-warp.dts line 330

Quoted 10 lines
arch/arm/boot/dts/imx7s-warp.dts +7 -0
@@ -302,6 +321,16 @@
 		>;
 	};
 
+	pinctrl_uart3: uart3grp {
+		fsl,pins = <
+			MX7D_PAD_UART3_TX_DATA__UART3_DCE_TX 0x79
+			MX7D_PAD_UART3_RX_DATA__UART3_DCE_RX 0x79
+			MX7D_PAD_UART3_CTS_B__UART3_DCE_CTS 0x79
+			MX7D_PAD_UART3_RTS_B__UART3_DCE_RTS 0x79
+			MX7D_PAD_SD2_DATA3__GPIO5_IO17 0x14 /*BT_REG_ON*/

It should be in a separate pinctrl entry for regulator.

Shawn

Quoted 14 lines
arch/arm/boot/dts/imx7s-warp.dts +3 -0
+		>;
+	};
+
 	pinctrl_usdhc1: usdhc1grp {
 		fsl,pins = <
 			MX7D_PAD_SD1_CMD__SD1_CMD	0x59
Signature · 7 lines
2.7.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel