ixgbevf: add spinlocks for MTU change calls
Subsystems (2)
PATCH 1/1 ixgbevf: add spinlocks for MTU change calls
Protect set_rlpml with mailbox lock to make sure tha MTU configuration is handled properly.
This change resolves an issue where set_rlpml can fail when the VF interface is brought up:
ixgbevf 0000:03:1d.6: Failed to set MTU at 1500
--- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +4 -0
@@ -1810,8 +1810,10 @@ static void ixgbevf_configure_rx(struct ixgbevf_adapter *adapter)if (hw->mac.type >= ixgbe_mac_X550_vf)ixgbevf_setup_vfmrqc (adapter); +spin_lock_bh (&adapter->mbx_lock);/* notify the PF of our intent to use this size of frame */ ret = hw->mac.ops.set_rlpml (hw, netdev->mtu +ETH_HLEN +ETH_FCS_LEN ); +spin_unlock_bh (&adapter->mbx_lock);if (ret)dev_err (&adapter->pdev->dev,"Failed to set MTU at %d\n" , netdev->mtu);
@@ -3758,8 +3760,10 @@ static int ixgbevf_change_mtu(struct net_device *netdev, int new_mtu)if ((new_mtu <68 ) || (max_frame > max_possible_frame))return -EINVAL ; +spin_lock_bh (&adapter->mbx_lock);/* notify the PF of our intent to use this size of frame */ ret = hw->mac.ops.set_rlpml (hw, max_frame); +spin_unlock_bh (&adapter->mbx_lock);if (ret)return -EINVAL ;
Bowers
PATCH 1/1 ixgbevf: add spinlocks for MTU change calls
Quoted 11 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On Behalf Of Emil Tantilov
Sent: Monday, August 29, 2016 4:39 PM
To: intel-wired-lan at lists.osuosl.org
Subject: [Intel-wired-lan] [PATCH] ixgbevf: add spinlocks for MTU change callsProtect
set_rlpmlwith mailbox lock to make sure tha MTU configuration is handled properly.
Quoted 8 lines
This change resolves an issue where
set_rlpmlcan fail when the VF interface is brought up:
ixgbevf 0000:03:1d.6: Failed to set MTU at 1500Signed-off-by Emil Tantilov <[email protected]>--- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++++ 1 file changed, 4 insertions(+)