dt-bindings: touchscreen: silead_gsl1680: Document touchscreen-fw-name
Subsystems (3)
PATCH 1/1 dt-bindings: touchscreen: silead_gsl1680: Document touchscreen-fw-name
The driver has supported touchscreen-fw-name to specify the firmware to load since day 0, but this was omitted from the binding, document this.
--- Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt +1 -0
@@ -17,6 +17,7 @@ Required properties: - touchscreen-size-y : See touchscreen.txt Optional properties: +- touchscreen-fw-name : Filename (string) for device specific firmware - touchscreen-inverted-x : See touchscreen.txt - touchscreen-inverted-y : See touchscreen.txt - touchscreen-swapped-x-y : See touchscreen.txt
Signature · 1 line
2.7.4
Rob Herring
maintainerPATCH 1/1 dt-bindings: touchscreen: silead_gsl1680: Document touchscreen-fw-name
Quoted 7 lines · Hans de Goede
The driver has supported touchscreen-fw-name to specify the firmware to load since day 0, but this was omitted from the binding, document this.
Signed-off-by Hans de Goede <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt | 1 + 1 file changed, 1 insertion(+)
I'd really like to deprecate in favor of a standard property name. We've somewhat agreed on 'firmware-name' though there is no common binding doc yet. But given this is in use:
PATCH 1/1 dt-bindings: touchscreen: silead_gsl1680: Document touchscreen-fw-name
Hi Rob,
Quoted 4 lines · Rob Herring
Quoted 3 lines · Hans de Goede
The driver has supported touchscreen-fw-name to specify the firmware to load since day 0, but this was omitted from the binding, document this.
Quoted 8 lines
Quoted 4 lines
Signed-off-by Hans de Goede <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt | 1 + 1 file changed, 1 insertion(+)I'd really like to deprecate in favor of a standard property name. We've somewhat agreed on 'firmware-name' though there is no common binding doc yet. But given this is in use:
This has been introduced in 4.8-rc1, so it hasn't been used in any stable version yet, and we don't have any users in tree so far.
If you want to something else, it feels like now is the time to change it.
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160829/9aea5655/attachment.sig>
PATCH 1/1 dt-bindings: touchscreen: silead_gsl1680: Document touchscreen-fw-name
Hi,
Quoted 16 lines · Maxime Ripard
Hi Rob,
Quoted 4 lines · Rob Herring
Quoted 3 lines · Hans de Goede
The driver has supported touchscreen-fw-name to specify the firmware to load since day 0, but this was omitted from the binding, document this.
Quoted 8 lines
Quoted 4 lines
Signed-off-by Hans de Goede <[email protected]>--- Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt | 1 + 1 file changed, 1 insertion(+)I'd really like to deprecate in favor of a standard property name. We've somewhat agreed on 'firmware-name' though there is no common binding doc yet. But given this is in use:
Quoted 5 lines
This has been introduced in 4.8-rc1, so it hasn't been used in any stable version yet, and we don't have any users in tree so far.
If you want to something else, it feels like now is the time to change it.
Ack, I can still change it to firmware-name if you want (Maxime has not yet merged any dts changes using the touchscreen-fw-name). We should probably also decide if the silead/ prefix we're using (so the firmware files are /lib/firmware/silead/foo.fw under Linux) goes into the firmware-name property as my current wip code is doing, or if we put the "silead/" part in the driver and only put the part after it in the property.
I've a feeling that just putting only the base filename (so no "silead/" prefix) in the property is best.
Regards,
Hans
PATCH 1/1 dt-bindings: touchscreen: silead_gsl1680: Document touchscreen-fw-name
Quoted 32 lines · Hans de Goede
Hi,
Quoted 16 lines · Maxime Ripard
Hi Rob,
Quoted 4 lines · Rob Herring
Quoted 3 lines · Hans de Goede
The driver has supported touchscreen-fw-name to specify the firmware to load since day 0, but this was omitted from the binding, document this.
Quoted 8 lines
Quoted 4 lines
Signed-off-by Hans de Goede <[email protected]>---
Documentation/devicetree/bindings/input/touchscreen/silead_gsl1680.txt| 1 +1 file changed, 1 insertion(+)I'd really like to deprecate in favor of a standard property name. We've somewhat agreed on 'firmware-name' though there is no common binding doc yet. But given this is in use:
Quoted 5 lines
This has been introduced in 4.8-rc1, so it hasn't been used in any stable version yet, and we don't have any users in tree so far.
If you want to something else, it feels like now is the time to change it.
Ack, I can still change it to firmware-name if you want (Maxime has not yet merged any dts changes using the touchscreen-fw-name). We should probably also decide if the silead/ prefix we're using (so the firmware files are
/lib/firmware/silead/foo.fwunder Linux) goes into the firmware-name property as my current wip code is doing, or if we put the "silead/" part in the driver and only put the part after it in the property.
Quoted 2 lines
I've a feeling that just putting only the base filename (so no "silead/" prefix) in the property is best.
Yes, I would agree too.
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160830/c9e82411/attachment.sig>