Skip to contentSkip to conversation

ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO

PATCH New Tomi Valkeinen 5 participants 11 messages Sep 1, 2016 – Nov 14, 2017 Device tree bindings

lore
Share & tools
lore

Tomi Valkeinen

author
#0 lore raw

PATCH 1/1 ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO

LS_OE GPIO was changed from gpio6_28 to gpio2_30 for the Rev B1 board, and the current .dts file has the old GPIO.

Rev B1 is the earliest board supported, so we can just change the .dts.

This fixes "omapdss error: HDMI I2C Master Error" which causes failure to read EDID from the monitor.

Signed-off-by Tomi Valkeinen <[email protected]>
---
 arch/arm/boot/dts/am57xx-beagle-x15.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/am57xx-beagle-x15.dts +1 -1
index c4d04c5293b9..07603d9e2da7 100644
@@ -120,7 +120,7 @@
 		pinctrl-0 = <&tpd12s015_pins>;
 
 		gpios = <&gpio7 10 GPIO_ACTIVE_HIGH>,	/* gpio7_10, CT CP HPD */
-			<&gpio6 28 GPIO_ACTIVE_HIGH>,	/* gpio6_28, LS OE */
+			<&gpio2 30 GPIO_ACTIVE_HIGH>,	/* gpio2_30, LS OE */
 			<&gpio7 12 GPIO_ACTIVE_HIGH>;	/* gpio7_12/sp1_cs2, HPD */
 
 		ports {
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO

Quoted 19 lines · Tomi Valkeinen

LS_OE GPIO was changed from gpio6_28 to gpio2_30 for the Rev B1 board, and the current .dts file has the old GPIO.

Rev B1 is the earliest board supported, so we can just change the .dts.

This fixes "omapdss error: HDMI I2C Master Error" which causes failure to read EDID from the monitor.

Signed-off-by Tomi Valkeinen <[email protected]>
---
 arch/arm/boot/dts/am57xx-beagle-x15.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/am57xx-beagle-x15.dts +0 -0
index c4d04c5293b9..07603d9e2da7 100644

arch/arm/boot/dts/am57xx-beagle-x15.dts line 126

Quoted 8 lines
arch/arm/boot/dts/am57xx-beagle-x15.dts +1 -1
@@ -120,7 +120,7 @@
 		pinctrl-0 = <&tpd12s015_pins>;
 
 		gpios = <&gpio7 10 GPIO_ACTIVE_HIGH>,	/* gpio7_10, CT CP HPD */
-			<&gpio6 28 GPIO_ACTIVE_HIGH>,	/* gpio6_28, LS OE */
+			<&gpio2 30 GPIO_ACTIVE_HIGH>,	/* gpio2_30, LS OE */
 			<&gpio7 12 GPIO_ACTIVE_HIGH>;	/* gpio7_12/sp1_cs2, HPD */
 
 		ports {

I believe we have A2s being shipped as well. we dont want to break A2s either -> I propose we refactor the dts to introduce revb1 X15.

Signature · 2 lines
Regards,
Nishanth Menon
#2 lore raw

PATCH 1/1 ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO

Quoted 32 lines · Nishanth Menon
Quoted 31 lines · Tomi Valkeinen

LS_OE GPIO was changed from gpio6_28 to gpio2_30 for the Rev B1 board, and the current .dts file has the old GPIO.

Rev B1 is the earliest board supported, so we can just change the .dts.

This fixes "omapdss error: HDMI I2C Master Error" which causes failure to read EDID from the monitor.

Signed-off-by Tomi Valkeinen <[email protected]>
---
 arch/arm/boot/dts/am57xx-beagle-x15.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/am57xx-beagle-x15.dts +0 -0
index c4d04c5293b9..07603d9e2da7 100644
@@ -120,7 +120,7 @@
                pinctrl-0 = <&tpd12s015_pins>;
 
                gpios = <&gpio7 10 GPIO_ACTIVE_HIGH>,   /* gpio7_10, CT CP

HPD */
- <&gpio6 28 GPIO_ACTIVE_HIGH>, /* gpio6_28, LS OE
*/
+ <&gpio2 30 GPIO_ACTIVE_HIGH>, /* gpio2_30, LS OE
*/

                        <&gpio7 12 GPIO_ACTIVE_HIGH>;   /*

gpio7_12/sp1_cs2, HPD */

Quoted 5 lines
Quoted 2 lines
                ports {

I believe we have A2s being shipped as well. we dont want to break A2s either -> I propose we refactor the dts to introduce revb1 X15.

There are at-least 200 A2's that have been shipped to end users.

http://uk.rs-online.com/web/p/processor-microcontroller-development-kits/8874764/

Regards,

Signature · 2 lines
Robert Nelson
https://rcn-ee.com/
#3 lore raw

PATCH 1/1 ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO

Quoted 39 lines · Robert Nelson
Quoted 32 lines · Nishanth Menon
Quoted 31 lines · Tomi Valkeinen

LS_OE GPIO was changed from gpio6_28 to gpio2_30 for the Rev B1 board, and the current .dts file has the old GPIO.

Rev B1 is the earliest board supported, so we can just change the .dts.

This fixes "omapdss error: HDMI I2C Master Error" which causes failure to read EDID from the monitor.

Signed-off-by Tomi Valkeinen <[email protected]>
---
 arch/arm/boot/dts/am57xx-beagle-x15.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/am57xx-beagle-x15.dts +0 -0
index c4d04c5293b9..07603d9e2da7 100644
@@ -120,7 +120,7 @@
                pinctrl-0 = <&tpd12s015_pins>;
 
                gpios = <&gpio7 10 GPIO_ACTIVE_HIGH>,   /* gpio7_10, CT CP

HPD */
- <&gpio6 28 GPIO_ACTIVE_HIGH>, /* gpio6_28, LS OE
*/
+ <&gpio2 30 GPIO_ACTIVE_HIGH>, /* gpio2_30, LS OE
*/

                        <&gpio7 12 GPIO_ACTIVE_HIGH>;   /*

gpio7_12/sp1_cs2, HPD */

Quoted 5 lines
Quoted 2 lines
                ports {

I believe we have A2s being shipped as well. we dont want to break A2s either -> I propose we refactor the dts to introduce revb1 X15.

Quoted 3 lines

There are at-least 200 A2's that have been shipped to end users.

http://uk.rs-online.com/web/p/processor-microcontroller-development-kits/8874764/

Thanks. Tomi: if you are ok - I already do have a refactoring code from older kernel. I will rebase to latest and repost.

Tony: is there a branch youd' like me to base the changes on?

Signature · 2 lines
Regards,
Nishanth Menon
author
#4 lore raw

PATCH 1/1 ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO

Quoted 11 lines · Nishanth Menon
Quoted 7 lines
Quoted 2 lines

I believe we have A2s being shipped as well. we dont want to break A2s either -> I propose we refactor the dts to introduce revb1 X15.

There are at-least 200 A2's that have been shipped to end users.

http://uk.rs-online.com/web/p/processor-microcontroller-development-kits/8874764/

Thanks. Tomi: if you are ok - I already do have a refactoring code from older kernel. I will rebase to latest and repost.

Sounds good to me.

Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160901/a81fda17/attachment.sig>

#5 lore raw

PATCH 1/1 ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO

In reply to Nishanth Menon
Quoted 11 lines · Nishanth Menon
Quoted 10 lines · Robert Nelson
Quoted 9 lines · Nishanth Menon
Quoted 8 lines · Tomi Valkeinen

LS_OE GPIO was changed from gpio6_28 to gpio2_30 for the Rev B1 board, and the current .dts file has the old GPIO.

Rev B1 is the earliest board supported, so we can just change the .dts.

This fixes "omapdss error: HDMI I2C Master Error" which causes failure to read EDID from the monitor.

...

Quoted 5 lines
Quoted 5 lines
Quoted 2 lines

I believe we have A2s being shipped as well. we dont want to break A2s either -> I propose we refactor the dts to introduce revb1 X15.

There are at-least 200 A2's that have been shipped to end users.

Quoted 7 lines
Quoted 1 line

http://uk.rs-online.com/web/p/processor-microcontroller-development-kits/8874764/

Thanks. Tomi: if you are ok - I already do have a refactoring code from older kernel. I will rebase to latest and repost.

Tony: is there a branch youd' like me to base the changes on?

Probably best to do it against current omapf-for-v4.9/dt as it has all the skeleton.dtsi removal now applied.

Regards,

Tony

#6 lore raw

PATCH 1/1 ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO

Quoted 21 lines · Tony Lindgren
Quoted 11 lines · Nishanth Menon
Quoted 10 lines · Robert Nelson
Quoted 9 lines · Nishanth Menon
Quoted 8 lines · Tomi Valkeinen

LS_OE GPIO was changed from gpio6_28 to gpio2_30 for the Rev B1 board, and the current .dts file has the old GPIO.

Rev B1 is the earliest board supported, so we can just change the .dts.

This fixes "omapdss error: HDMI I2C Master Error" which causes failure to read EDID from the monitor.

...

Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

I believe we have A2s being shipped as well. we dont want to break A2s either -> I propose we refactor the dts to introduce revb1 X15.

There are at-least 200 A2's that have been shipped to end users.

http://uk.rs-online.com/web/p/processor-microcontroller-development-kits/8874764/

Quoted 7 lines
Quoted 4 lines

Thanks. Tomi: if you are ok - I already do have a refactoring code from older kernel. I will rebase to latest and repost.

Tony: is there a branch youd' like me to base the changes on?

Probably best to do it against current omapf-for-v4.9/dt as it has all the skeleton.dtsi removal now applied.

Ok will do, will try to post this later today or early tomorrow.

Signature · 2 lines
Regards,
Nishanth Menon
#7 lore raw

PATCH 1/1 ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO

Quoted 36 lines · Nishanth Menon
Quoted 35 lines · Tony Lindgren
Quoted 16 lines · Nishanth Menon
Quoted 14 lines · Robert Nelson
Quoted 12 lines · Nishanth Menon
Quoted 10 lines · Tomi Valkeinen

LS_OE GPIO was changed from gpio6_28 to gpio2_30 for the Rev B1 board, and the current .dts file has the old GPIO.

Rev B1 is the earliest board supported, so we can just change the .dts.

This fixes "omapdss error: HDMI I2C Master Error" which causes failure to read EDID from the monitor.

...

Quoted 15 lines
Quoted 9 lines
Quoted 3 lines

I believe we have A2s being shipped as well. we dont want to break A2s either -> I propose we refactor the dts to introduce revb1 X15.

There are at-least 200 A2's that have been shipped to end users.

http://uk.rs-online.com/web/p/processor-microcontroller-development-kits/8874764/

Thanks. Tomi: if you are ok - I already do have a refactoring code from older kernel. I will rebase to latest and repost.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Tony: is there a branch youd' like me to base the changes on?

Probably best to do it against current omapf-for-v4.9/dt as it has all the skeleton.dtsi removal now applied.

Ok will do, will try to post this later today or early tomorrow.

I'm getting this error again with the latest X15 image on my A2 version board. I don't see this patch in the mainline kernel. Did it never get applied?

Thanks
Bill

Quoted 16 lines

--
Regards,
Nishanth Menon

--
You received this message because you are subscribed to the Google Groups "beagleboard-x15" group.
To unsubscribe from this group and stop receiving emails from it, send an email to beagleboard-x15+unsubscribe at googlegroups.com.
To post to this group, send email to beagleboard-x15 at googlegroups.com. To view this discussion on the web visit
https://groups.google.com/d/msgid/beagleboard-x15/de3bf6ab-a07a-b82d-1e45-5f96a6e1039e%40ti.com.

For more options, visit https://groups.google.com/d/optout.

author
#8 lore raw

PATCH 1/1 ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO

Quoted 3 lines · Bill Traynor

I'm getting this error again with the latest X15 image on my A2 version board. I don't see this patch in the mainline kernel. Did it never get applied?

With am57xx-beagle-x15.dts? That seems be the A2 version.

Signature · 2 lines
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
#9 lore raw

PATCH 1/1 ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO

Quoted 7 lines · Tomi Valkeinen
Quoted 3 lines · Bill Traynor

I'm getting this error again with the latest X15 image on my A2 version board. I don't see this patch in the mainline kernel. Did it never get applied?

With am57xx-beagle-x15.dts? That seems be the A2 version.

Yes.
I see the following in the boot message

loading /boot/dtbs/4.9.35-ti-r44/am57xx-beagle-x15.dtb ...

I can get around this by inserting/uninserting an sdcard once the kernel starts booting.

This is with the Debian 9.0 2017-07-02 4GB SD LXQT image.

Thanks
Bill

Quoted 4 lines

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

#10 lore raw

PATCH 1/1 ARM: dts: am57xx-beagle-x15: fix HDMI LS_OE GPIO

Quoted 12 lines · Bill Traynor
Quoted 7 lines · Tomi Valkeinen
Quoted 3 lines · Bill Traynor

I'm getting this error again with the latest X15 image on my A2 version board. I don't see this patch in the mainline kernel. Did it never get applied?

With am57xx-beagle-x15.dts? That seems be the A2 version.

Yes.
I see the following in the boot message

Quoted 6 lines

loading /boot/dtbs/4.9.35-ti-r44/am57xx-beagle-x15.dtb ...

I can get around this by inserting/uninserting an sdcard once the kernel starts booting.

This is with the Debian 9.0 2017-07-02 4GB SD LXQT image.

Weird, ldo1 is set to always on:

https://github.com/RobertCNelson/linux-stable-rcn-ee/blob/4.9.35-ti-r44/arch/arm/boot/dts/am57xx-beagle-x15-common.dtsi#L276-L283

Something else is going on..

Regards,

Signature · 2 lines
Robert Nelson
https://rcn-ee.com/