Skip to contentSkip to conversation

Missing exports in dtc 1.4.1 release - Make new release adding them?

PATCH Danny Milosavljevic 2 participants 2 messages Sep 1, 2016 – Sep 3, 2016 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

Hi,

I'm packaging dtc for the GNU Guix distribution.

In the process we found that Debian patches dtc 1.4.1 in order to add missing exports fdt_first_subnode, fdt_next_subnode, fdt_address_cells, fdt_size_cells, fdt_stringlist_contains, fdt_resize.

Are these supposed to be exported?

If so, could you make a bugfix release tarball with just these added?

The patches are:
From a4b093f7366fdb429ca1781144d3985fa50d0fbb Mon Sep 17 00:00:00 2001
From: Julien Grall <[email protected]>
Date: Tue, 17 Mar 2015 16:00:34 +0000
Subject: [PATCH] libfdt: Add missing functions to shared library

The commit 4e76ec7 "libfdt: Add fdt_next_subnode() to permit easy subnode iteration" adds new functions (fdt_{first,next}_subnode) but forgot to mark them as 'global' in the shared library.

---
 libfdt/version.lds | 2 ++
 1 file changed, 2 insertions(+)
libfdt/version.lds +2 -0
index 80b322b..941208e 100644
@@ -54,6 +54,8 @@ LIBFDT_1.2 {
 		fdt_get_property_by_offset;
 		fdt_getprop_by_offset;
 		fdt_next_property_offset;
+		fdt_first_subnode;
+		fdt_next_subnode;
 
 	local:
 		*;
Signature · 15 lines
2.8.1
From f58799be130e27cc729cb2d45566daa0bb3b8605 Mon Sep 17 00:00:00 2001
From: David Gibson <[email protected]>
Date: Tue, 1 Dec 2015 12:55:21 +1100
Subject: [PATCH] libfdt: Add some missing symbols to version.lds

Several functions in the header file were missing from the version.lds
script, meaning that they couldn't be used from a libfdt shared library.

Reported by Ken Aaker, via github issue tracker.

Signed-off-by: David Gibson <[email protected]>
---
 libfdt/version.lds | 4 ++++
 1 file changed, 4 insertions(+)
libfdt/version.lds +4 -0
index f19f157..1f4e1ea 100644
@@ -57,6 +57,10 @@ LIBFDT_1.2 {
 		fdt_next_property_offset;
 		fdt_first_subnode;
 		fdt_next_subnode;
+		fdt_address_cells;
+		fdt_size_cells;
+		fdt_stringlist_contains;
+		fdt_resize;
 
 	local:
 		*;
Signature · 4 lines
2.8.1

Thanks,
   Danny

A message that is not in the archive (sent off-list or not yet received): [email protected]

#2 lore raw
Quoted 7 lines · Danny Milosavljevic

Hi,

I'm packaging dtc for the GNU Guix distribution.

In the process we found that Debian patches dtc 1.4.1 in order to add missing exports fdt_first_subnode, fdt_next_subnode, fdt_address_cells, fdt_size_cells, fdt_stringlist_contains, fdt_resize.

Are these supposed to be exported?

Yes they are. In fact a patch already got merged upstream to add them (and some others) to the version.lds - it just didn't go into a release yet.

Quoted 2 lines

If so, could you make a bugfix release tarball with just these added?

I packaged up a release with the latest git, including the export of these symbols, and a handful of other small bugfixes.

Quoted 29 lines

The patches are:

Quoted 1 line

From a4b093f7366fdb429ca1781144d3985fa50d0fbb Mon Sep 17 00:00:00 2001

From: Julien Grall <[email protected]>
Date: Tue, 17 Mar 2015 16:00:34 +0000
Subject: [PATCH] libfdt: Add missing functions to shared library

The commit 4e76ec7 "libfdt: Add fdt_next_subnode() to permit easy subnode iteration" adds new functions (fdt_{first,next}_subnode) but forgot to mark them as 'global' in the shared library.

---
 libfdt/version.lds | 2 ++
 1 file changed, 2 insertions(+)
libfdt/version.lds +2 -0
index 80b322b..941208e 100644
@@ -54,6 +54,8 @@ LIBFDT_1.2 {
 		fdt_get_property_by_offset;
 		fdt_getprop_by_offset;
 		fdt_next_property_offset;
+		fdt_first_subnode;
+		fdt_next_subnode;
 
 	local:
 		*;
Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson