lxc: revive "drop-werror" patch
PATCH 1/1 lxc: revive "drop-werror" patch
commit 5050a94ae9f448641e05ce29c931671ffdc62784 dropped patch that remove '-Werror' from CFLAGS. However, it seems this patch is still necessary:
http://autobuild.buildroot.net/results/b1cbca6d0396863654b1d09ccc3163c5f6124ab8
http://autobuild.buildroot.net/results/fcf2834ad74b95548d25dad2274704ea401f9665
http://autobuild.buildroot.net/results/048be2fc702c9dba9ca4439ff687d71b30c10551
http://autobuild.buildroot.net/results/939246c9a4f433dfd0dc414988f5957441b8e9b4
--- package/lxc/0001-drop-werror.patch | 16 ++++++++++++++++ package/lxc/lxc.mk | 2 ++ 2 files changed, 18 insertions(+) create mode 100644 package/lxc/0001-drop-werror.patch
package/lxc/0001-drop-werror.patch new file +16 -0
@@ -0,0 +1,16 @@ +Don't do -Werror it breaks builds on some scenarios with trivialities. + +Signed-off-by: Gustavo Zacarias <[email protected]> + +diff -Nura lxc-lxc-1.0.4/configure.ac lxc-lxc-1.0.4.orig/configure.ac +--- lxc-lxc-1.0.4.orig/configure.ac 2014-07-04 10:31:19.821029891 -0300 ++++ lxc-lxc-1.0.4/configure.ac 2014-06-13 14:07:45.000000000 -0300 +@@ -560,7 +560,7 @@ + LXC_CHECK_TLS + + if test "x$GCC" = "xyes"; then +- CFLAGS="$CFLAGS -Wall -Werror" ++ CFLAGS="$CFLAGS -Wall" + fi + + # Files requiring some variable expansion
package/lxc/lxc.mk +2 -0
@@ -9,6 +9,8 @@ LXC_SITE = https://linuxcontainers.org/downloads/lxc LXC_LICENSE = LGPLv2.1+ LXC_LICENSE_FILES = COPYING LXC_DEPENDENCIES = libcap host-pkgconf +# we're patching configure.ac +LXC_AUTORECONF = YES LXC_CONF_OPTS = --disable-apparmor --with-distro=buildroot \ --disable-lua --disable-python \ $(if $(BR2_PACKAGE_BASH),,--disable-bash)
Signature · 1 line
1.9.1
Thomas Petazzoni
AppliedPATCH 1/1 lxc: revive "drop-werror" patch
Hello,
Quoted 9 lines · J?r?me Pouiller
commit
5050a94ae9f448641e05ce29c931671ffdc62784dropped patch that remove '-Werror' from CFLAGS. However, it seems this patch is still necessary:http://autobuild.buildroot.net/results/b1cbca6d0396863654b1d09ccc3163c5f6124ab8
http://autobuild.buildroot.net/results/fcf2834ad74b95548d25dad2274704ea401f9665
http://autobuild.buildroot.net/results/048be2fc702c9dba9ca4439ff687d71b30c10551
http://autobuild.buildroot.net/results/939246c9a4f433dfd0dc414988f5957441b8e9b4
Quoted 6 lines
Signed-off-by J?r?me Pouiller <[email protected]>--- package/lxc/0001-drop-werror.patch | 16 ++++++++++++++++ package/lxc/lxc.mk | 2 ++ 2 files changed, 18 insertions(+) create mode 100644 package/lxc/0001-drop-werror.patch
Applied to master, thanks. However, could you submit upstream that can be accepted? For example, something that adds a --disable-werror option.
Thanks,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 lxc: revive "drop-werror" patch
Hello Thomas,
Quoted 15 lines · On Saturday 03 September 2016 20:53:35 Thomas Petazzoni wrote:
Quoted 14 lines · J?r?me Pouiller
commit
5050a94ae9f448641e05ce29c931671ffdc62784dropped patch that remove '-Werror' from CFLAGS. However, it seems this patch is still necessary:
http://autobuild.buildroot.net/results/b1cbca6d0396863654b1d09ccc3
163c5f6124ab8
http://autobuild.buildroot.net/results/fcf2834ad74b95548d25dad227
4704ea401f9665
http://autobuild.buildroot.net/results/048be2fc702c9dba9ca4439ff6
87d71b30c10551
http://autobuild.buildroot.net/results/939246c9a4f433dfd0dc414988
f5957441b8e9b4>Signed-off-by J?r?me Pouiller <[email protected]>---
Quoted 8 lines
Quoted 4 lines
package/lxc/0001-drop-werror.patch | 16 ++++++++++++++++ package/lxc/lxc.mk | 2 ++ 2 files changed, 18 insertions(+) create mode 100644 package/lxc/0001-drop-werror.patchApplied to master, thanks. However, could you submit upstream that can be accepted? For example, something that adds a --disable-werror option.
Unfortunately, it was rejected: https://github.com/lxc/lxc/pull/1168. I have never been a good advocate.
Signature · 3 lines
J?r?me Pouiller, Sysmic Embedded Linux specialist http://www.sysmic.fr
PATCH 1/1 lxc: revive "drop-werror" patch
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"J?r?me" == J?r?me Pouiller <[email protected]> writes:
Hi,
Quoted 6 lines
Quoted 3 lines
Applied to master, thanks. However, could you submit upstream that can be accepted? For example, something that adds a --disable-werror option.
Unfortunately, it was rejected: https://github.com/lxc/lxc/pull/1168. I have never been a good advocate.
Seems like we managed to convince them after all, thanks all!
Signature · 1 line
Bye, Peter Korsgaard