Skip to contentSkip to conversation

ARM: dts: imx6qdl: Fix SPDIF regression

PATCH New Fabio Estevam 3 participants 3 messages Aug 31, 2016 – Sep 5, 2016

Subsystems (3)
Stable branch Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 ARM: dts: imx6qdl: Fix SPDIF regression

Commit 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif") changed many more clocks than only the SPDIF core clock as stated in the commit message.

The MLB clock has been added and this causes SPDIF regression as reported by Xavi Drudis Ferran and also in this forum post:
https://forum.digikey.com/thread/34240

The MX6Q Reference Manual does not mention that MLB is a clock related to SPDIF, so change it back to a dummy clock to restore SPDIF functionality.

Thanks to Ambika for providing the fix at:
https://community.nxp.com/thread/387131

Fixes 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
Cc <[email protected]> # 4.4.x
Reported-by Xavi Drudis Ferran <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx6qdl.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6qdl.dtsi +1 -1
index b620ac8..b13b0b2 100644
@@ -243,7 +243,7 @@
 					clocks = <&clks IMX6QDL_CLK_SPDIF_GCLK>, <&clks IMX6QDL_CLK_OSC>,
 						 <&clks IMX6QDL_CLK_SPDIF>, <&clks IMX6QDL_CLK_ASRC>,
 						 <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_ESAI_EXTAL>,
-						 <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_MLB>,
+						 <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_DUMMY>,
 						 <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_SPBA>;
 					clock-names = "core",  "rxtx0",
 						      "rxtx1", "rxtx2",
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: dts: imx6qdl: Fix SPDIF regression

El Wed, Aug 31, 2016 at 10:56:48AM -0300, Fabio Estevam deia:

Quoted 39 lines

Commit 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif") changed many more clocks than only the SPDIF core clock as stated in the commit message.

The MLB clock has been added and this causes SPDIF regression as reported by Xavi Drudis Ferran and also in this forum post:
https://forum.digikey.com/thread/34240

The MX6Q Reference Manual does not mention that MLB is a clock related to SPDIF, so change it back to a dummy clock to restore SPDIF functionality.

Thanks to Ambika for providing the fix at:
https://community.nxp.com/thread/387131

Fixes 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
Cc <[email protected]> # 4.4.x
Reported-by Xavi Drudis Ferran <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx6qdl.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx6qdl.dtsi +1 -1
index b620ac8..b13b0b2 100644
@@ -243,7 +243,7 @@
 					clocks = <&clks IMX6QDL_CLK_SPDIF_GCLK>, <&clks IMX6QDL_CLK_OSC>,
 						 <&clks IMX6QDL_CLK_SPDIF>, <&clks IMX6QDL_CLK_ASRC>,
 						 <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_ESAI_EXTAL>,
-						 <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_MLB>,
+						 <&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_DUMMY>,
 						 <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_SPBA>;
 					clock-names = "core",  "rxtx0",
 						      "rxtx1", "rxtx2",
Signature · 1 line
1.9.1
Tested-by Xavi Drudis Ferran <[email protected]>

(on linux-libre-4.7, wandboard-quad-rev-b1, imx6q MCIMX6Q5EYM10AC ,according to wandboard manual BOM) Before the change I didn't hear output on spdif, after the change output sounds ok.

Applied
#2 lore raw

PATCH 1/1 ARM: dts: imx6qdl: Fix SPDIF regression

In reply to Fabio Estevam
Quoted 12 lines · Fabio Estevam

Commit 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif") changed many more clocks than only the SPDIF core clock as stated in the commit message.

The MLB clock has been added and this causes SPDIF regression as reported by Xavi Drudis Ferran and also in this forum post:
https://forum.digikey.com/thread/34240

The MX6Q Reference Manual does not mention that MLB is a clock related to SPDIF, so change it back to a dummy clock to restore SPDIF functionality.

Quoted 7 lines

Thanks to Ambika for providing the fix at:
https://community.nxp.com/thread/387131

Fixes 833f2cbf7091 ("ARM: dts: imx6: change the core clock of spdif")
Cc <[email protected]> # 4.4.x
Reported-by Xavi Drudis Ferran <[email protected]>
Signed-off-by Fabio Estevam <[email protected]>

Applied, thanks.