Skip to contentSkip to conversation

image.bbclass: do not check size of the debugfs image

PATCH In review André Draszik 2 participants 4 messages Sep 5, 2016 – Sep 13, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 image.bbclass: do not check size of the debugfs image

The debugfs is supposed to be used in addition to the normal image for debugging purposes, it doesn't make sense to artificially limit its maximum size.

---
 meta/classes/image.bbclass | 6 ++++++
 1 file changed, 6 insertions(+)
meta/classes/image.bbclass +6 -0
index 07bd2d6..cb7d06d 100644
@@ -538,6 +538,12 @@ def get_rootfs_size(d):
     base_size += rootfs_alignment - 1
     base_size -= base_size % rootfs_alignment
 
+    # Do not check image size of the debugfs image. This is not supposed
+    # to be deployed, etc. so it doesn't make sense to limit the size
+    # of the debug.
+    if (d.getVar('IMAGE_BUILDING_DEBUGFS', True) or "") == "true":
+        return base_size
+
     # Check the rootfs size against IMAGE_ROOTFS_MAXSIZE (if set)
     if rootfs_maxsize:
         rootfs_maxsize_int = int(rootfs_maxsize)
Signature · 1 line
2.9.3
#1 lore raw

ping

Quoted 26 lines · André Draszik

The debugfs is supposed to be used in addition to the normal image for debugging purposes, it doesn't make sense to artificially limit its maximum size.

---
 meta/classes/image.bbclass | 6 ++++++

 1 file changed, 6 insertions(+)
meta/classes/image.bbclass +0 -0
index 07bd2d6..cb7d06d 100644
@@ -538,6 +538,12 @@ def get_rootfs_size(d):

     base_size += rootfs_alignment - 1
     base_size -= base_size % rootfs_alignment

+    # Do not check image size of the debugfs image. This is not supposed +    # to be deployed, etc. so it doesn't make sense to limit the size +    # of the debug.
+    if (d.getVar('IMAGE_BUILDING_DEBUGFS', True) or "") == "true":
+        return base_size
+
     # Check the rootfs size against IMAGE_ROOTFS_MAXSIZE (if set) if rootfs_maxsize:
         rootfs_maxsize_int = int(rootfs_maxsize)

#2 lore raw

Well there must have been some list/gmail snafu, as I definitely don't have this patch locally but patchwork has it. I wonder what else I'm missing...

Ross

Quoted 35 lines · André Draszik

ping

Quoted 16 lines · André Draszik

The debugfs is supposed to be used in addition to the normal image for debugging purposes, it doesn't make sense to artificially limit its maximum size.

---
 meta/classes/image.bbclass | 6 ++++++
 1 file changed, 6 insertions(+)
meta/classes/image.bbclass +0 -0
index 07bd2d6..cb7d06d 100644
@@ -538,6 +538,12 @@ def get_rootfs_size(d):
     base_size += rootfs_alignment - 1
     base_size -= base_size % rootfs_alignment

meta/classes/image.bbclass def get_rootfs_size(d): · line 549

Quoted 10 lines
meta/classes/image.bbclass +6 -0
 
+    # Do not check image size of the debugfs image. This is not supposed
+    # to be deployed, etc. so it doesn't make sense to limit the size
+    # of the debug.
+    if (d.getVar('IMAGE_BUILDING_DEBUGFS', True) or "") == "true":
+        return base_size
+
     # Check the rootfs size against IMAGE_ROOTFS_MAXSIZE (if set)
     if rootfs_maxsize:
         rootfs_maxsize_int = int(rootfs_maxsize)

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw

Somebody did mention last week (Monday?) on IRC that mails are not arriving. In the mailman web interface they aren't missing though (which is what I sometimes use to check)... Strange

Andre'

Quoted 47 lines · Ross

Well there must have been some list/gmail snafu, as I definitely don't have
this patch locally but patchwork has it.  I wonder what else I'm missing...

Ross

Quoted 38 lines · André Draszik

ping

Quoted 18 lines · André Draszik

The debugfs is supposed to be used in addition to the normal image for debugging purposes, it doesn't make sense to artificially limit its maximum size.

---
 meta/classes/image.bbclass | 6 ++++++

 1 file changed, 6 insertions(+)
meta/classes/image.bbclass +0 -0
index 07bd2d6..cb7d06d 100644
@@ -538,6 +538,12 @@ def get_rootfs_size(d):

     base_size += rootfs_alignment - 1
     base_size -= base_size % rootfs_alignment

Quoted 10 lines

+    # Do not check image size of the debugfs image. This is not supposed
+    # to be deployed, etc. so it doesn't make sense to limit the size +    # of the debug.
+    if (d.getVar('IMAGE_BUILDING_DEBUGFS', True) or "") == "true":
+        return base_size
+
     # Check the rootfs size against IMAGE_ROOTFS_MAXSIZE (if set) if rootfs_maxsize:
         rootfs_maxsize_int = int(rootfs_maxsize)

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core