Skip to contentSkip to conversation

arm-cci: Fix typo in event name

PATCH New Suzuki K Poulose 2 participants 3 messages Sep 2, 2016 – Sep 5, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm-cci: Fix typo in event name

Fixes a typo in one of the event name for CCI

---
 drivers/bus/arm-cci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bus/arm-cci.c +1 -1
index 5755907f..ffa7c9d 100644
@@ -551,7 +551,7 @@ static struct attribute *cci5xx_pmu_event_attrs[] = {
 	CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_wrq, 0xB),
 	CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_snoop_cd_hs, 0xC),
 	CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_rq_stall_addr_hazard, 0xD),
-	CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_snopp_rq_stall_tt_full, 0xE),
+	CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_snoop_rq_stall_tt_full, 0xE),
 	CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_snoop_rq_tzmp1_prot, 0xF),
 	NULL
 };
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 arm-cci: Fix typo in event name

Quoted 1 line · Suzuki K Poulose

Fixes a typo in one of the event name for CCI

Nit: s/name/names/

Coudl you please expand the commit message to something like:

For one of the CCI events exposed under sysfs, "snoop" was typo'd as "snopp". Correct this such that users see the expected event name when enumerating events via sysfs.

With that:

Quoted 23 lines
---
 drivers/bus/arm-cci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bus/arm-cci.c +1 -1
index 5755907f..ffa7c9d 100644
@@ -551,7 +551,7 @@ static struct attribute *cci5xx_pmu_event_attrs[] = {
 	CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_wrq, 0xB),
 	CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_snoop_cd_hs, 0xC),
 	CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_rq_stall_addr_hazard, 0xD),
-	CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_snopp_rq_stall_tt_full, 0xE),
+	CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_snoop_rq_stall_tt_full, 0xE),
 	CCI5xx_GLOBAL_EVENT_EXT_ATTR_ENTRY(cci_snoop_rq_tzmp1_prot, 0xF),
 	NULL
 };
Signature · 1 line
2.7.4
#2 lore raw

PATCH 1/1 arm-cci: Fix typo in event name

Quoted 7 lines · Mark Rutland
Quoted 1 line · Suzuki K Poulose

Fixes a typo in one of the event name for CCI

Nit: s/name/names/

Coudl you please expand the commit message to something like:

Quoted 7 lines

For one of the CCI events exposed under sysfs, "snoop" was typo'd as "snopp". Correct this such that users see the expected event name when enumerating events via sysfs.

With that:

Sure, will do.

Thanks
Suzuki