Skip to contentSkip to conversation

staging: dgnc: Fix multi line comment alignment

PATCH In review Fernando Apesteguia 2 participants 4 messages Sep 5, 2016 – Sep 6, 2016 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: dgnc: Fix multi line comment alignment

Fix alignment in multi line comment block.

Remove extra '*' to use the preferred comment style as in Documentation/CodingStyle

---
 drivers/staging/dgnc/dgnc_driver.c | 50 +++++++++++++++++++-------------------
 1 file changed, 25 insertions(+), 25 deletions(-)
drivers/staging/dgnc/dgnc_driver.c +25 -25
index cc6105a..01e948c 100644
@@ -602,31 +602,31 @@ static void dgnc_do_remap(struct dgnc_board *brd)
 	brd->re_map_membase = ioremap(brd->membase, 0x1000);
 }
 
-/*****************************************************************************
-*
-* Function:
-*
-*    dgnc_poll_handler
-*
-* Author:
-*
-*    Scott H Kilau
-*
-* Parameters:
-*
-*    dummy -- ignored
-*
-* Return Values:
-*
-*    none
-*
-* Description:
-*
-*    As each timer expires, it determines (a) whether the "transmit"
-*    waiter needs to be woken up, and (b) whether the poller needs to
-*    be rescheduled.
-*
-******************************************************************************/
+/*
+ *
+ * Function:
+ *
+ *    dgnc_poll_handler
+ *
+ * Author:
+ *
+ *    Scott H Kilau
+ *
+ * Parameters:
+ *
+ *    dummy -- ignored
+ *
+ * Return Values:
+ *
+ *    none
+ *
+ * Description:
+ *
+ *    As each timer expires, it determines (a) whether the "transmit"
+ *    waiter needs to be woken up, and (b) whether the poller needs to
+ *    be rescheduled.
+ *
+ */
 
 static void dgnc_poll_handler(ulong dummy)
 {
Signature · 1 line
2.7.4
#1 lore raw
Quoted 73 lines · Fernando Apesteguia

Fix alignment in multi line comment block.

Remove extra '*' to use the preferred comment style as in Documentation/CodingStyle

---
 drivers/staging/dgnc/dgnc_driver.c | 50 +++++++++++++++++++-------------------
 1 file changed, 25 insertions(+), 25 deletions(-)
drivers/staging/dgnc/dgnc_driver.c +25 -25
index cc6105a..01e948c 100644
@@ -602,31 +602,31 @@ static void dgnc_do_remap(struct dgnc_board *brd)
 	brd->re_map_membase = ioremap(brd->membase, 0x1000);
 }
 
-/*****************************************************************************
-*
-* Function:
-*
-*    dgnc_poll_handler
-*
-* Author:
-*
-*    Scott H Kilau
-*
-* Parameters:
-*
-*    dummy -- ignored
-*
-* Return Values:
-*
-*    none
-*
-* Description:
-*
-*    As each timer expires, it determines (a) whether the "transmit"
-*    waiter needs to be woken up, and (b) whether the poller needs to
-*    be rescheduled.
-*
-******************************************************************************/
+/*
+ *
+ * Function:
+ *
+ *    dgnc_poll_handler
+ *
+ * Author:
+ *
+ *    Scott H Kilau
+ *
+ * Parameters:
+ *
+ *    dummy -- ignored
+ *
+ * Return Values:
+ *
+ *    none
+ *
+ * Description:
+ *
+ *    As each timer expires, it determines (a) whether the "transmit"
+ *    waiter needs to be woken up, and (b) whether the poller needs to
+ *    be rescheduled.
+ *
+ */
 
 static void dgnc_poll_handler(ulong dummy)
 {
Signature · 1 line
2.7.4

Changing first and last lines of that comment should be enough, but all lines got changed. I'd (re)submit it with just first and last lines changed.

#2 lore raw
Quoted 70 lines · Andrey Utkin
Quoted 69 lines · Fernando Apesteguia

Fix alignment in multi line comment block.

Remove extra '*' to use the preferred comment style as in Documentation/CodingStyle

---
 drivers/staging/dgnc/dgnc_driver.c | 50 +++++++++++++++++++-------------------
 1 file changed, 25 insertions(+), 25 deletions(-)
drivers/staging/dgnc/dgnc_driver.c +25 -25
index cc6105a..01e948c 100644
@@ -602,31 +602,31 @@ static void dgnc_do_remap(struct dgnc_board *brd)
 	brd->re_map_membase = ioremap(brd->membase, 0x1000);
 }
 
-/*****************************************************************************
-*
-* Function:
-*
-*    dgnc_poll_handler
-*
-* Author:
-*
-*    Scott H Kilau
-*
-* Parameters:
-*
-*    dummy -- ignored
-*
-* Return Values:
-*
-*    none
-*
-* Description:
-*
-*    As each timer expires, it determines (a) whether the "transmit"
-*    waiter needs to be woken up, and (b) whether the poller needs to
-*    be rescheduled.
-*
-******************************************************************************/
+/*
+ *
+ * Function:
+ *
+ *    dgnc_poll_handler
+ *
+ * Author:
+ *
+ *    Scott H Kilau
+ *
+ * Parameters:
+ *
+ *    dummy -- ignored
+ *
+ * Return Values:
+ *
+ *    none
+ *
+ * Description:
+ *
+ *    As each timer expires, it determines (a) whether the "transmit"
+ *    waiter needs to be woken up, and (b) whether the poller needs to
+ *    be rescheduled.
+ *
+ */
 
Quoted 8 lines
Quoted 4 lines
drivers/staging/dgnc/dgnc_driver.c +0 -0
 static void dgnc_poll_handler(ulong dummy)
 {
Signature · 1 line
2.7.4

Changing first and last lines of that comment should be enough, but all lines got changed. I'd (re)submit it with just first and last lines changed.

Sorry, but I fail to see how I can align all the lines by changing just the first and last ones.

#3 lore raw
Quoted 1 line · Fernando Apesteguia

Sorry, but I fail to see how I can align all the lines by changing just the first and last ones.

Ah now I see that original version doesn't have spaces before asterisk. Sorry for noise.