Skip to contentSkip to conversation

qt5base: remove libudev dependency from kms

PATCH New Peter Seiderer 3 participants 4 messages Aug 20, 2016 – Sep 6, 2016

lore
Share & tools
lore

Peter Seiderer

author
#0 lore raw

PATCH 1/1 qt5base: remove libudev dependency from kms

Use upstream patch [1]

Fixes [2]:

KMS auto-detection... ()
Project ERROR: libudev development package not found
KMS disabled.
KMS support cannot be enabled due to functionality tests! Turn on verbose messaging (-v) to ./configure to see the final report. If you believe this message is in error you may use the continue switch (-continue) to ./configure to continue.

[1] https://code.qt.io/cgit/qt/qtbase.git/patch/?id=72492735b7b7770808fcc9fe067e8f03fab827fc
[2] http://autobuild.buildroot.net/results/063/063859ad460552dd7c101115500b7845045a134f

Signed-off-by Peter Seiderer <[email protected]>
---
 ...07-Remove-libudev-dependency-from-kms.pro.patch | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 package/qt5/qt5base/0007-Remove-libudev-dependency-from-kms.pro.patch
package/qt5/qt5base/0007-Remove-libudev-dependency-from-kms.pro.patch new file +33 -0
new file mode 100644
index 0000000..7ecbcd0
@@ -0,0 +1,33 @@
+From 0f1b4bb65abe0e36e9e4b9813e45192223509de8 Mon Sep 17 00:00:00 2001
+From: Ralf Nolden <[email protected]>
+Date: Tue, 17 May 2016 12:57:17 +0200
+Subject: [PATCH] Remove libudev dependency from kms.pro
+
+To compile the kms qpa plugin, only libdrm is needed.
+Remove the libudev dependency for the compile check to enable
+building of the qpa plugin on platforms where libudev is not present
+such as BSD systems (but where KMS works)
+
+Change-Id: Icd0be70a8949578a6158d523428706890a9674eb
+Reviewed-by: Laszlo Agocs <[email protected]>
+Reviewed-by: Oswald Buddenhagen <[email protected]>
+
+Upstream: https://code.qt.io/cgit/qt/qtbase.git/patch/?id=72492735b7b7770808fcc9fe067e8f03fab827fc
+Signed-off-by: Peter Seiderer <[email protected]>
+---
+ config.tests/qpa/kms/kms.pro | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/config.tests/qpa/kms/kms.pro b/config.tests/qpa/kms/kms.pro
+index 1fb7367..5147bc8 100644
+--- a/config.tests/qpa/kms/kms.pro
++++ b/config.tests/qpa/kms/kms.pro
+@@ -1,4 +1,4 @@
+ SOURCES = kms.cpp
+ CONFIG += link_pkgconfig
+-PKGCONFIG += libdrm libudev
++PKGCONFIG += libdrm
+ CONFIG -= qt
+-- 
+2.8.1
+
Signature · 1 line
2.8.1
Applied
#1 lore raw

PATCH 1/1 qt5base: remove libudev dependency from kms

Hello,

Quoted 12 lines · Peter Seiderer

Use upstream patch [1]

Fixes [2]:

KMS auto-detection... ()
Project ERROR: libudev development package not found
KMS disabled.
KMS support cannot be enabled due to functionality tests! Turn on verbose messaging (-v) to ./configure to see the final report. If you believe this message is in error you may use the continue switch (-continue) to ./configure to continue.

Quoted 8 lines

[1] https://code.qt.io/cgit/qt/qtbase.git/patch/?id=72492735b7b7770808fcc9fe067e8f03fab827fc
[2] http://autobuild.buildroot.net/results/063/063859ad460552dd7c101115500b7845045a134f

Signed-off-by Peter Seiderer <[email protected]>
---
 ...07-Remove-libudev-dependency-from-kms.pro.patch | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 package/qt5/qt5base/0007-Remove-libudev-dependency-from-kms.pro.patch

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 qt5base: remove libudev dependency from kms

In reply to Peter Seiderer

Peter, All,

On 2016-08-20 21:09 +0200, Peter Seiderer spake thusly:

Quoted 1 line

Use upstream patch [1]

I'd say be carefull when backporting patches from upstream, especially since upstream has changed the license after the Qt-5.6 release.

Backporting a patch in this case would risk propagating the new license.

However, this is acceptable in this case, because this only touches the .pro file, which is part of the buildsystem.

Regards,
Yann E. MORIN.

Quoted 65 lines

Fixes [2]:

KMS auto-detection... ()
Project ERROR: libudev development package not found
KMS disabled.
KMS support cannot be enabled due to functionality tests! Turn on verbose messaging (-v) to ./configure to see the final report. If you believe this message is in error you may use the continue switch (-continue) to ./configure to continue.

[1] https://code.qt.io/cgit/qt/qtbase.git/patch/?id=72492735b7b7770808fcc9fe067e8f03fab827fc
[2] http://autobuild.buildroot.net/results/063/063859ad460552dd7c101115500b7845045a134f

Signed-off-by Peter Seiderer <[email protected]>
---
 ...07-Remove-libudev-dependency-from-kms.pro.patch | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 package/qt5/qt5base/0007-Remove-libudev-dependency-from-kms.pro.patch
package/qt5/qt5base/0007-Remove-libudev-dependency-from-kms.pro.patch new file +33 -0
new file mode 100644
index 0000000..7ecbcd0
@@ -0,0 +1,33 @@
+From 0f1b4bb65abe0e36e9e4b9813e45192223509de8 Mon Sep 17 00:00:00 2001
+From: Ralf Nolden <[email protected]>
+Date: Tue, 17 May 2016 12:57:17 +0200
+Subject: [PATCH] Remove libudev dependency from kms.pro
+
+To compile the kms qpa plugin, only libdrm is needed.
+Remove the libudev dependency for the compile check to enable
+building of the qpa plugin on platforms where libudev is not present
+such as BSD systems (but where KMS works)
+
+Change-Id: Icd0be70a8949578a6158d523428706890a9674eb
+Reviewed-by: Laszlo Agocs <[email protected]>
+Reviewed-by: Oswald Buddenhagen <[email protected]>
+
+Upstream: https://code.qt.io/cgit/qt/qtbase.git/patch/?id=72492735b7b7770808fcc9fe067e8f03fab827fc
+Signed-off-by: Peter Seiderer <[email protected]>
+---
+ config.tests/qpa/kms/kms.pro | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/config.tests/qpa/kms/kms.pro b/config.tests/qpa/kms/kms.pro
+index 1fb7367..5147bc8 100644
+--- a/config.tests/qpa/kms/kms.pro
++++ b/config.tests/qpa/kms/kms.pro
+@@ -1,4 +1,4 @@
+ SOURCES = kms.cpp
+ CONFIG += link_pkgconfig
+-PKGCONFIG += libdrm libudev
++PKGCONFIG += libdrm
+ CONFIG -= qt
+-- 
+2.8.1
+
Signature · 6 lines
2.8.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author
#3 lore raw

PATCH 1/1 qt5base: remove libudev dependency from kms

Hello Yann,

Quoted 10 lines · Yann E. MORIN

Peter, All,

On 2016-08-20 21:09 +0200, Peter Seiderer spake thusly:

Quoted 1 line

Use upstream patch [1]

I'd say be carefull when backporting patches from upstream, especially since upstream has changed the license after the Qt-5.6 release.

Backporting a patch in this case would risk propagating the new license.

Thanks for license change hint, will double check in future...

Hope it is no problem here because the same patch (despite my original source link from 5.7 branch) is although available from the 5.6 branch ([3])...

Regards,
Peter

[3] https://code.qt.io/cgit/qt/qtbase.git/commit/config.tests/qpa/kms/kms.pro?h=5.6&id=72492735b7b7770808fcc9fe067e8f03fab827fc

Quoted 72 lines

However, this is acceptable in this case, because this only touches the .pro file, which is part of the buildsystem.

Regards,
Yann E. MORIN.

Quoted 65 lines

Fixes [2]:

KMS auto-detection... ()
Project ERROR: libudev development package not found
KMS disabled.
KMS support cannot be enabled due to functionality tests! Turn on verbose messaging (-v) to ./configure to see the final report. If you believe this message is in error you may use the continue switch (-continue) to ./configure to continue.

[1] https://code.qt.io/cgit/qt/qtbase.git/patch/?id=72492735b7b7770808fcc9fe067e8f03fab827fc
[2] http://autobuild.buildroot.net/results/063/063859ad460552dd7c101115500b7845045a134f

Signed-off-by Peter Seiderer <[email protected]>
---
 ...07-Remove-libudev-dependency-from-kms.pro.patch | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 package/qt5/qt5base/0007-Remove-libudev-dependency-from-kms.pro.patch
package/qt5/qt5base/0007-Remove-libudev-dependency-from-kms.pro.patch new file +33 -0
new file mode 100644
index 0000000..7ecbcd0
@@ -0,0 +1,33 @@
+From 0f1b4bb65abe0e36e9e4b9813e45192223509de8 Mon Sep 17 00:00:00 2001
+From: Ralf Nolden <[email protected]>
+Date: Tue, 17 May 2016 12:57:17 +0200
+Subject: [PATCH] Remove libudev dependency from kms.pro
+
+To compile the kms qpa plugin, only libdrm is needed.
+Remove the libudev dependency for the compile check to enable
+building of the qpa plugin on platforms where libudev is not present
+such as BSD systems (but where KMS works)
+
+Change-Id: Icd0be70a8949578a6158d523428706890a9674eb
+Reviewed-by: Laszlo Agocs <[email protected]>
+Reviewed-by: Oswald Buddenhagen <[email protected]>
+
+Upstream: https://code.qt.io/cgit/qt/qtbase.git/patch/?id=72492735b7b7770808fcc9fe067e8f03fab827fc
+Signed-off-by: Peter Seiderer <[email protected]>
+---
+ config.tests/qpa/kms/kms.pro | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/config.tests/qpa/kms/kms.pro b/config.tests/qpa/kms/kms.pro
+index 1fb7367..5147bc8 100644
+--- a/config.tests/qpa/kms/kms.pro
++++ b/config.tests/qpa/kms/kms.pro
+@@ -1,4 +1,4 @@
+ SOURCES = kms.cpp
+ CONFIG += link_pkgconfig
+-PKGCONFIG += libdrm libudev
++PKGCONFIG += libdrm
+ CONFIG -= qt
+-- 
+2.8.1
+
Signature · 6 lines
2.8.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot