Skip to contentSkip to conversation

drivers/gpu/drm/i915/intel_display.c:2954:11: warning: cast to pointer

DISCUSSION Nick Warne 2 participants 6 messages Sep 7, 2016 – Sep 10, 2016

lore
Share & tools
lore

Nick Warne

author
#0 lore raw

Hi Daniel,

kernel build 4.4.20 - I am still seeing this warning:

drivers/gpu/drm/i915/intel_display.c: In function ‘intel_plane_obj_offset’: drivers/gpu/drm/i915/intel_display.c:2969:11:
warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] offset = (unsigned char *)vma->node.start;

but according to here:

https://patchwork.kernel.org/patch/7897461/

this has been fixed up. Any reason why it hasn't in the latest 4.4.x longterm tree?

Thanks,

Nick

Signature · 3 lines
Gosh that takes me back... or is it forward?  That's the trouble with
time travel, you never can tell."
		-- Doctor Who "Androids of Tara"
#1 lore raw
Quoted 9 lines · Nick Warne

Hi Daniel,

kernel build 4.4.20 - I am still seeing this warning:

drivers/gpu/drm/i915/intel_display.c: In function ‘intel_plane_obj_offset’: drivers/gpu/drm/i915/intel_display.c:2969:11:
warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] offset = (unsigned char *)vma->node.start;

Quoted 6 lines

but according to here:

https://patchwork.kernel.org/patch/7897461/

this has been fixed up. Any reason why it hasn't in the latest 4.4.x longterm tree?

What is the commit id that fixed this in Linus's tree?

thanks,

greg k-h

author
#2 lore raw
Quoted 11 lines · On Thu, 8 Sep 2016 08:29:37 +0200 Greg Kroah-Hartman…
Quoted 10 lines · Nick Warne

Hi Daniel,

kernel build 4.4.20 - I am still seeing this warning:

drivers/gpu/drm/i915/intel_display.c: In function ‘intel_plane_obj_offset’:
drivers/gpu/drm/i915/intel_display.c:2969:11: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] offset = (unsigned char *)vma->node.start;

Quoted 8 lines
Quoted 6 lines

but according to here:

https://patchwork.kernel.org/patch/7897461/

this has been fixed up. Any reason why it hasn't in the latest 4.4.x longterm tree?

What is the commit id that fixed this in Linus's tree?

Took me a while to find it if this is it - a bit of a re-write in the whole file I think:

https://github.com/torvalds/linux/commit/44eb0cb9620c6a53ec8e7073262e2af8079b727f

Thanks,

Nick

Signature · 3 lines
Gosh that takes me back... or is it forward?  That's the trouble with
time travel, you never can tell."
		-- Doctor Who "Androids of Tara"
#3 lore raw
Quoted 21 lines · Nick Warne
Quoted 18 lines · On Thu, 8 Sep 2016 08:29:37 +0200 Greg Kroah-Hartman…
Quoted 16 lines · Nick Warne

Hi Daniel,

kernel build 4.4.20 - I am still seeing this warning:

drivers/gpu/drm/i915/intel_display.c: In function ‘intel_plane_obj_offset’:
drivers/gpu/drm/i915/intel_display.c:2969:11: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] offset = (unsigned char *)vma->node.start;

but according to here:

https://patchwork.kernel.org/patch/7897461/

this has been fixed up. Any reason why it hasn't in the latest 4.4.x longterm tree?

Quoted 6 lines
Quoted 1 line

What is the commit id that fixed this in Linus's tree?

Took me a while to find it if this is it - a bit of a re-write in the whole file I think:

https://github.com/torvalds/linux/commit/44eb0cb9620c6a53ec8e7073262e2af8079b727f

Ick, messy.

Why not just use 4.7? Why are you stuck at 4.4?

And is this a real bug in 4.4 or just a build warning?

thanks,

greg k-h

author
#4 lore raw
Quoted 24 lines · On Fri, 9 Sep 2016 13:55:45 +0200 Greg Kroah-Hartman…
Quoted 23 lines · Nick Warne
Quoted 19 lines · On Thu, 8 Sep 2016 08:29:37 +0200 Greg Kroah-Hartman…
Quoted 10 lines · Nick Warne

Hi Daniel,

kernel build 4.4.20 - I am still seeing this warning:

drivers/gpu/drm/i915/intel_display.c: In function ‘intel_plane_obj_offset’:
drivers/gpu/drm/i915/intel_display.c:2969:11: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] offset = (unsigned char *)vma->node.start;

Quoted 6 lines

but according to here:

https://patchwork.kernel.org/patch/7897461/

this has been fixed up. Any reason why it hasn't in the latest 4.4.x longterm tree?

What is the commit id that fixed this in Linus's tree?

Quoted 8 lines
Quoted 4 lines

Took me a while to find it if this is it - a bit of a re-write in the whole file I think:

https://github.com/torvalds/linux/commit/44eb0cb9620c6a53ec8e7073262e2af8079b727f

Ick, messy.

Why not just use 4.7? Why are you stuck at 4.4?

I only recently moved over to 4.4 from 3.18.x as it's longterm support. I may try 4.7 over the weekend - or maybe even just use the patchwork diff on my own local builds.

Quoted 1 line

And is this a real bug in 4.4 or just a build warning?

No, it's not a bug (that I have found or seen, anyway), just GCC squinnying.

Thanks for your help, and sorry for the noise.

Nick

Signature · 3 lines
Gosh that takes me back... or is it forward?  That's the trouble with
time travel, you never can tell."
		-- Doctor Who "Androids of Tara"
author
#5 lore raw
In reply to Greg Kroah-Hartman
Quoted 24 lines · On Fri, 9 Sep 2016 13:55:45 +0200 Greg Kroah-Hartman…
Quoted 23 lines · Nick Warne
Quoted 19 lines · On Thu, 8 Sep 2016 08:29:37 +0200 Greg Kroah-Hartman…
Quoted 10 lines · Nick Warne

Hi Daniel,

kernel build 4.4.20 - I am still seeing this warning:

drivers/gpu/drm/i915/intel_display.c: In function ‘intel_plane_obj_offset’:
drivers/gpu/drm/i915/intel_display.c:2969:11: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] offset = (unsigned char *)vma->node.start;

Quoted 6 lines

but according to here:

https://patchwork.kernel.org/patch/7897461/

this has been fixed up. Any reason why it hasn't in the latest 4.4.x longterm tree?

What is the commit id that fixed this in Linus's tree?

Quoted 8 lines
Quoted 4 lines

Took me a while to find it if this is it - a bit of a re-write in the whole file I think:

https://github.com/torvalds/linux/commit/44eb0cb9620c6a53ec8e7073262e2af8079b727f

Ick, messy.

Why not just use 4.7? Why are you stuck at 4.4?

OK, running on 4.7.3 - no issues, all Hunky Dory.

Thanks Greg and kernel people - grand job you all do!

Best regards,

Nick

Signature · 3 lines
Gosh that takes me back... or is it forward?  That's the trouble with
time travel, you never can tell."
		-- Doctor Who "Androids of Tara"