Skip to contentSkip to conversation

Fix fastboot boot address

PATCH New Peter.Chubb at data61.csiro.au 3 participants 3 messages Sep 8, 2016 – Dec 30, 2016 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix fastboot boot address

Fastboot loads an image at CONFIG_FASTBOOT_BUF_ADDR, but currently tells do_bootm() to look for an image at $loadaddr. This breaks if CONFIG_FASTBOOT_BUF_ADDR is different from the current user-set loadaddr.

Instead, tell do_bootm() to pick up the image where it was laoded.

---
 drivers/usb/gadget/f_fastboot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/f_fastboot.c +1 -1
index 2160b1c..6d02248 100644
@@ -553,7 +553,7 @@ static void do_bootm_on_complete(struct usb_ep *ep, struct usb_request *req)
 
 	puts("Booting kernel..\n");
 
-	sprintf(boot_addr_start, "0x%lx", load_addr);
+	sprintf(boot_addr_start, "0x%lx", CONFIG_FASTBOOT_BUF_ADDR);
 	do_bootm(NULL, 0, 2, bootm_args);
 
 	/* This only happens if image is somehow faulty so we start over */
Signature · 1 line
2.9.3
#1 lore raw

PATCH 1/1 Fix fastboot boot address

Quoted 8 lines · On Thu, Sep 08, 2016 at 08:51:57PM +0000, Peter.Chubb at data61.csiro.au wrote:

Fastboot loads an image at CONFIG_FASTBOOT_BUF_ADDR, but currently tells do_bootm() to look for an image at $loadaddr. This breaks if CONFIG_FASTBOOT_BUF_ADDR is different from the current user-set loadaddr.

Instead, tell do_bootm() to pick up the image where it was laoded.

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160908/e62de0ca/attachment.sig>
#2 lore raw

PATCH 1/1 Fix fastboot boot address

Quoted 13 lines · Tom Rini
Quoted 8 lines · On Thu, Sep 08, 2016 at 08:51:57PM +0000, Peter.Chubb at data61.csiro.au wrote:

Fastboot loads an image at CONFIG_FASTBOOT_BUF_ADDR, but currently tells do_bootm() to look for an image at $loadaddr. This breaks if CONFIG_FASTBOOT_BUF_ADDR is different from the current user-set loadaddr.

Instead, tell do_bootm() to pick up the image where it was laoded.

Quoted 7 lines

--
Tom

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Thanks, Steve