ARM: imx35: add iim module to imx35.dtsi
Subsystems (2)
PATCH 1/1 ARM: imx35: add iim module to imx35.dtsi
This is a prerequisite to remove the static mappings for imx35 devicetree based machines.
--- arch/arm/boot/dts/imx35.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)
arch/arm/boot/dts/imx35.dtsi +7 -0
@@ -309,6 +309,13 @@ status = "disabled"; }; + iim at 53ff0000 { + compatible = "fsl,imx35-iim"; + reg = <0x53ff0000 0x4000>; + interrupts = <19>; + clocks = <&clks 80>; + }; + usbotg: usb at 53ff4000 { compatible = "fsl,imx35-usb", "fsl,imx27-usb"; reg = <0x53ff4000 0x0200>;
Signature · 1 line
2.8.1
Fabio Estevam
reviewerPATCH 1/1 ARM: imx35: add iim module to imx35.dtsi
Hi Uwe,
Quoted 13 lines · Uwe Kleine-K?nig
This is a prerequisite to remove the static mappings for imx35 devicetree based machines.
Signed-off-by Uwe Kleine-K?nig <[email protected]>--- arch/arm/boot/dts/imx35.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm/boot/dts/imx35.dtsi +0
-0
arch/arm/boot/dts/imx35.dtsi line 313
Quoted 5 lines
arch/arm/boot/dts/imx35.dtsi +2
-0@@ -309,6 +309,13 @@ status = "disabled"; }; + iim at 53ff0000 { + compatible = "fsl,imx35-iim";
Where is "fsl,imx35-iim" defined?
PATCH 1/1 ARM: imx35: add iim module to imx35.dtsi
Quoted 20 lines · Fabio Estevam
Hi Uwe,
Quoted 16 lines · Uwe Kleine-K?nig
This is a prerequisite to remove the static mappings for imx35 devicetree based machines.
Signed-off-by Uwe Kleine-K?nig <[email protected]>--- arch/arm/boot/dts/imx35.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)arch/arm/boot/dts/imx35.dtsi +0
-0@@ -309,6 +309,13 @@ status = "disabled"; };
Quoted 4 lines
arch/arm/boot/dts/imx35.dtsi line 313
Quoted 2 lines
arch/arm/boot/dts/imx35.dtsi +2
-0+ iim at 53ff0000 { + compatible = "fsl,imx35-iim";Where is "fsl,imx35-iim" defined?
right next to the other fsl,imx*-iim :-)
By the way, compared to the other imx*.dtsi I didn't declare compatibility to fsl,imx27-iim. I checked the i.MX25 reference manual and the i.MX35 looked different. Didn't check for imx5x and the i.MX27 RM doesn't describe the registers. What do you think?
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
Fabio Estevam
reviewerPATCH 1/1 ARM: imx35: add iim module to imx35.dtsi
Quoted 3 lines · Uwe Kleine-K?nig
Quoted 1 line
Where is "fsl,imx35-iim" defined?
right next to the other fsl,imx*-iim :-)
Ok, "fsl,imx35-iim" is not being used arch/arm/mach-imx/cpu-imx35.c currently.
I suppose you want to replace
"rev = imx_readl(MX35_IO_ADDRESS(MX35_IIM_BASE_ADDR + MXC_IIMSREV));"
by retrieving the base address via dt, like we do in imx5_read_srev_reg() at arch/arm/mach-imx/cpu-imx5.c.
Quoted 4 lines
By the way, compared to the other imx*.dtsi I didn't declare compatibility to fsl,imx27-iim. I checked the i.MX25 reference manual and the i.MX35 looked different. Didn't check for imx5x and the i.MX27 RM doesn't describe the registers. What do you think?
I think this is fine as is, so:
PATCH 1/1 ARM: imx35: add iim module to imx35.dtsi
Hello Fabio,
Quoted 7 lines · Fabio Estevam
Quoted 3 lines · Uwe Kleine-K?nig
Quoted 1 line
Where is "fsl,imx35-iim" defined?
right next to the other fsl,imx*-iim :-)
Quoted 7 lines
Ok, "fsl,imx35-iim" is not being used
arch/arm/mach-imx/cpu-imx35.ccurrently.I suppose you want to replace
"rev =imx_readl(MX35_IO_ADDRESS(MX35_IIM_BASE_ADDR + MXC_IIMSREV));"by retrieving the base address via dt, like we do in
imx5_read_srev_reg()atarch/arm/mach-imx/cpu-imx5.c.
Yes, that's the plan, imx5_read_srev_reg could even be used for this, so I intend to rename it and move it to a place where it is compiled for i.MX[23]5.
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
Shawn Guo
AppliedPATCH 1/1 ARM: imx35: add iim module to imx35.dtsi
In reply to Uwe Kleine-KönigQuoted 4 lines · Uwe Kleine-K?nig
This is a prerequisite to remove the static mappings for imx35 devicetree based machines.
Signed-off-by Uwe Kleine-K?nig <[email protected]>
Applied, thanks.