Skip to contentSkip to conversation

ARM: clk-imx35: fix name for ckil clk

PATCH New Uwe Kleine-König 3 participants 9 messages Sep 8, 2016 – Sep 14, 2016

Subsystems (3)
Arm i.MX and Layerscape Common clk NXP i.MX clock drivers
lore
Share & tools
lore

Uwe Kleine-König

author
#0 lore raw

PATCH 1/2 ARM: clk-imx35: fix name for ckil clk

This fixes

	[    0.000000] i.MX clk 82: register failed with -17

because the name is duplicated.

Signed-off-by Uwe Kleine-K?nig <[email protected]>
---
 drivers/clk/imx/clk-imx35.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/imx/clk-imx35.c +1 -1
index b0978d3b83e2..d302ed3b8225 100644
@@ -115,7 +115,7 @@ static void __init _mx35_clocks_init(void)
 	}
 
 	clk[ckih] = imx_clk_fixed("ckih", 24000000);
-	clk[ckil] = imx_clk_fixed("ckih", 32768);
+	clk[ckil] = imx_clk_fixed("ckil", 32768);
 	clk[mpll] = imx_clk_pllv1(IMX_PLLV1_IMX35, "mpll", "ckih", base + MX35_CCM_MPCTL);
 	clk[ppll] = imx_clk_pllv1(IMX_PLLV1_IMX35, "ppll", "ckih", base + MX35_CCM_PPCTL);
Signature · 1 line
2.8.1
author
#1 lore raw

PATCH 2/2 ARM: clk-imx35: annotate clk enum with number values

This helps to decode error messages like:

	[    0.000000] i.MX clk 82: register failed with -17
Signed-off-by Uwe Kleine-K?nig <[email protected]>

---

Hello,

maybe it's also sensible to do:

	enum mx35_clks {
		ckih = 0,
		mpll = 1,
		...

?

Best regards
Uwe

 drivers/clk/imx/clk-imx35.c | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)
drivers/clk/imx/clk-imx35.c +16 -14
index d302ed3b8225..203cad6c9aab 100644
@@ -66,20 +66,22 @@ static const char *std_sel[] = {"ppll", "arm"};
 static const char *ipg_per_sel[] = {"ahb_per_div", "arm_per_div"};
 
 enum mx35_clks {
-	ckih, mpll, ppll, mpll_075, arm, hsp, hsp_div, hsp_sel, ahb, ipg,
-	arm_per_div, ahb_per_div, ipg_per, uart_sel, uart_div, esdhc_sel,
-	esdhc1_div, esdhc2_div, esdhc3_div, spdif_sel, spdif_div_pre,
-	spdif_div_post, ssi_sel, ssi1_div_pre, ssi1_div_post, ssi2_div_pre,
-	ssi2_div_post, usb_sel, usb_div, nfc_div, asrc_gate, pata_gate,
-	audmux_gate, can1_gate, can2_gate, cspi1_gate, cspi2_gate, ect_gate,
-	edio_gate, emi_gate, epit1_gate, epit2_gate, esai_gate, esdhc1_gate,
-	esdhc2_gate, esdhc3_gate, fec_gate, gpio1_gate, gpio2_gate, gpio3_gate,
-	gpt_gate, i2c1_gate, i2c2_gate, i2c3_gate, iomuxc_gate, ipu_gate,
-	kpp_gate, mlb_gate, mshc_gate, owire_gate, pwm_gate, rngc_gate,
-	rtc_gate, rtic_gate, scc_gate, sdma_gate, spba_gate, spdif_gate,
-	ssi1_gate, ssi2_gate, uart1_gate, uart2_gate, uart3_gate, usbotg_gate,
-	wdog_gate, max_gate, admux_gate, csi_gate, csi_div, csi_sel, iim_gate,
-	gpu2d_gate, ckil, clk_max
+	/*  0 */ ckih, mpll, ppll, mpll_075, arm, hsp, hsp_div, hsp_sel, ahb,
+	/*  9 */ ipg, arm_per_div, ahb_per_div, ipg_per, uart_sel, uart_div,
+	/* 15 */ esdhc_sel, esdhc1_div, esdhc2_div, esdhc3_div, spdif_sel,
+	/* 20 */ spdif_div_pre, spdif_div_post, ssi_sel, ssi1_div_pre,
+	/* 24 */ ssi1_div_post, ssi2_div_pre, ssi2_div_post, usb_sel, usb_div,
+	/* 29 */ nfc_div, asrc_gate, pata_gate, audmux_gate, can1_gate,
+	/* 34 */ can2_gate, cspi1_gate, cspi2_gate, ect_gate, edio_gate,
+	/* 39 */ emi_gate, epit1_gate, epit2_gate, esai_gate, esdhc1_gate,
+	/* 44 */ esdhc2_gate, esdhc3_gate, fec_gate, gpio1_gate, gpio2_gate,
+	/* 49 */ gpio3_gate, gpt_gate, i2c1_gate, i2c2_gate, i2c3_gate,
+	/* 54 */ iomuxc_gate, ipu_gate, kpp_gate, mlb_gate, mshc_gate,
+	/* 59 */ owire_gate, pwm_gate, rngc_gate, rtc_gate, rtic_gate, scc_gate,
+	/* 65 */ sdma_gate, spba_gate, spdif_gate, ssi1_gate, ssi2_gate,
+	/* 70 */ uart1_gate, uart2_gate, uart3_gate, usbotg_gate, wdog_gate,
+	/* 75 */ max_gate, admux_gate, csi_gate, csi_div, csi_sel, iim_gate,
+	/* 81 */ gpu2d_gate, ckil, clk_max
 };
 
 static struct clk *clk[clk_max];
Signature · 1 line
2.8.1
Applied
#2 lore raw

PATCH 2/2 ARM: clk-imx35: annotate clk enum with number values

Quoted 6 lines · Uwe Kleine-K?nig

This helps to decode error messages like:

	[    0.000000] i.MX clk 82: register failed with -17
Signed-off-by Uwe Kleine-K?nig <[email protected]>

---

Applied to clk-next

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
#3 lore raw

PATCH 1/2 ARM: clk-imx35: fix name for ckil clk

In reply to Uwe Kleine-König
Quoted 5 lines · Uwe Kleine-K?nig

This fixes

	[    0.000000] i.MX clk 82: register failed with -17

because the name is duplicated.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

I did not queue any clock patches for this cycle. Can you please send the patches directly to clock maintainers?

Shawn

Quoted 25 lines
---
 drivers/clk/imx/clk-imx35.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/imx/clk-imx35.c +1 -1
index b0978d3b83e2..d302ed3b8225 100644
@@ -115,7 +115,7 @@ static void __init _mx35_clocks_init(void)
 	}
 
 	clk[ckih] = imx_clk_fixed("ckih", 24000000);
-	clk[ckil] = imx_clk_fixed("ckih", 32768);
+	clk[ckil] = imx_clk_fixed("ckil", 32768);
 	clk[mpll] = imx_clk_pllv1(IMX_PLLV1_IMX35, "mpll", "ckih", base + MX35_CCM_MPCTL);
 	clk[ppll] = imx_clk_pllv1(IMX_PLLV1_IMX35, "ppll", "ckih", base + MX35_CCM_PPCTL);
Signature · 7 lines
2.8.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author
#4 lore raw

PATCH 1/2 ARM: clk-imx35: fix name for ckil clk

To += mturquette, sboyd

Hello Shawn, hello Michael, hello Stephen,

Quoted 9 lines · Shawn Guo
Quoted 5 lines · Uwe Kleine-K?nig

This fixes

	[    0.000000] i.MX clk 82: register failed with -17

because the name is duplicated.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

I did not queue any clock patches for this cycle. Can you please send the patches directly to clock maintainers?

@shawnguo: Is this an ack?
@mturquette, sboyd: should I resend? IMHO the first patch should go in soon.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#5 lore raw

PATCH 1/2 ARM: clk-imx35: fix name for ckil clk

Quoted 10 lines · Uwe Kleine-K?nig

To += mturquette, sboyd

Hello Shawn, hello Michael, hello Stephen,

Quoted 5 lines · Shawn Guo
Quoted 4 lines · Uwe Kleine-K?nig

This fixes

	[    0.000000] i.MX clk 82: register failed with -17

because the name is duplicated.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Uwe Kleine-K?nig <[email protected]>

I did not queue any clock patches for this cycle. Can you please send the patches directly to clock maintainers?

@shawnguo: Is this an ack?

Yes,

Acked-by Shawn Guo <[email protected]>
Quoted 14 lines

@mturquette, sboyd: should I resend? IMHO the first patch should go in soon.

Best regards
Uwe

Signature · 7 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#6 lore raw

PATCH 1/2 ARM: clk-imx35: fix name for ckil clk

In reply to Uwe Kleine-König
Quoted 10 lines · Uwe Kleine-K?nig

To += mturquette, sboyd

Hello Shawn, hello Michael, hello Stephen,

Quoted 5 lines · Shawn Guo
Quoted 4 lines · Uwe Kleine-K?nig

This fixes

	[    0.000000] i.MX clk 82: register failed with -17

because the name is duplicated.

Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Signed-off-by Uwe Kleine-K?nig <[email protected]>

I did not queue any clock patches for this cycle. Can you please send the patches directly to clock maintainers?

@shawnguo: Is this an ack?
@mturquette, sboyd: should I resend? IMHO the first patch should go in soon.

Does the first patch need a fixes tag? We can apply them directly.

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
author
#7 lore raw

PATCH 1/2 ARM: clk-imx35: fix name for ckil clk

Quoted 16 lines · Stephen Boyd
Quoted 15 lines · Uwe Kleine-K?nig

To += mturquette, sboyd

Hello Shawn, hello Michael, hello Stephen,

Quoted 9 lines · Shawn Guo
Quoted 5 lines · Uwe Kleine-K?nig

This fixes

	[    0.000000] i.MX clk 82: register failed with -17

because the name is duplicated.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

I did not queue any clock patches for this cycle. Can you please send the patches directly to clock maintainers?

Quoted 6 lines
Quoted 3 lines

@shawnguo: Is this an ack?
@mturquette, sboyd: should I resend? IMHO the first patch should go in soon.

Does the first patch need a fixes tag? We can apply them directly.

The breakage was introduced by v4.3-rc2~4^2~71^2, i.e. 3713e3f5e927 (clk: imx35: define two clocks for rtc).

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Applied
#8 lore raw

PATCH 1/2 ARM: clk-imx35: fix name for ckil clk

In reply to Uwe Kleine-König
Quoted 6 lines · Uwe Kleine-K?nig

This fixes

	[    0.000000] i.MX clk 82: register failed with -17

because the name is duplicated.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

---

Applied to clk-next

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project