Skip to contentSkip to conversation

binutils: fix makeinfo related issue

PATCH New Thomas Petazzoni 2 participants 4 messages Sep 8, 2016 – Sep 11, 2016

lore
Share & tools
lore

Thomas Petazzoni

author
#0 lore raw

PATCH 1/1 binutils: fix makeinfo related issue

The latest version of binutils, 2.27, added in commit b700157db40410907d6a07582eacbb5030fd919e, fails to build on systems that don't have makeinfo installed. This commit therefore applies the same fixup as the one used for binutils 2.26, which consists in touching all the .info files, so that they don't get rebuilt.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/binutils/binutils.mk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
package/binutils/binutils.mk +4 -4
index 71ea2b0..ad3a0d8 100644
@@ -33,10 +33,10 @@ BINUTILS_DEPENDENCIES += host-flex host-bison host-texinfo
 HOST_BINUTILS_DEPENDENCIES += host-flex host-bison host-texinfo
 endif
 
-# The .info files in the 2.26 tarball have an incorrect timestamp, so
-# binutils tries to re-generate them. In order to avoid the dependency
-# on host-texinfo, we simply update the timestamps.
-ifeq ($(BR2_BINUTILS_VERSION_2_26_X),y)
+# The .info files in the >= 2.26 tarball have an incorrect timestamp,
+# so binutils tries to re-generate them. In order to avoid the
+# dependency on host-texinfo, we simply update the timestamps.
+ifeq ($(BR2_BINUTILS_VERSION_2_26_X)$(BR2_BINUTILS_VERSION_2_27_X),y)
 define BINUTILS_FIXUP_INFO_TIMESTAMPS
 	find $(@D) -name '*.info' -exec touch {} \;
 endef
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 binutils: fix makeinfo related issue

Hi Thomas,

Le 08/09/2016 ? 21:49, Thomas Petazzoni a ?crit :

Quoted 17 lines

The latest version of binutils, 2.27, added in commit b700157db40410907d6a07582eacbb5030fd919e, fails to build on systems that don't have makeinfo installed. This commit therefore applies the same fixup as the one used for binutils 2.26, which consists in touching all the .info files, so that they don't get rebuilt.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/binutils/binutils.mk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
package/binutils/binutils.mk +0 -0
index 71ea2b0..ad3a0d8 100644
@@ -33,10 +33,10 @@ BINUTILS_DEPENDENCIES += host-flex host-bison host-texinfo
 HOST_BINUTILS_DEPENDENCIES += host-flex host-bison host-texinfo

package/binutils/binutils.mk BINUTILS_DEPENDENCIES += host-flex host-bison host-texinfo · line 39

Quoted 10 lines
package/binutils/binutils.mk +4 -4
 endif
 
-# The .info files in the 2.26 tarball have an incorrect timestamp, so
-# binutils tries to re-generate them. In order to avoid the dependency
-# on host-texinfo, we simply update the timestamps.
-ifeq ($(BR2_BINUTILS_VERSION_2_26_X),y)
+# The .info files in the >= 2.26 tarball have an incorrect timestamp,
+# so binutils tries to re-generate them. In order to avoid the
+# dependency on host-texinfo, we simply update the timestamps.
+ifeq ($(BR2_BINUTILS_VERSION_2_26_X)$(BR2_BINUTILS_VERSION_2_27_X),y)

Binutils 2.28 will likely have the same issue, why not inverse the condition ? ifneq ($(BR2_BINUTILS_VERSION_2_24_X)$(BR2_BINUTILS_VERSION_2_25_X),)

Best regards,
Romain

Quoted 4 lines
package/binutils/binutils.mk +0 -0
 define BINUTILS_FIXUP_INFO_TIMESTAMPS
 	find $(@D) -name '*.info' -exec touch {} \;
 endef
author
#2 lore raw

PATCH 1/1 binutils: fix makeinfo related issue

Hello,

Quoted 11 lines · Romain Naour

package/binutils/binutils.mk BINUTILS_DEPENDENCIES += host-flex host-bison host-texinfo · line 39

Quoted 8 lines
package/binutils/binutils.mk +4 -4
-# The .info files in the 2.26 tarball have an incorrect timestamp, so
-# binutils tries to re-generate them. In order to avoid the dependency
-# on host-texinfo, we simply update the timestamps.
-ifeq ($(BR2_BINUTILS_VERSION_2_26_X),y)
+# The .info files in the >= 2.26 tarball have an incorrect timestamp,
+# so binutils tries to re-generate them. In order to avoid the
+# dependency on host-texinfo, we simply update the timestamps.
+ifeq ($(BR2_BINUTILS_VERSION_2_26_X)$(BR2_BINUTILS_VERSION_2_27_X),y)

Binutils 2.28 will likely have the same issue, why not inverse the condition ? ifneq ($(BR2_BINUTILS_VERSION_2_24_X)$(BR2_BINUTILS_VERSION_2_25_X),)

Right, but maybe I could dream that someone will report the bug to the binutils maintainers, and that the problem will be fixed in binutils 2.28 ? :-)

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
author Applied
#3 lore raw

PATCH 1/1 binutils: fix makeinfo related issue

In reply to Thomas Petazzoni

Hello,

Quoted 10 lines · Thomas Petazzoni

The latest version of binutils, 2.27, added in commit b700157db40410907d6a07582eacbb5030fd919e, fails to build on systems that don't have makeinfo installed. This commit therefore applies the same fixup as the one used for binutils 2.26, which consists in touching all the .info files, so that they don't get rebuilt.

Signed-off-by Thomas Petazzoni <[email protected]>
---
 package/binutils/binutils.mk | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com