samba: fix waf-samba and restrict the blacklist to ARM
v2 cover samba: fix waf-samba and restrict the blacklist to ARM
From: Jackie Huang <[email protected]>
--
The following changes since commit 80b2d4de0ee2a5e6a3302a527e3fcfd2b99c3e37:
samba: blacklist, fails to build with new binutils-2.27 (2016-09-05 13:34:13 -0400)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib.git jhuang0/d_samba_160909_0
http://git.pokylinux.org/cgit.cgi//log/?h=jhuang0/d_samba_160909_0
Jackie Huang (2):
waf-samba.bbclass: Add PACKAGECONFIG_CONFARGS to CONFIGUREOPTS
samba: restrict the blacklist to ARM only
meta-networking/classes/waf-samba.bbclass | 1 + meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-)
Signature · 1 line
2.8.3
PATCH v2 1/2 waf-samba.bbclass: Add PACKAGECONFIG_CONFARGS to CONFIGUREOPTS
From: Jackie Huang <[email protected]>
Add PACKAGECONFIG_CONFARGS to CONFIGUREOPTS for waf-samba.bbclass because the PACKAGECONFIG will not be handled for all recipes after the following commit in oe-core:
commit c98fb5f5129e71829ffab4449b3d28082bc95ab4
Author: Martin Jansa <[email protected]> Date: Tue Aug 30 16:19:58 2016 +0200
base, autotools: Append PACKAGECONFIG_CONFARGS to EXTRA_OECONF only in autotools.bbclass
* recipes which don't inherit autotools or cmake bbclass and want to use the configure options from PACKAGECONFIG need to handle PACKAGECONFIG_CONFARGS themselves.
--- meta-networking/classes/waf-samba.bbclass | 1 + 1 file changed, 1 insertion(+)
meta-networking/classes/waf-samba.bbclass +1 -0
@@ -18,6 +18,7 @@ CONFIGUREOPTS = " --prefix=${prefix} \ --oldincludedir=${oldincludedir} \ --infodir=${infodir} \ --mandir=${mandir} \ + ${PACKAGECONFIG_CONFARGS} \ " # Three methods for waf cross compile:
Signature · 1 line
2.8.3
PATCH v2 2/2 samba: restrict the blacklist to ARM only
In reply to [email protected]From: Jackie Huang <[email protected]>
It builds fine except for arm now, and the do_package and libpam issue is fixed by:
"waf-samba.bbclass: Add PACKAGECONFIG_CONFARGS to CONFIGUREOPTS"
--- meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
meta-networking/recipes-connectivity/samba/samba_4.4.5.bb +3 -3
@@ -319,6 +319,6 @@ RDEPENDS_${PN}-pidl_append = " perl" FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse" # http://errors.yoctoproject.org/Errors/Details/81004/ -# before this issue it was also failing in do_package and -# autodetecting libpam dependency -PNBLACKLIST[samba] ?= "BROKEN: fails to build with new binutils-2.27" +BLACKLIST_REASON ?= "" +BLACKLIST_REASON_arm = "BROKEN: fails to build with new binutils-2.27" +PNBLACKLIST[samba] ?= "${BLACKLIST_REASON}"
Signature · 1 line
2.8.3
Re: [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only
Quoted 5 lines · [[oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM…
From: Jackie Huang <[email protected]>
It builds fine except for arm now, and the
do_packageand libpam issue is fixed by:
"waf-samba.bbclass: AddPACKAGECONFIG_CONFARGSto CONFIGUREOPTS"
Did you confirm that you're still seeing the failure for arm?
-J.
Quoted 23 lines
Signed-off-by Jackie Huang <[email protected]>--- meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)meta-networking/recipes-connectivity/samba/samba_4.4.5.bb +3
-3@@ -319,6 +319,6 @@ RDEPENDS_${PN}-pidl_append = " perl" FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse" # http://errors.yoctoproject.org/Errors/Details/81004/ -# before this issue it was also failing in do_package and -# autodetecting libpam dependency -PNBLACKLIST[samba] ?= "BROKEN: fails to build with new binutils-2.27" +BLACKLIST_REASON ?= "" +BLACKLIST_REASON_arm = "BROKEN: fails to build with new binutils-2.27" +PNBLACKLIST[samba] ?= "${BLACKLIST_REASON}"Signature · 1 line
2.8.3
Signature · 2 lines
-Joe MacDonald. :wq
Re: [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only
Quoted 25 lines · Joe MacDonald
Quoted 5 lines · [[oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM…
From: Jackie Huang <[email protected]>
It builds fine except for arm now, and the
do_packageand libpam issue is fixed by:
"waf-samba.bbclass: AddPACKAGECONFIG_CONFARGSto CONFIGUREOPTS"Did you confirm that you're still seeing the failure for arm?
-J.
Quoted 13 lines
Signed-off-by Jackie Huang <[email protected]>--- meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)meta-networking/recipes-connectivity/samba/samba_4.4.5.bb +0
-0@@ -319,6 +319,6 @@ RDEPENDS_${PN}-pidl_append = " perl" FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse"
Quoted 14 lines
Quoted 10 lines
meta-networking/recipes-connectivity/samba/samba_4.4.5.bb +3
-4# http://errors.yoctoproject.org/Errors/Details/81004/ -# before this issue it was also failing in do_package and -# autodetecting libpam dependency -PNBLACKLIST[samba] ?= "BROKEN: fails to build with new binutils-2.27" +BLACKLIST_REASON ?= "" +BLACKLIST_REASON_arm = "BROKEN: fails to build with new binutils-2.27" +PNBLACKLIST[samba] ?= "${BLACKLIST_REASON}" --2.8.3
--
-Joe MacDonald.
:wq
Did you see [1] - it fixes build for arm.
[1] http://lists.openembedded.org/pipermail/openembedded-devel/2016-September/108972.html
Andreas
Re: [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only
Quoted 40 lines · [Re: [oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM…
Quoted 25 lines · Joe MacDonald
Quoted 5 lines · [[oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM…
From: Jackie Huang <[email protected]>
It builds fine except for arm now, and the
do_packageand libpam issue is fixed by:
"waf-samba.bbclass: AddPACKAGECONFIG_CONFARGSto CONFIGUREOPTS"Did you confirm that you're still seeing the failure for arm?
-J.
Quoted 13 lines
Signed-off-by Jackie Huang <[email protected]>--- meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)meta-networking/recipes-connectivity/samba/samba_4.4.5.bb +0
-0@@ -319,6 +319,6 @@ RDEPENDS_${PN}-pidl_append = " perl" FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse"Quoted 14 lines
Quoted 10 lines
meta-networking/recipes-connectivity/samba/samba_4.4.5.bb +3
-4# http://errors.yoctoproject.org/Errors/Details/81004/ -# before this issue it was also failing in do_package and -# autodetecting libpam dependency -PNBLACKLIST[samba] ?= "BROKEN: fails to build with new binutils-2.27" +BLACKLIST_REASON ?= "" +BLACKLIST_REASON_arm = "BROKEN: fails to build with new binutils-2.27" +PNBLACKLIST[samba] ?= "${BLACKLIST_REASON}" --2.8.3
--
-Joe MacDonald.
:wq
Quoted 3 lines
Did you see [1] - it fixes build for arm.
[1] http://lists.openembedded.org/pipermail/openembedded-devel/2016-September/108972.html
I didn't, actually, but I had picked it up in my tree anyway when I scooped up the latest set of changes in master-next. The reason I was asking was because I wasn't seeing a failure anymore in samba on arm and was curious why Jackie was still seeing it if I wasn't and I hadn't seen an explicit patch to resolve the issue. But there it is, mystery solved. Thanks for the heads-up, Andreas.
Signature · 2 lines
-Joe MacDonald. :wq
Re: [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only
Quoted 56 lines
-----Original Message-----
From: [email protected] [mailto:openembedded-devel- [email protected]] On Behalf Of Joe MacDonald
Sent: Saturday, September 10, 2016 8:35 AM
To: [email protected]
Subject: Re: [oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only[Re: [oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only] On 16.09.10 (Sat
Quoted 2 lines · 00:03) Andreas Müller wrote:
Quoted 1 line · Joe MacDonald
[[oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only] On 16.09.09 (Fri
Quoted 12 lines · 10:34) [email protected] wrote:
Quoted 12 lines
Quoted 6 lines
From: Jackie Huang <[email protected]>
It builds fine except for arm now, and the
do_packageand libpam issue is fixed by:
"waf-samba.bbclass: AddPACKAGECONFIG_CONFARGSto CONFIGUREOPTS"Did you confirm that you're still seeing the failure for arm?
-J.
Quoted 1 line
Quoted 6 lines
Quoted 6 lines
meta-
Quoted 6 lines
Signed-off-by Jackie Huang <[email protected]>--- meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)meta- renamed from meta-networking/recipes-connectivity/samba/samba_4.4.5.bb +0
-0networking/recipes-connectivity/samba/samba_4.4.5.bb
Quoted 22 lines
Quoted 6 lines
Quoted 6 lines
index 042203e..c34adcb 100644
meta-networking/recipes-connectivity/samba/samba_4.4.5.bb +0
-0@@ -319,6 +319,6 @@ RDEPENDS_${PN}-pidl_append = " perl" FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse"Quoted 14 lines
Quoted 10 lines
meta-networking/recipes-connectivity/samba/samba_4.4.5.bb +3
-4# http://errors.yoctoproject.org/Errors/Details/81004/ -# before this issue it was also failing in do_package and -# autodetecting libpam dependency -PNBLACKLIST[samba] ?= "BROKEN: fails to build with new binutils-2.27" +BLACKLIST_REASON ?= "" +BLACKLIST_REASON_arm = "BROKEN: fails to build with new binutils-2.27" +PNBLACKLIST[samba] ?= "${BLACKLIST_REASON}" --2.8.3
--
-Joe MacDonald.
:wqDid you see [1] - it fixes build for arm.
Quoted 7 lines
Quoted 1 line
[1] http://lists.openembedded.org/pipermail/openembedded-devel/2016-
September/108972.html
I didn't, actually, but I had picked it up in my tree anyway when I scooped up the latest set of changes in master-next. The reason I was asking was because I wasn't seeing a failure anymore in samba on arm and was curious why Jackie was still seeing it if I wasn't and I hadn't seen
Actually I never see the failure in:
http://errors.yoctoproject.org/Errors/Details/81004/
and I didn't notice Andreas' patch, I was fixing another issue but Mark asked me to include the restrict on ARM, please see:
https://patchwork.openembedded.org/patch/131249/
so I thought at least Mark was still seeing this and sent this patch.
Mark, could you confirm that you're still seeing the failure for arm?
Thanks,
Jackie
Quoted 6 lines
an explicit patch to resolve the issue. But there it is, mystery solved. Thanks for the heads-up, Andreas.
--
-Joe MacDonald.
:wq
Re: [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only
Quoted 13 lines · Jie (Jackie)
Quoted 13 lines
-----Original Message-----
From: [email protected] [mailto:openembedded-devel- [email protected]] On Behalf Of Joe MacDonald
Sent: Saturday, September 10, 2016 8:35 AM
To: [email protected]
Subject: Re: [oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only[Re: [oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only] On 16.09.10 (Sat>
Quoted 1 line · 00:03) Andreas Müller wrote:
On Fri, Sep 9, 2016 at 10:44 PM, Joe MacDonald
Quoted 61 lines · <[email protected]> wrote:
Quoted 50 lines
Quoted 2 lines
Quoted 2 lines
[[oe] [meta-networking][PATCH 2/2 v2] samba: restrict the blacklist to ARM only] On 16.09.09 (Fri>
Quoted 10 lines · 10:34) [email protected] wrote:
Quoted 10 lines
Quoted 5 lines
From: Jackie Huang <[email protected]>
It builds fine except for arm now, and the
do_packageand libpam issue is fixed by:
"waf-samba.bbclass: AddPACKAGECONFIG_CONFARGSto CONFIGUREOPTS"Did you confirm that you're still seeing the failure for arm?
-J.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Signed-off-by Jackie Huang <[email protected]>---
meta-networking/recipes-connectivity/samba/samba_4.4.5.bb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/meta-networking/recipes-connectivity/samba/samba_4.4.5.bb b/meta->
networking/recipes-connectivity/samba/samba_4.4.5.bb
Quoted 27 lines
Quoted 23 lines
Quoted 15 lines
index 042203e..c34adcb 100644
meta-networking/recipes-connectivity/samba/samba_4.4.5.bb +0
-3@@ -319,6 +319,6 @@ RDEPENDS_${PN}-pidl_append = " perl" FILES_${PN}-pidl = "${bindir}/pidl ${datadir}/perl5/Parse" # http://errors.yoctoproject.org/Errors/Details/81004/ -# before this issue it was also failing in do_package and -# autodetecting libpam dependency -PNBLACKLIST[samba] ?= "BROKEN: fails to build with newbinutils-2.27"
meta-networking/recipes-connectivity/samba/samba_4.4.5.bb +2
-0+BLACKLIST_REASON ?= "" +BLACKLIST_REASON_arm = "BROKEN: fails to build with newQuoted 4 lines
binutils-2.27"
+PNBLACKLIST[samba] ?= "${BLACKLIST_REASON}"
--
2.8.3--
-Joe MacDonald.Quoted 1 line
:wq
Did you see [1] - it fixes build for arm.
Quoted 7 lines
Quoted 1 line
[1] http://lists.openembedded.org/pipermail/openembedded-devel/2016-> >
September/108972.html
I didn't, actually, but I had picked it up in my tree anyway when I scooped up the latest set of changes in master-next. The reason I was asking was because I wasn't seeing a failure anymore in samba on arm and was curious why Jackie was still seeing it if I wasn't and I hadn't seen
Actually I never see the failure in:
http://errors.yoctoproject.org/Errors/Details/81004/
Quoted 8 lines
and I didn't notice Andreas' patch, I was fixing another issue but Mark asked me to include the restrict on ARM, please see:
https://patchwork.openembedded.org/patch/131249/
so I thought at least Mark was still seeing this and sent this patch.
Mark, could you confirm that you're still seeing the failure for arm?
I was never able to reproduce the issue but was working on the assumption that it was still a real issue, and thus the need to continue to blacklist ARM. if the issue no longer exists then the proper thing to do would be to remove the blacklist entry and in the commit log which does this, identify what changed to remedy the situation.
Mark
Quoted 11 lines
Thanks,
JackieQuoted 7 lines
an explicit patch to resolve the issue. But there it is, mystery solved. Thanks for the heads-up, Andreas.
--
-Joe MacDonald.:wq