ARM: dts: Add power button support for igepv5

PATCH New Tony Lindgren 4 participants 6 messages Sep 9, 2016 – Sep 20, 2016 Device tree bindings

lore

Share & tools

lore

Tony Lindgren

author

2016-09-09 21:07 UTC #0 lore raw

PATCH 1/1 ARM: dts: Add power button support for igepv5

Add power button support for igepv5.

Cc Agust? Fontquerni i Gorchs <[email protected]>

Cc Enric Balletbo Serra <[email protected]>

Cc Javier Martinez Canillas <[email protected]>

Cc Pau Pajuel <[email protected]>

Signed-off-by Tony Lindgren <[email protected]>

---
 arch/arm/boot/dts/omap5-igep0050.dts | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

arch/arm/boot/dts/omap5-igep0050.dts +19 -0

@@ -7,6 +7,7 @@
  */
 /dts-v1/;
 
+#include <dt-bindings/input/input.h>
 #include "omap5-board-common.dtsi"
 
 / {

@@ -17,6 +18,18 @@
 		device_type = "memory";
 		reg = <0x80000000 0x7f000000>; /* 2032 MB */
 	};
+
+	gpio_keys {
+                compatible = "gpio-keys";
+		pinctrl-0 = <&power_button_pin>;
+		pinctrl-names = "default";
+
+		power-button {
+			label = "Power Button";
+			linux,code = <KEY_POWER>;
+			gpios = <&gpio4 22 GPIO_ACTIVE_HIGH>;
+		};
+	};
 };
 
 &hdmi {

@@ -58,6 +71,12 @@
 			OMAP5_IOPAD(0x0fa, PIN_INPUT | MUX_MODE0)	/* i2c4_sda */
 		>;
 	};
+
+	power_button_pin: pinctrl_power_button_pin {
+		pinctrl-single,pins = <
+			OMAP5_IOPAD(0x086, PIN_INPUT | MUX_MODE6)	/* gpio4_118 */
+		>;
+	};
 };
 
 &tpd12s015 {

Signature · 1 line

2.9.3

Javier Martinez Canillas

2016-09-14 01:26 UTC #1 lore raw

PATCH 1/1 ARM: dts: Add power button support for igepv5

Hello Tony,

Quoted 8 lines · Tony Lindgren

Add power button support for igepv5.
Cc Agust? Fontquerni i Gorchs <[email protected]>
Cc Enric Balletbo Serra <[email protected]>
Cc Javier Martinez Canillas <[email protected]>
Cc Pau Pajuel <[email protected]>
Signed-off-by Tony Lindgren <[email protected]>
---

I don't have a schematics for this board, but the patch looks good to me.

Reviewed-by Javier Martinez Canillas <[email protected]>

Best regards,

Signature · 3 lines

Javier Martinez Canillas
Open Source Group
Samsung Research America

Pau Pajuel

2016-09-19 08:13 UTC #2 lore raw

PATCH 1/1 ARM: dts: Add power button support for igepv5

Hello Tony,

2016-09-14 3:26 GMT+02:00 Javier Martinez Canillas <[email protected]>:

Quoted 5 lines

Hello Tony,
Quoted 2 lines · Tony Lindgren
Add power button support for igepv5.

Quoted 8 lines

Quoted 6 lines
Cc Agust? Fontquerni i Gorchs <[email protected]>
Cc Enric Balletbo Serra <[email protected]>
Cc Javier Martinez Canillas <[email protected]>
Cc Pau Pajuel <[email protected]>
Signed-off-by Tony Lindgren <[email protected]>
---
I don't have a schematics for this board, but the patch looks good to me.

Patch has an errata. Power button is GPIO_ACTIVE_LOW instead GPIO_ACTIVE_HIGH.

Quoted 8 lines

Reviewed-by Javier Martinez Canillas <[email protected]>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America

Best regards

Tony Lindgren

author

2016-09-19 23:08 UTC #3 lore raw

PATCH 1/1 ARM: dts: Add power button support for igepv5

Quoted 15 lines · Pau Pajuel

Hello Tony,
2016-09-14 3:26 GMT+02:00 Javier Martinez Canillas <[email protected]>:
Quoted 12 lines
Hello Tony,
Quoted 8 lines · Tony Lindgren
Add power button support for igepv5.
Cc Agust? Fontquerni i Gorchs <[email protected]>
Cc Enric Balletbo Serra <[email protected]>
Cc Javier Martinez Canillas <[email protected]>
Cc Pau Pajuel <[email protected]>
Signed-off-by Tony Lindgren <[email protected]>
---

Quoted 2 lines

Quoted 1 line
I don't have a schematics for this board, but the patch looks good to me.
Patch has an errata. Power button is GPIO_ACTIVE_LOW instead GPIO_ACTIVE_HIGH.

Oops sorry about that, here's an incremental fix.

Regards,

Tony

8< -----------------------

Quoted 1 line

From tony Mon Sep 17 00:00:00 2001

From: Tony Lindgren <[email protected]>
Date: Mon, 19 Sep 2016 16:02:12 -0700
Subject: [PATCH] ARM: dts: Fix igepv5 power button GPIO direction
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

It should be GPIO_ACTIVE_LOW instead of GPIO_ACTIVE_HIGH as pointed out by Pau Pajuel <[email protected]>.

Cc Agust? Fontquerni i Gorchs <[email protected]>

Cc Enric Balletbo Serra <[email protected]>

Cc Javier Martinez Canillas <[email protected]>

Cc Pau Pajuel <[email protected]>

Fixes b118c6a6ffa1 ("ARM: dts: Add power button support for igepv5")

Signed-off-by Tony Lindgren <[email protected]>

---
 arch/arm/boot/dts/omap5-igep0050.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/boot/dts/omap5-igep0050.dts +1 -1

@@ -27,7 +27,7 @@
 		power-button {
 			label = "Power Button";
 			linux,code = <KEY_POWER>;
-			gpios = <&gpio4 22 GPIO_ACTIVE_HIGH>;
+			gpios = <&gpio4 22 GPIO_ACTIVE_LOW>;
 		};
 	};

Signature · 1 line

2.9.3

Ladislav Michl

2016-09-20 12:15 UTC #4 lore raw

PATCH 1/1 ARM: dts: Add power button support for igepv5

Quoted 16 lines · Tony Lindgren

Quoted 15 lines · Pau Pajuel
Hello Tony,
2016-09-14 3:26 GMT+02:00 Javier Martinez Canillas <[email protected]>:
Quoted 12 lines
Hello Tony,
Quoted 8 lines · Tony Lindgren
Add power button support for igepv5.
Cc Agust? Fontquerni i Gorchs <[email protected]>
Cc Enric Balletbo Serra <[email protected]>
Cc Javier Martinez Canillas <[email protected]>
Cc Pau Pajuel <[email protected]>
Signed-off-by Tony Lindgren <[email protected]>
---

Quoted 4 lines

Quoted 2 lines
Quoted 1 line
I don't have a schematics for this board, but the patch looks good to me.
Patch has an errata. Power button is GPIO_ACTIVE_LOW instead GPIO_ACTIVE_HIGH.
Oops sorry about that, here's an incremental fix.

And here's another nitpick ;-)

8< -----------------------

Quoted 1 line

From 209f676512b5265ab4e9b4efa5a44c281ec2fc71 Mon Sep 17 00:00:00 2001

From: Ladislav Michl <[email protected]>
Date: Tue, 20 Sep 2016 14:09:03 +0200
Subject: [PATCH 2/2] ARM: omap5-igep0050.dts: Use tabs for indentation

Cc Agust? Fontquerni i Gorchs <[email protected]>

Cc Enric Balletbo Serra <[email protected]>

Cc Javier Martinez Canillas <[email protected]>

Cc Pau Pajuel <[email protected]>

Fixes b118c6a6ffa1 ("ARM: dts: Add power button support for igepv5")

Signed-off-by Ladislav Michl <[email protected]>

---
 arch/arm/boot/dts/omap5-igep0050.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/boot/dts/omap5-igep0050.dts +1 -1

index 139c8f7..44be08a 100644
@@ -20,7 +20,7 @@
 	};
 
 	gpio_keys {
-                compatible = "gpio-keys";
+		compatible = "gpio-keys";
 		pinctrl-0 = <&power_button_pin>;
 		pinctrl-names = "default";

Signature · 1 line

2.1.4

Tony Lindgren

author

2016-09-20 18:39 UTC #5 lore raw

PATCH 1/1 ARM: dts: Add power button support for igepv5

Quoted 17 lines · Ladislav Michl

Quoted 16 lines · Tony Lindgren
Quoted 15 lines · Pau Pajuel
Hello Tony,
2016-09-14 3:26 GMT+02:00 Javier Martinez Canillas <[email protected]>:
Quoted 12 lines
Hello Tony,
Quoted 8 lines · Tony Lindgren
Add power button support for igepv5.
Cc Agust? Fontquerni i Gorchs <[email protected]>
Cc Enric Balletbo Serra <[email protected]>
Cc Javier Martinez Canillas <[email protected]>
Cc Pau Pajuel <[email protected]>
Signed-off-by Tony Lindgren <[email protected]>
---

Quoted 6 lines

Quoted 4 lines
Quoted 2 lines
Quoted 1 line
I don't have a schematics for this board, but the patch looks good to me.
Patch has an errata. Power button is GPIO_ACTIVE_LOW instead GPIO_ACTIVE_HIGH.
Oops sorry about that, here's an incremental fix.
And here's another nitpick ;-)

Heh OK thanks, applying both into omap-for-v4.9/dt-v2.

Regards,

Tony