Patch "[PATCH 062/135] megaraid: Fix possible NULL pointer deference in" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 6 messages Sep 9, 2016 – Sep 11, 2016 5 messages not in the archive

Subsystems (3)

Stable branch SCSI Megaraid SCSI/SAS drivers

lore

Share & tools

lore

[email protected]

author maintainer Applied

2016-09-09 13:41 UTC #0 lore raw

This is a note to let you know that I've just added the patch titled

[PATCH 062/135] megaraid: Fix possible NULL pointer deference in

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 301709c17bc50faa7f2c77797e454f3286d8ba39 Mon Sep 17 00:00:00 2001

From: Nicholas Krause <[email protected]>
Date: Tue, 5 Jan 2016 14:32:54 -0500
Subject: [PATCH 062/135] megaraid: Fix possible NULL pointer deference in
mraid_mm_ioctl

[ Upstream commit 7296f62f0322d808362b21064deb34f20799c20d ]

This adds the needed check after the call to the function mraid_mm_alloc_kioc in order to make sure that this function has not returned NULL and therefore makes sure we do not deference a NULL pointer if one is returned by mraid_mm_alloc_kioc. Further more add needed comments explaining that this function call can return NULL if the list head is empty for the pointer passed in order to allow furture users to understand this required pointer check.

Signed-off-by Nicholas Krause <[email protected]>

Acked-by Sumit Saxena <[email protected]>

Signed-off-by Martin K. Petersen <[email protected]>

Signed-off-by Sasha Levin <[email protected]>

Signed-off-by Greg Kroah-Hartman <[email protected]>

---
 drivers/scsi/megaraid/megaraid_mm.c |    4 ++++
 1 file changed, 4 insertions(+)

drivers/scsi/megaraid/megaraid_mm.c +4 -0

@@ -179,8 +179,12 @@ mraid_mm_ioctl(struct file *filep, unsig
 
 	/*
 	 * The following call will block till a kioc is available
+	 * or return NULL if the list head is empty for the pointer
+	 * of type mraid_mmapt passed to mraid_mm_alloc_kioc
 	 */
 	kioc = mraid_mm_alloc_kioc(adp);
+	if (!kioc)
+		return -ENXIO;
 
 	/*
 	 * User sent the old mimd_t ioctl packet. Convert it to uioc_t.

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch

A message that is not in the archive (sent off-list or not yet received): [email protected]

Greg KH

author maintainer

2016-09-10 08:15 UTC #2 lore raw

Quoted 63 lines · Nicholas Krause

Quoted 60 lines · On September 9, 2016 9:38:13 AM EDT, [email protected] wrote:
This is a note to let you know that I've just added the patch titled
[PATCH 062/135] megaraid: Fix possible NULL pointer deference in
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
From 301709c17bc50faa7f2c77797e454f3286d8ba39 Mon Sep 17 00:00:00 2001
From: Nicholas Krause <[email protected]>
Date: Tue, 5 Jan 2016 14:32:54 -0500
Subject: [PATCH 062/135] megaraid: Fix possible NULL pointer deference in
mraid_mm_ioctl
[ Upstream commit 7296f62f0322d808362b21064deb34f20799c20d ]
This adds the needed check after the call to the function mraid_mm_alloc_kioc in order to make sure that this function has not returned NULL and therefore makes sure we do not deference a NULL pointer if one is returned by mraid_mm_alloc_kioc. Further more add needed comments explaining that this function call can return NULL if the list head is empty for the pointer passed in order to allow furture users to understand this required pointer check.
Signed-off-by Nicholas Krause <[email protected]>
Acked-by Sumit Saxena <[email protected]>
Signed-off-by Martin K. Petersen <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
drivers/scsi/megaraid/megaraid_mm.c | 4 ++++
1 file changed, 4 insertions(+)
drivers/scsi/megaraid/megaraid_mm.c +4 -0
@@ -179,8 +179,12 @@ mraid_mm_ioctl(struct file *filep, unsig
 
 	/*
 	 * The following call will block till a kioc is available
+	 * or return NULL if the list head is empty for the pointer
+	 * of type mraid_mmapt passed to mraid_mm_alloc_kioc
 	 */
 	kioc = mraid_mm_alloc_kioc(adp);
+	if (!kioc)
+		return -ENXIO;
 
 	/*
 	 * User sent the old mimd_t ioctl packet. Convert it to uioc_t.

Quoted 6 lines

Quoted 4 lines
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
I do not wish any of my work to
touch the stable kernel tree.

Hahaha, sure, gladly deleted, too funny...

greg k-h

A message that is not in the archive (sent off-list or not yet received): [email protected]

Greg KH

author maintainer

2016-09-10 15:15 UTC #4 lore raw

Quoted 81 lines · Nicholas Krause

Quoted 78 lines · Greg KH
Quoted 3 lines · Nicholas Krause
On September 9, 2016 9:38:13 AM EDT, [email protected]
Quoted 19 lines · wrote:
Quoted 6 lines
This is a note to let you know that I've just added the patch titled
[PATCH 062/135] megaraid: Fix possible NULL pointer deference in
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
Quoted 11 lines
The filename of the patch is:
0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
From 301709c17bc50faa7f2c77797e454f3286d8ba39 Mon Sep 17 00:00:00
2001
Quoted 3 lines
Quoted 3 lines
From: Nicholas Krause <[email protected]>
Date: Tue, 5 Jan 2016 14:32:54 -0500
Subject: [PATCH 062/135] megaraid: Fix possible NULL pointer
deference
Quoted 10 lines
Quoted 10 lines
in
mraid_mm_ioctl
[ Upstream commit 7296f62f0322d808362b21064deb34f20799c20d ]
This adds the needed check after the call to the function mraid_mm_alloc_kioc in order to make sure that this function has not returned NULL and therefore makes sure we do not deference a NULL pointer if one is returned by mraid_mm_alloc_kioc. Further more add needed comments explaining that this function call can return NULL
if
Quoted 1 line
Quoted 1 line
the list head is empty for the pointer passed in order to allow
furture
Quoted 35 lines
Quoted 28 lines
users to understand this required pointer check.
Signed-off-by Nicholas Krause <[email protected]>
Acked-by Sumit Saxena <[email protected]>
Signed-off-by Martin K. Petersen <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
drivers/scsi/megaraid/megaraid_mm.c | 4 ++++
1 file changed, 4 insertions(+)
drivers/scsi/megaraid/megaraid_mm.c +4 -0
@@ -179,8 +179,12 @@ mraid_mm_ioctl(struct file *filep, unsig
 
 	/*
 	 * The following call will block till a kioc is available
+	 * or return NULL if the list head is empty for the pointer
+	 * of type mraid_mmapt passed to mraid_mm_alloc_kioc
 	 */
 	kioc = mraid_mm_alloc_kioc(adp);
+	if (!kioc)
+		return -ENXIO;
 
 	/*
 	 * User sent the old mimd_t ioctl packet. Convert it to uioc_t.
Quoted 3 lines
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch I do not wish any of my work to
touch the stable kernel tree.

Quoted 5 lines

Quoted 3 lines
Hahaha, sure, gladly deleted, too funny...
greg k-h
On top of that please revert the regression fix. That is also my work and therefore shouldn't be touching the stable tree either.

What exactly are you referring to?

A message that is not in the archive (sent off-list or not yet received): [email protected]

Greg KH

author maintainer

2016-09-10 15:48 UTC #6 lore raw

Quoted 87 lines · nick

Quoted 84 lines · Greg KH
Quoted 83 lines · Nicholas Krause
Quoted 80 lines · Greg KH
Quoted 3 lines · Nicholas Krause
On September 9, 2016 9:38:13 AM EDT, [email protected]
Quoted 19 lines · wrote:
Quoted 6 lines
This is a note to let you know that I've just added the patch titled
[PATCH 062/135] megaraid: Fix possible NULL pointer deference in
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
Quoted 11 lines
The filename of the patch is:
0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <[email protected]> know about it.
From 301709c17bc50faa7f2c77797e454f3286d8ba39 Mon Sep 17 00:00:00
2001
Quoted 3 lines
Quoted 3 lines
From: Nicholas Krause <[email protected]>
Date: Tue, 5 Jan 2016 14:32:54 -0500
Subject: [PATCH 062/135] megaraid: Fix possible NULL pointer
deference
Quoted 10 lines
Quoted 10 lines
in
mraid_mm_ioctl
[ Upstream commit 7296f62f0322d808362b21064deb34f20799c20d ]
This adds the needed check after the call to the function mraid_mm_alloc_kioc in order to make sure that this function has not returned NULL and therefore makes sure we do not deference a NULL pointer if one is returned by mraid_mm_alloc_kioc. Further more add needed comments explaining that this function call can return NULL
if
Quoted 1 line
Quoted 1 line
the list head is empty for the pointer passed in order to allow
furture
Quoted 28 lines
Quoted 28 lines
users to understand this required pointer check.
Signed-off-by Nicholas Krause <[email protected]>
Acked-by Sumit Saxena <[email protected]>
Signed-off-by Martin K. Petersen <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
drivers/scsi/megaraid/megaraid_mm.c | 4 ++++
1 file changed, 4 insertions(+)
drivers/scsi/megaraid/megaraid_mm.c +4 -0
@@ -179,8 +179,12 @@ mraid_mm_ioctl(struct file *filep, unsig
 
 	/*
 	 * The following call will block till a kioc is available
+	 * or return NULL if the list head is empty for the pointer
+	 * of type mraid_mmapt passed to mraid_mm_alloc_kioc
 	 */
 	kioc = mraid_mm_alloc_kioc(adp);
+	if (!kioc)
+		return -ENXIO;
 
 	/*
 	 * User sent the old mimd_t ioctl packet. Convert it to uioc_t.
Quoted 7 lines
Quoted 3 lines
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch I do not wish any of my work to
touch the stable kernel tree.
Hahaha, sure, gladly deleted, too funny...

Quoted 8 lines

Quoted 6 lines
Quoted 3 lines
Quoted 1 line
greg k-h
On top of that please revert the regression fix. That is also my work and therefore shouldn't be touching the stable tree either.
What exactly are you referring to?
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=fbedcaf43fba35677c01a4ae51e6f79edf4049ba
This commit I want removed from stable as I refuse to have any of my work in the stable tree for now.

Please learn a bit more about git, and how this specific commit isn't in a "stable tree" before saying stuff like this, there is nothing to do, unless you want us to revert your changes entirely (and even then, you can't rewrite history...)

sorry,

greg k-h

A message that is not in the archive (sent off-list or not yet received): [email protected]

Greg KH

author maintainer

2016-09-10 16:05 UTC #8 lore raw

Quoted 121 lines · Nicholas Krause

Quoted 118 lines · Greg KH
Quoted 7 lines · nick
Quoted 4 lines · Greg KH
Quoted 3 lines · Nicholas Krause
On September 10, 2016 4:15:05 AM EDT, Greg KH
Quoted 7 lines · <[email protected]> wrote:
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines · Nicholas Krause
Quoted 3 lines
On September 9, 2016 9:38:13 AM EDT, [email protected]
Quoted 2 lines · wrote:
Quoted 2 lines
This is a note to let you know that I've just added the patch
titled
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
[PATCH 062/135] megaraid: Fix possible NULL pointer
deference in
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
The filename of the patch is:
0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the
stable
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
tree,
please let <[email protected]> know about it.
From 301709c17bc50faa7f2c77797e454f3286d8ba39 Mon Sep 17
00:00:00
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
2001
Quoted 3 lines
Quoted 3 lines
From: Nicholas Krause <[email protected]>
Date: Tue, 5 Jan 2016 14:32:54 -0500
Subject: [PATCH 062/135] megaraid: Fix possible NULL pointer
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
deference
Quoted 7 lines
Quoted 7 lines
in
mraid_mm_ioctl
[ Upstream commit 7296f62f0322d808362b21064deb34f20799c20d ]
This adds the needed check after the call to the function mraid_mm_alloc_kioc in order to make sure that this function
has not
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
returned NULL and therefore makes sure we do not deference a
NULL
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
pointer if one is returned by mraid_mm_alloc_kioc. Further
more add
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
needed comments explaining that this function call can return
NULL
Quoted 27 lines
Quoted 27 lines
Quoted 27 lines
Quoted 27 lines
if
Quoted 1 line
Quoted 1 line
the list head is empty for the pointer passed in order to allow
furture
Quoted 24 lines
Quoted 24 lines
users to understand this required pointer check.
Signed-off-by Nicholas Krause <[email protected]>
Acked-by Sumit Saxena <[email protected]>
Signed-off-by Martin K. Petersen <[email protected]>
Signed-off-by Sasha Levin <[email protected]>
Signed-off-by Greg Kroah-Hartman <[email protected]>
---
drivers/scsi/megaraid/megaraid_mm.c | 4 ++++
1 file changed, 4 insertions(+)
drivers/scsi/megaraid/megaraid_mm.c +4 -0
@@ -179,8 +179,12 @@ mraid_mm_ioctl(struct file *filep, unsig
 
 	/*
 	 * The following call will block till a kioc is available
+	 * or return NULL if the list head is empty for the pointer
+	 * of type mraid_mmapt passed to mraid_mm_alloc_kioc
 	 */
 	kioc = mraid_mm_alloc_kioc(adp);
+	if (!kioc)
+		return -ENXIO;
 
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
drivers/scsi/megaraid/megaraid_mm.c mraid_mm_ioctl(struct file *filep, unsig · line 190
Quoted 2 lines
drivers/scsi/megaraid/megaraid_mm.c +0 -0
 	/*
 	 * User sent the old mimd_t ioctl packet. Convert it to
uioc_t.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
Quoted 12 lines
Quoted 11 lines
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines
I do not wish any of my work to
touch the stable kernel tree.
Hahaha, sure, gladly deleted, too funny...
greg k-h
On top of that please revert the regression fix. That is also my work and therefore shouldn't be touching the stable tree either.
What exactly are you referring to?
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=fbedcaf43fba35677c01a4ae51e6f79edf4049ba
Quoted 1 line
This commit I want removed from stable as I refuse to have any of my
work in the stable tree for now.
Please learn a bit more about git, and how this specific commit isn't in
a "stable tree" before saying stuff like this, there is nothing to do, unless you want us to revert your changes entirely (and even then, you can't rewrite history...)

Quoted 4 lines

Quoted 3 lines
sorry,
greg k-h
Then revert it from all git trees then.

Please define "all git trees".

And once you send in a patch, you sometimes don't have a say in where it ends up, sorry, that's just how open source development works :)

best of luck!

greg k-h

A message that is not in the archive (sent off-list or not yet received): [email protected]

Greg KH

author maintainer

2016-09-11 07:22 UTC #10 lore raw

Quoted 155 lines · Nicholas Krause

Quoted 152 lines · Greg KH
Quoted 3 lines · Nicholas Krause
On September 10, 2016 11:49:03 AM EDT, Greg KH
Quoted 10 lines · <[email protected]> wrote:
Quoted 10 lines · nick
Quoted 7 lines · Greg KH
Quoted 4 lines · Nicholas Krause
Quoted 3 lines
On September 10, 2016 4:15:05 AM EDT, Greg KH
Quoted 1 line · <[email protected]> wrote:
Quoted 1 line
Quoted 1 line
Quoted 1 line
On Fri, Sep 09, 2016 at 01:08:36PM -0400, Nicholas Krause
Quoted 3 lines · wrote:
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
On September 9, 2016 9:38:13 AM EDT,
[email protected]
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 2 lines · wrote:
Quoted 2 lines
This is a note to let you know that I've just added the
patch
Quoted 42 lines
Quoted 8 lines
titled
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
[PATCH 062/135] megaraid: Fix possible NULL pointer
deference in
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
Quoted 32 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
The filename of the patch is:
0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the
stable
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
tree,
please let <[email protected]> know about it.
From 301709c17bc50faa7f2c77797e454f3286d8ba39 Mon Sep 17
00:00:00
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
2001
Quoted 3 lines
Quoted 3 lines
From: Nicholas Krause <[email protected]>
Date: Tue, 5 Jan 2016 14:32:54 -0500
Subject: [PATCH 062/135] megaraid: Fix possible NULL pointer
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
deference
Quoted 7 lines
Quoted 7 lines
in
mraid_mm_ioctl
[ Upstream commit 7296f62f0322d808362b21064deb34f20799c20d ]
This adds the needed check after the call to the function mraid_mm_alloc_kioc in order to make sure that this function
has not
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
returned NULL and therefore makes sure we do not deference a
NULL
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
pointer if one is returned by mraid_mm_alloc_kioc. Further
more add
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
needed comments explaining that this function call can
return
Quoted 3 lines
Quoted 3 lines
NULL
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
if
Quoted 1 line
Quoted 1 line
the list head is empty for the pointer passed in order to
allow
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
furture
Quoted 5 lines
Quoted 5 lines
users to understand this required pointer check.
Signed-off-by Nicholas Krause <[email protected]>
Acked-by Sumit Saxena <[email protected]>
Signed-off-by Martin K. Petersen
<[email protected]>
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Signed-off-by Sasha Levin <[email protected]>
Signed-off-by Greg Kroah-Hartman
<[email protected]>
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
drivers/scsi/megaraid/megaraid_mm.c mraid_mm_ioctl(struct file *filep,
Quoted 7 lines
---
drivers/scsi/megaraid/megaraid_mm.c | 4 ++++
1 file changed, 4 insertions(+)
drivers/scsi/megaraid/megaraid_mm.c +0 -0
@@ -179,8 +179,12 @@ mraid_mm_ioctl(struct file *filep,
unsig
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
drivers/scsi/megaraid/megaraid_mm.c mraid_mm_ioctl(struct file *filep, · line 181
Quoted 4 lines
drivers/scsi/megaraid/megaraid_mm.c +1 -0
 	/*
 	 * The following call will block till a kioc is available
+	 * or return NULL if the list head is empty for the
pointer
Quoted 11 lines
Quoted 11 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
drivers/scsi/megaraid/megaraid_mm.c mraid_mm_ioctl(struct file *filep, · line 189
Quoted 8 lines
drivers/scsi/megaraid/megaraid_mm.c +3 -0
+	 * of type mraid_mmapt passed to mraid_mm_alloc_kioc
 	 */
 	kioc = mraid_mm_alloc_kioc(adp);
+	if (!kioc)
+		return -ENXIO;
 
 	/*
 	 * User sent the old mimd_t ioctl packet. Convert it to
uioc_t.
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 14 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
Quoted 3 lines
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/0062-megaraid-Fix-possible-NULL-pointer-deference-in-mrai.patch
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Quoted 2 lines
I do not wish any of my work to
touch the stable kernel tree.
Hahaha, sure, gladly deleted, too funny...
greg k-h
On top of that please revert the regression fix. That is also
my
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
work and therefore shouldn't be touching the stable tree
either.
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
What exactly are you referring to?
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=fbedcaf43fba35677c01a4ae51e6f79edf4049ba
Quoted 1 line
Quoted 1 line
This commit I want removed from stable as I refuse to have any of
my
Quoted 3 lines
Quoted 3 lines
work in the stable tree for now.
Please learn a bit more about git, and how this specific commit
isn't
Quoted 2 lines
Quoted 2 lines
in
a "stable tree" before saying stuff like this, there is nothing to
do,
Quoted 1 line
Quoted 1 line
unless you want us to revert your changes entirely (and even then,
you
Quoted 6 lines
Quoted 5 lines
can't rewrite history...)
sorry,
greg k-h
Then revert it from all git trees then.
Please define "all git trees".
And once you send in a patch, you sometimes don't have a say in where it
ends up, sorry, that's just how open source development works :)

Quoted 5 lines

Quoted 3 lines
best of luck!
greg k-h
From now I don't want any of patches being used as I refuse for my work to be used by such a toxic community toward me. Nick

One of the properties of the GPL is that once you have released your code, or patch, under that license, you can't dictate the rules of "use", sorry.

Again, I have already dropped this patch from the stable queue so I don't understand what more we can do here.

Best of luck in the future,

greg k-h