Skip to contentSkip to conversation

openal: Explicitly enable/disable NEON support

PATCH Superseded André Hentschel 2 participants 4 messages Sep 1, 2016 – Sep 11, 2016

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 openal: Explicitly enable/disable NEON support

Fixes:
http://autobuild.buildroot.net/results/d7ccef77a355ccc23f26d012e8441af931469ae4
http://autobuild.buildroot.net/results/b5777a0ed33f6bb7a5fc0486ea21ecef58615dac

---
 package/openal/openal.mk | 7 +++++++
 1 file changed, 7 insertions(+)
package/openal/openal.mk +7 -0
index 2916aa6..aac1121 100644
@@ -50,4 +50,11 @@ ifeq ($(BR2_STATIC_LIBS),y)
 OPENAL_CONF_OPTS += -DLIBTYPE=STATIC
 endif
 
+# Explicitly enable/disable NEON support, see https://github.com/kcat/openal-soft/issues/54
+ifeq ($(BR2_ARM_FPU_NEON)$(BR2_ARM_FPU_NEON_VFPV4),y)
+OPENAL_CONF_OPTS += -DALSOFT_CPUEXT_NEON=ON
+else
+OPENAL_CONF_OPTS += -DALSOFT_CPUEXT_NEON=OFF
+endif
+
 $(eval $(cmake-package))
Signature · 1 line
2.7.4
#1 lore raw

PATCH v2 1/1 openal: Explicitly enable/disable NEON support

Hello,

Quoted 6 lines · Andr? Hentschel

Fixes:
http://autobuild.buildroot.net/results/d7ccef77a355ccc23f26d012e8441af931469ae4
http://autobuild.buildroot.net/results/b5777a0ed33f6bb7a5fc0486ea21ecef58615dac

What about instead:

https://github.com/kcat/openal-soft/pull/64

to fix this issue (I tested, it fixes the build failure).

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH v2 1/1 openal: Explicitly enable/disable NEON support

Am 06.09.2016 um 22:25 schrieb Thomas Petazzoni:

Quoted 10 lines

Hello,

Quoted 6 lines · Andr? Hentschel

Fixes:
http://autobuild.buildroot.net/results/d7ccef77a355ccc23f26d012e8441af931469ae4
http://autobuild.buildroot.net/results/b5777a0ed33f6bb7a5fc0486ea21ecef58615dac

Quoted 8 lines

What about instead:

https://github.com/kcat/openal-soft/pull/64

to fix this issue (I tested, it fixes the build failure).

Thomas

Sorry was on a business trip.
As it is upstream meanwhile (together with a runtime neon check suggested by you) I'm fine with a patch added to the openal package. It's your work, so be free to do so.
Or do you know about plans of an upcoming openal bugfix release? That'd be easier I guess

#3 lore raw

PATCH v2 1/1 openal: Explicitly enable/disable NEON support

Hello,

Quoted 3 lines · Andr? Hentschel

Sorry was on a business trip.
As it is upstream meanwhile (together with a runtime neon check suggested by you) I'm fine with a patch added to the openal package. It's your work, so be free to do so.

If you could send a Buildroot patch adding the upstream fix, it would be nice.

Quoted 2 lines

Or do you know about plans of an upcoming openal bugfix release? That'd be easier I guess

I'm not aware of upstream plans in terms of new releases, I don't know if they do regular ones or not. In order to avoid seeing build failures, backporting the upstreaming fix would be a good thing to do for now.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com