Skip to contentSkip to conversation

package/php-ssh2: fix kconfig circular deps after libssh2 fix

PATCH New Yann E. MORIN 3 participants 3 messages Sep 11, 2016 – Sep 12, 2016

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH 1/1 package/php-ssh2: fix kconfig circular deps after libssh2 fix

After we simplified the libssh2 dependencies, the new dependencies were not propagated to the php-ssh2 package, causing circular dependencies:

package/openssl/Config.in:1:error: recursive dependency detected!
package/openssl/Config.in:1: symbol BR2_PACKAGE_OPENSSL is selected by BR2_PACKAGE_LIBSSH2
package/libssh2/Config.in:1: symbol BR2_PACKAGE_LIBSSH2 is selected by BR2_PACKAGE_PHP_SSH2
package/php-ssh2/Config.in:1: symbol BR2_PACKAGE_PHP_SSH2 depends on BR2_PACKAGE_OPENSSL

Just drop the now-useless dependency inherited from libssh2: libssh2 now has no dependency.

Reported-by Thomas Petazzoni <[email protected]>
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Arnout Vandecappelle <[email protected]>
---
 package/php-ssh2/Config.in | 2 --
 1 file changed, 2 deletions(-)
package/php-ssh2/Config.in +0 -2
index c795dd5..b457900 100644
@@ -1,8 +1,6 @@
 config BR2_PACKAGE_PHP_SSH2
 	bool "php-ssh2"
 	depends on BR2_PACKAGE_PHP
-	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS \
-		&& !BR2_PACKAGE_OPENSSL # libssh2, libgcrypt
 	select BR2_PACKAGE_LIBSSH2
 	help
 	  PHP bindings for the libssh2 library.
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 package/php-ssh2: fix kconfig circular deps after libssh2 fix

Quoted 8 lines · Yann E. MORIN

After we simplified the libssh2 dependencies, the new dependencies were not propagated to the php-ssh2 package, causing circular dependencies:

package/openssl/Config.in:1:error: recursive dependency detected!
package/openssl/Config.in:1: symbol BR2_PACKAGE_OPENSSL is selected by BR2_PACKAGE_LIBSSH2
package/libssh2/Config.in:1: symbol BR2_PACKAGE_LIBSSH2 is selected by BR2_PACKAGE_PHP_SSH2
package/php-ssh2/Config.in:1: symbol BR2_PACKAGE_PHP_SSH2 depends on BR2_PACKAGE_OPENSSL

Quoted 6 lines

Just drop the now-useless dependency inherited from libssh2: libssh2 now has no dependency.

Reported-by Thomas Petazzoni <[email protected]>
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Arnout Vandecappelle <[email protected]>
Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Thanks for the speedy fix!

Regards,
Arnout

Quoted 18 lines
---
 package/php-ssh2/Config.in | 2 --
 1 file changed, 2 deletions(-)
package/php-ssh2/Config.in +0 -2
index c795dd5..b457900 100644
@@ -1,8 +1,6 @@
 config BR2_PACKAGE_PHP_SSH2
 	bool "php-ssh2"
 	depends on BR2_PACKAGE_PHP
-	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS \
-		&& !BR2_PACKAGE_OPENSSL # libssh2, libgcrypt
 	select BR2_PACKAGE_LIBSSH2
 	help
 	  PHP bindings for the libssh2 library.
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Applied
#2 lore raw

PATCH 1/1 package/php-ssh2: fix kconfig circular deps after libssh2 fix

In reply to Yann E. MORIN

Hello,

Quoted 11 lines · Yann E. MORIN

After we simplified the libssh2 dependencies, the new dependencies were not propagated to the php-ssh2 package, causing circular dependencies:

package/openssl/Config.in:1:error: recursive dependency detected!
package/openssl/Config.in:1: symbol BR2_PACKAGE_OPENSSL is selected by BR2_PACKAGE_LIBSSH2
package/libssh2/Config.in:1: symbol BR2_PACKAGE_LIBSSH2 is selected by BR2_PACKAGE_PHP_SSH2
package/php-ssh2/Config.in:1: symbol BR2_PACKAGE_PHP_SSH2 depends on BR2_PACKAGE_OPENSSL

Just drop the now-useless dependency inherited from libssh2: libssh2 now has no dependency.

Quoted 6 lines
Reported-by Thomas Petazzoni <[email protected]>
Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Arnout Vandecappelle <[email protected]>
---
 package/php-ssh2/Config.in | 2 --
 1 file changed, 2 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com