Skip to contentSkip to conversation

staging: emxx_udc: Remove unnecessary blank line

PATCH In review Rehas Sachdeva 3 participants 3 messages Sep 12, 2016 Staging

lore
Share & tools
lore

Rehas Sachdeva

author
#0 lore raw

PATCH 1/1 staging: emxx_udc: Remove unnecessary blank line

This patch fixes the checkpatch.pl warning:
Blank lines aren't necessary before a close brace '}'

Signed-off-by Rehas Sachdeva <[email protected]>
---
 drivers/staging/emxx_udc/emxx_udc.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/emxx_udc/emxx_udc.c +0 -1
index f4d9000..f6233ec 100644
@@ -131,7 +131,6 @@ static void _nbu2ss_dump_register(struct nbu2ss_udc *udc)
 		reg_data =  _nbu2ss_readl(
 			(u32 *)IO_ADDRESS(USB_BASE_ADDRESS + i + 12));
 		dev_dbg(&udc->dev, " %08x\n", (int)reg_data);
-
 	}
 
 	spin_lock(&udc->lock);
Signature · 1 line
2.7.4
#1 lore raw
Quoted 13 lines · Rehas Sachdeva

This patch fixes the checkpatch.pl warning:
Blank lines aren't necessary before a close brace '}'

Signed-off-by Rehas Sachdeva <[email protected]>
---
 drivers/staging/emxx_udc/emxx_udc.c | 1 -
 1 file changed, 1 deletion(-)
drivers/staging/emxx_udc/emxx_udc.c +0 -0
index f4d9000..f6233ec 100644

drivers/staging/emxx_udc/emxx_udc.c static void _nbu2ss_dump_register(struct nbu2ss_udc *udc) · line 136

Quoted 7 lines
drivers/staging/emxx_udc/emxx_udc.c +0 -1
@@ -131,7 +131,6 @@ static void _nbu2ss_dump_register(struct nbu2ss_udc *udc)
 		reg_data =  _nbu2ss_readl(
 			(u32 *)IO_ADDRESS(USB_BASE_ADDRESS + i + 12));
 		dev_dbg(&udc->dev, " %08x\n", (int)reg_data);
-
 	}
 
 	spin_lock(&udc->lock);

This looks like a good start :)

For this round, however, you should also submit the patch to the maintainers of the file, as described here:

https://kernelnewbies.org/FirstKernelPatch#submit_a_patch

The tutorial was just updated with this information yesterday, so you may have missed it, if you got started before.

julia

maintainer
#2 lore raw
In reply to Rehas Sachdeva
Quoted 7 lines · Rehas Sachdeva

This patch fixes the checkpatch.pl warning:
Blank lines aren't necessary before a close brace '}'

Signed-off-by Rehas Sachdeva <[email protected]>
---
 drivers/staging/emxx_udc/emxx_udc.c | 1 -
 1 file changed, 1 deletion(-)

Nice job, but you forgot to also cc: the maintainer of this file.

Oh, that's me, hm, nevermind...

now applied, nice work as the first submitted patch of the application process, and also the first accepted one into the kernel tree :)

greg k-h