netfilter: nft_hash: fix hash overflow validation
Subsystems (2)
PATCH 1/1 netfilter: nft_hash: fix hash overflow validation
The overflow validation in the init() function establishes that the maximum value that the hash could reach is less than U32_MAX, which is likely to be true.
The fix detects the overflow when the maximum hash value is less than the offset itself.
Fixes 70ca767ea1b2 ("netfilter: nft_hash: Add hash offset value")
Reported-by Liping Zhang <[email protected]>
Signed-off-by Laura Garcia Liebana <[email protected]>
--- net/netfilter/nft_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/netfilter/nft_hash.c +1 -1
@@ -76,7 +76,7 @@ static int nft_hash_init(const struct nft_ctx *ctx,if (priv->modulus <=1 )return -ERANGE ; -if (priv->offset + priv->modulus -1 <U32_MAX ) +if (priv->offset + priv->modulus -1 < priv->offset)return -EOVERFLOW ; priv->seed =ntohl (nla_get_be32 (tb[NFTA_HASH_SEED ]));
Signature · 1 line
2.8.1
Quoted 6 lines · Laura Garcia Liebana
The overflow validation in the
init()function establishes that the maximum value that the hash could reach is less thanU32_MAX, which is likely to be true.The fix detects the overflow when the maximum hash value is less than the offset itself.
Applied.