kernel-yocto: remove do_shared_workdir from SRCTREECOVEREDTASKS

PATCH In review André Draszik 1 participant 3 messages Sep 13, 2016

Share & tools

André Draszik

author

2016-09-13 09:07 UTC #0 lore raw

PATCH 1/1 kernel-yocto: remove do_shared_workdir from SRCTREECOVEREDTASKS

Various recipes depend on the kernel's do_shared_workdir task, a quick grep suggests all external kernel modules (via module.bbclass), but also perf, and potentially any additional headers as outlined in linux-libc-headers.inc are affected.

Having do_shared_workdir in SRCTREECOVEREDTASKS means this task is removed when externalsrc is enabled, making all those recipes fail as the task they depend on, virtual/kernel:do_shared_workdir, doesn't exist.

Remove do_shared_workdir from SRCTREECOVEREDTASKS so that all those recipes work even if externalsrc is activated.

According to the comment in here, the reason for do_shared_workdir to be removed as a task is because it modifies the source tree, but that doesn't seem to be case.

Signed-off-by André Draszik <[email protected]>

---
 meta/classes/kernel-yocto.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

meta/classes/kernel-yocto.bbclass +1 -1

index 82b9210..53659f2 100644
@@ -1,5 +1,5 @@
 # remove tasks that modify the source tree in case externalsrc is inherited
-SRCTREECOVEREDTASKS += "do_kernel_configme do_validate_branches do_kernel_configcheck do_kernel_checkout do_shared_workdir do_fetch do_unpack do_patch"
+SRCTREECOVEREDTASKS += "do_kernel_configme do_validate_branches do_kernel_configcheck do_kernel_checkout do_fetch do_unpack do_patch"
 
 # returns local (absolute) path names for all valid patches in the
 # src_uri

Signature · 1 line

2.9.3

André Draszik

author

2016-09-13 11:09 UTC #1 lore raw

Ignore this. This doesn't yet work as I intended I think.

Quoted 40 lines · André Draszik

Various recipes depend on the kernel's do_shared_workdir task, a quick grep suggests all external kernel modules (via module.bbclass), but also perf, and potentially any additional headers as outlined in linux-libc-headers.inc are affected.
Having do_shared_workdir in SRCTREECOVEREDTASKS means this task is removed when externalsrc is enabled, making all those recipes fail as the task they depend on, virtual/kernel:do_shared_workdir, doesn't exist.
Remove do_shared_workdir from SRCTREECOVEREDTASKS so that all those recipes work even if externalsrc is activated.
According to the comment in here, the reason for do_shared_workdir to be removed as a task is because it modifies the source tree, but that doesn't seem to be case.
Signed-off-by André Draszik <[email protected]>
---
meta/classes/kernel-yocto.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/kernel- renamed from meta/classes/kernel-yocto.bbclass +0 -0
yocto.bbclass
index 82b9210..53659f2 100644
meta/classes/kernel-yocto.bbclass +0 -0
@@ -1,5 +1,5 @@
  # remove tasks that modify the source tree in case externalsrc is
inherited
-SRCTREECOVEREDTASKS += "do_kernel_configme do_validate_branches do_kernel_configcheck do_kernel_checkout do_shared_workdir do_fetch do_unpack do_patch"
+SRCTREECOVEREDTASKS += "do_kernel_configme do_validate_branches do_kernel_configcheck do_kernel_checkout do_fetch do_unpack do_patch"
 # returns local (absolute) path names for all valid patches in the
 # src_uri

André Draszik

author

2016-09-13 13:29 UTC #2 lore raw

Please unignore this patch :-) The patch does what I intended.

Sorry for the noise.

Quoted 44 lines · André Draszik

Ignore this. This doesn't yet work as I intended I think.
Quoted 41 lines · André Draszik
Various recipes depend on the kernel's do_shared_workdir task, a quick grep suggests all external kernel modules (via module.bbclass), but also perf, and potentially any additional headers as outlined in linux-libc-headers.inc are affected.
Having do_shared_workdir in SRCTREECOVEREDTASKS means this task is removed when externalsrc is enabled, making all those recipes fail as the task they depend on, virtual/kernel:do_shared_workdir, doesn't exist.
Remove do_shared_workdir from SRCTREECOVEREDTASKS so that all those recipes work even if externalsrc is activated.
According to the comment in here, the reason for do_shared_workdir to be removed as a task is because it modifies the source tree, but that doesn't seem to be case.
Signed-off-by André Draszik <[email protected]>
---
meta/classes/kernel-yocto.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/kernel- renamed from meta/classes/kernel-yocto.bbclass +0 -0
yocto.bbclass
index 82b9210..53659f2 100644
meta/classes/kernel-yocto.bbclass +0 -0
@@ -1,5 +1,5 @@
  # remove tasks that modify the source tree in case externalsrc is
inherited
-SRCTREECOVEREDTASKS += "do_kernel_configme do_validate_branches do_kernel_configcheck do_kernel_checkout do_shared_workdir do_fetch do_unpack do_patch"
+SRCTREECOVEREDTASKS += "do_kernel_configme do_validate_branches do_kernel_configcheck do_kernel_checkout do_fetch do_unpack do_patch"
 # returns local (absolute) path names for all valid patches in the
 # src_uri