Skip to contentSkip to conversation

powerpc/64: whitelist unresolved modversions CRCs

PATCH In review Nicholas Piggin 4 participants 5 messages Sep 14, 2016 – Sep 22, 2016

Subsystems (2)
lore
Share & tools
lore

Nicholas Piggin

author reviewer
#0 lore raw

PATCH 1/1 powerpc/64: whitelist unresolved modversions CRCs

These are a symptom of CRC generation failure in generic build code, and not powerpc specific.

---

Hi Michal,

Please merge this via your trees with Al's patches. I have a patch that can catch crc generation failure generically, and both Arnd and I have some ideas to fix crc generation for .S exports. This should get powerpc building again with your tree.

Thanks,
Nick

 arch/powerpc/relocs_check.sh | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/powerpc/relocs_check.sh +3 -1
index 2e4ebd0..ec2d5c8 100755
@@ -30,6 +30,7 @@ bad_relocs=$(
 	# On PPC64:
 	#	R_PPC64_RELATIVE, R_PPC64_NONE
 	#	R_PPC64_ADDR64 mach_<name>
+	#	R_PPC64_ADDR64 __crc_<name>
 	# On PPC:
 	#	R_PPC_RELATIVE, R_PPC_ADDR16_HI,
 	#	R_PPC_ADDR16_HA,R_PPC_ADDR16_LO,
@@ -41,7 +42,8 @@ R_PPC_ADDR16_HI
 R_PPC_ADDR16_HA
 R_PPC_RELATIVE
 R_PPC_NONE' |
-	grep -E -v '\<R_PPC64_ADDR64[[:space:]]+mach_'
+	grep -E -v '\<R_PPC64_ADDR64[[:space:]]+mach_' |
+	grep -E -v '\<R_PPC64_ADDR64[[:space:]]+__crc_'
 )
 
 if [ -z "$bad_relocs" ]; then
Signature · 1 line
2.9.3
#1 lore raw

Hi Nick,

Quoted 5 lines · On Wed, 14 Sep 2016 12:45:07 +1000 Nicholas Piggin <[email protected]> wrote:

These are a symptom of CRC generation failure in generic build code, and not powerpc specific.

OK, so I will use this as a merge fix patch for the kbuild tree today (instead of the revert I have been doing).

Signature · 2 lines
Cheers,
Stephen Rothwell