Skip to contentSkip to conversation

irqchip or mfd/tps65217: fix link error

RFC PATCH In review Arnd Bergmann 3 participants 4 messages Sep 14, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 irqchip or mfd/tps65217: fix link error

Building tps65217 as a loadable module (as done in allmodconfig) now fails after we started calling irq_set_parent():

ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!

The two obvious workarounds are either to force the driver to be built-in, or to make that symbol exported to modules.

As it's not clear to me if either of them would be acceptable, I'm sending both of them here, please comment on which one you want to have, or whether the driver should handle this differently and not call irq_set_parent() at all.

Fixes 262d5cc6ceb2 ("mfd: tps65217: Add support for IRQs")
---
 drivers/mfd/Kconfig | 2 +-
 kernel/irq/manage.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/mfd/Kconfig +1 -1
index be1945a42dd1..9a4cef5a2ece 100644
@@ -1229,7 +1229,7 @@ config MFD_TPS65090
 	  functionality of the device.
 
 config MFD_TPS65217
-	tristate "TI TPS65217 Power Management / White LED chips"
+	bool "TI TPS65217 Power Management / White LED chips"
 	depends on I2C
 	select MFD_CORE
 	select REGMAP_I2C
kernel/irq/manage.c +1 -0
index 0c5f1a5db654..9c4d30483264 100644
@@ -721,6 +721,7 @@ int irq_set_parent(int irq, int parent_irq)
 	irq_put_desc_unlock(desc, flags);
 	return 0;
 }
+EXPORT_SYMBOL_GPL(irq_set_parent);
 #endif
 
 /*
Signature · 1 line
2.9.0
#1 lore raw
Quoted 5 lines · Arnd Bergmann

Building tps65217 as a loadable module (as done in allmodconfig) now fails after we started calling irq_set_parent():

ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!

Quoted 7 lines

The two obvious workarounds are either to force the driver to be built-in, or to make that symbol exported to modules.

As it's not clear to me if either of them would be acceptable, I'm sending both of them here, please comment on which one you want to have, or whether the driver should handle this differently and not call irq_set_parent() at all.

The question is why it needs to call that. But if it's justified, then I'm not opposed to export it.

Thanks,

tglx

#2 lore raw
Quoted 9 lines · CEST Thomas Gleixner
Quoted 8 lines · Arnd Bergmann

Building tps65217 as a loadable module (as done in allmodconfig) now fails after we started calling irq_set_parent():

ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!

The two obvious workarounds are either to force the driver to be built-in, or to make that symbol exported to modules.

Quoted 7 lines
Quoted 4 lines

As it's not clear to me if either of them would be acceptable, I'm sending both of them here, please comment on which one you want to have, or whether the driver should handle this differently and not call irq_set_parent() at all.

The question is why it needs to call that. But if it's justified, then I'm not opposed to export it.

Ok. I just noticed that I forgot to put the right people on Cc that worked on the patch originally, fixed that now.

My other approach of making the symbol "bool" in the meantime has caused another problem when CONFIG_I2C=m:

drivers/mfd/tps65217.o: In function `tps65217_init':
tps65217.c:(.init.text+0x8): undefined reference to i2c_register_driver' drivers/mfd/tps65217.o: In function tps65217_probe':
tps65217.c:(.text.tps65217_probe+0x94): undefined reference to `__devm_regmap_init_i2c'

so the dependency would be "depends on I2C=y", getting increasingly ugly. I'll let Marcin or Grygorii reply on why the call is needed, we can then either export the symbol or change the code.

Arnd

#3 lore raw
Quoted 29 lines · Arnd Bergmann
Quoted 9 lines · CEST Thomas Gleixner
Quoted 8 lines · Arnd Bergmann

Building tps65217 as a loadable module (as done in allmodconfig) now fails after we started calling irq_set_parent():

ERROR: "irq_set_parent" [drivers/mfd/tps65217.ko] undefined!

The two obvious workarounds are either to force the driver to be built-in, or to make that symbol exported to modules.

Quoted 7 lines
Quoted 4 lines

As it's not clear to me if either of them would be acceptable, I'm sending both of them here, please comment on which one you want to have, or whether the driver should handle this differently and not call irq_set_parent() at all.

The question is why it needs to call that. But if it's justified, then I'm not opposed to export it.

Ok. I just noticed that I forgot to put the right people on Cc that worked on the patch originally, fixed that now.

My other approach of making the symbol "bool" in the meantime has caused another problem when CONFIG_I2C=m:

drivers/mfd/tps65217.o: In function `tps65217_init':
tps65217.c:(.init.text+0x8): undefined reference to i2c_register_driver' drivers/mfd/tps65217.o: In function tps65217_probe':
tps65217.c:(.text.tps65217_probe+0x94): undefined reference to `__devm_regmap_init_i2c'

Quoted 6 lines

so the dependency would be "depends on I2C=y", getting increasingly ugly. I'll let Marcin or Grygorii reply on why the call is needed, we can then either export the symbol or change the code.

Arnd

I have added irq_set_parent() similarly as in drivers/base/regmap/regmap-irq.c

But to be honest I am not sure what it really does in case of tps65217.

Signature · 1 line
Marcin Niestroj