Enhance fs tests
v2 cover Enhance fs tests
The first 3 patches do some cleanups for the current test, especially TC11 had some issues (strange match for expected output, use of unitialized variable).
The last two patches add test cases for handling ".". Ext4 used to crash, as a match on the first entry of a directory block was not handled correctly.
v2:
Updated:
test/fs: Restructure file path specification to allow some flexibility
* avoid creation of paths with double slashes
test/fs: Check writes using "." (same dir) relative path
* fix issues copied from TC11
* delete written file in cleanup
Added:
test/fs: remove use of undefined WRITE_FILE variable test/fs: strip noise from filesystem code prior to checking results
Stefan Br?ns (5):
test/fs: Restructure file path specification to allow some flexibility test/fs: remove use of undefined WRITE_FILE variable test/fs: strip noise from filesystem code prior to checking results test/fs: Check ext4 behaviour if dirent is first entry in directory
block
test/fs: Check writes using "." (same dir) relative path
test/fs/fs-test.sh | 131 +++++++++++++++++++++++++++++++---------------------- 1 file changed, 78 insertions(+), 53 deletions(-)
Signature · 1 line
2.10.0
v2 cover Enhance fs tests
Hi Stefan,
Quoted 7 lines · Stefan Br?ns
The first 3 patches do some cleanups for the current test, especially TC11 had some issues (strange match for expected output, use of unitialized variable).
The last two patches add test cases for handling ".". Ext4 used to crash, as a match on the first entry of a directory block was not handled correctly.
I think we should move these to pytest before enhancing them.
Quoted 20 lines
v2:
Updated:
test/fs: Restructure file path specification to allow some flexibility
* avoid creation of paths with double slashes
test/fs: Check writes using "." (same dir) relative path
* fix issues copied from TC11
* delete written file in cleanup
Added:
test/fs: remove use of undefinedWRITE_FILEvariable test/fs: strip noise from filesystem code prior to checking resultsStefan Br?ns (5):
test/fs: Restructure file path specification to allow some flexibility test/fs: remove use of undefinedWRITE_FILEvariable test/fs: strip noise from filesystem code prior to checking results test/fs: Check ext4 behaviour if dirent is first entry in directory
block
test/fs: Check writes using "." (same dir) relative path
Quoted 6 lines
test/fs/fs-test.sh | 131 +++++++++++++++++++++++++++++++---------------------- 1 file changed, 78 insertions(+), 53 deletions(-)--
2.10.0
Regards,
Simon
v2 cover Enhance fs tests
Quoted 8 lines · Simon Glass
Hi Stefan,
Quoted 4 lines · Stefan Br?ns
The first 3 patches do some cleanups for the current test, especially TC11 had some issues (strange match for expected output, use of unitialized variable).
Quoted 5 lines
Quoted 3 lines
The last two patches add test cases for handling ".". Ext4 used to crash, as a match on the first entry of a directory block was not handled correctly.
I think we should move these to pytest before enhancing them.
For the moment, I disagree. We have fs issues, and we're fixing fs issues and getting tests while we're doing that is important. It would be good, and would make my (and everyone else that has one too) setup easier if these were migrated but I don't want to blocks more tests on having them be made into different but equivalent tests first.
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160914/daf4532c/attachment.sig>
v2 cover Enhance fs tests
Hi Tom,
Quoted 13 lines · Tom Rini
Quoted 12 lines · Simon Glass
Hi Stefan,
Quoted 7 lines · Stefan Br?ns
The first 3 patches do some cleanups for the current test, especially TC11 had some issues (strange match for expected output, use of unitialized variable).
The last two patches add test cases for handling ".". Ext4 used to crash, as a match on the first entry of a directory block was not handled correctly.
Quoted 7 lines
Quoted 1 line
I think we should move these to pytest before enhancing them.
For the moment, I disagree. We have fs issues, and we're fixing fs issues and getting tests while we're doing that is important. It would be good, and would make my (and everyone else that has one too) setup easier if these were migrated but I don't want to blocks more tests on having them be made into different but equivalent tests first.
Fair enough, I've seen the issues and these are not large additions.
Regards,
Simon