Skip to contentSkip to conversation

staging: iio: accel: Fix indentation

PATCH In review Rehas Sachdeva 3 participants 5 messages Sep 14, 2016 – Sep 16, 2016 2 messages not in the archive

Subsystems (3)
Staging IIO Staging - industrial io
lore
Share & tools
lore

Rehas Sachdeva

author
#0 lore raw

PATCH 1/1 staging: iio: accel: Fix indentation

This patch fixes the checkpatch.pl warning:
WARNING: Statements should start on a tabstop

Signed-off-by Rehas Sachdeva <[email protected]>
---
 drivers/staging/iio/accel/sca3000_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/accel/sca3000_core.c +1 -1
index b5625f5..61f3241 100644
@@ -412,7 +412,7 @@ static const struct iio_event_spec sca3000_event = {
 		},						\
 		.event_spec = &sca3000_event,			\
 		.num_event_specs = 1,				\
-	 }
+	}
 
 static const struct iio_chan_spec sca3000_channels[] = {
 	SCA3000_CHAN(0, IIO_MOD_X),
Signature · 1 line
2.7.4
#1 lore raw
Quoted 4 lines · Rehas Sachdeva

This patch fixes the checkpatch.pl warning:
WARNING: Statements should start on a tabstop

Signed-off-by Rehas Sachdeva <[email protected]>

Hi Rehas,
This is a valid fix, but it was already submitted. You wouldn't have easily known that.

It's in iio git tree, not yet sync'd back to staging. Not sure what the take-away or advice on this situation is.

Greg?

commit a5211b0d061644b48c80cfa1303413e79ace781e

Author: Clifton Barnes <[email protected]>
Date:   Mon Aug 22 22:45:05 2016 -0400

staging: iio: accel: sca3000: remove extra space

alisons

Quoted 26 lines
---
 drivers/staging/iio/accel/sca3000_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/accel/sca3000_core.c +1 -1
index b5625f5..61f3241 100644
@@ -412,7 +412,7 @@ static const struct iio_event_spec sca3000_event = {
 		},						\
 		.event_spec = &sca3000_event,			\
 		.num_event_specs = 1,				\
-	 }
+	}
 
 static const struct iio_chan_spec sca3000_channels[] = {
 	SCA3000_CHAN(0, IIO_MOD_X),
Signature · 8 lines
2.7.4

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914172924.GA27415%40toblerone.
For more options, visit https://groups.google.com/d/optout.
maintainer
#2 lore raw
Quoted 6 lines · Alison Schofield
Quoted 4 lines · Rehas Sachdeva

This patch fixes the checkpatch.pl warning:
WARNING: Statements should start on a tabstop

Signed-off-by Rehas Sachdeva <[email protected]>
Quoted 8 lines

Hi Rehas,
This is a valid fix, but it was already submitted. You wouldn't have easily known that.

It's in iio git tree, not yet sync'd back to staging. Not sure what the take-away or advice on this situation is.

Greg?

I was behind in syncing up with the iio tree, that's now taken care of, sorry.

greg k-h

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#4 lore raw
Quoted 5 lines · Lars-Peter Clausen

Hi,

Thanks for the patch. Somebody else already send a patch for this a few weeks ago and the issue is no longer present in the IIO development tree.

Hi,

Thanks for letting me know. I'll take care next time.

Quoted 3 lines

One comment on the subject line, it should include the driver name, e.g. like "staging: iio: sca3000: ...". Otherwise looks good.

Noted. Thank you.

Rehas

Quoted 26 lines

- Lars

Quoted 22 lines · Rehas Sachdeva

This patch fixes the checkpatch.pl warning:
WARNING: Statements should start on a tabstop

Signed-off-by Rehas Sachdeva <[email protected]>
---
 drivers/staging/iio/accel/sca3000_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/accel/sca3000_core.c +1 -1
index b5625f5..61f3241 100644
@@ -412,7 +412,7 @@ static const struct iio_event_spec sca3000_event = {
 		},						\
 		.event_spec = &sca3000_event,			\
 		.num_event_specs = 1,				\
-	 }
+	}
 
 static const struct iio_chan_spec sca3000_channels[] = {
 	SCA3000_CHAN(0, IIO_MOD_X),

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#6 lore raw
Quoted 27 lines · Hartmut Knaack

Hi,
additional to Lars-Peters comment, you would normally CC the linux-iio mailing list.
Thanks,

Hartmut

Rehas Sachdeva schrieb am 14.09.2016 um 19:29:

Quoted 19 lines

This patch fixes the checkpatch.pl warning:
WARNING: Statements should start on a tabstop

Signed-off-by Rehas Sachdeva <[email protected]>
---
 drivers/staging/iio/accel/sca3000_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/iio/accel/sca3000_core.c +1 -1
index b5625f5..61f3241 100644
@@ -412,7 +412,7 @@ static const struct iio_event_spec sca3000_event = {
 		},						\
 		.event_spec = &sca3000_event,			\
 		.num_event_specs = 1,				\
-	 }
+	}
Quoted 4 lines

drivers/staging/iio/accel/sca3000_core.c static const struct iio_event_spec sca3000_event = { · line 418

Quoted 3 lines
drivers/staging/iio/accel/sca3000_core.c +0 -0
 static const struct iio_chan_spec sca3000_channels[] = {
 	SCA3000_CHAN(0, IIO_MOD_X),

Hi,
Point Noted. Thanks a lot.

Rehas