Skip to contentSkip to conversation

staging: android ion/hisi: fix dependencies

PATCH In review Arnd Bergmann 3 participants 3 messages Sep 15, 2016 – Sep 16, 2016 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: android ion/hisi: fix dependencies

The newly added Hi6220 Ion code fails to build when the ION_OF helpers are not present:

drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function `hi6220_ion_remove':
hi6220_ion.c:(.text.hi6220_ion_remove+0x4c): undefined reference to ion_destroy_platform_data' drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function hi6220_ion_probe':
hi6220_ion.c:(.text.hi6220_ion_probe+0x5c): undefined reference to ion_parse_dt' hi6220_ion.c:(.text.hi6220_ion_probe+0xf8): undefined reference to ion_destroy_platform_data'

This selects the symbol when needed.

Fixes 2b40182a19bc ("staging: android: ion: Add ion driver for Hi6220 SoC platform")
---
 drivers/staging/android/ion/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/android/ion/Kconfig +1 -0
index 94105544feef..c8fb4134c55d 100644
@@ -36,6 +36,7 @@ config ION_TEGRA
 config ION_HISI
 	tristate "Ion for Hisilicon"
 	depends on ARCH_HISI && ION
+	select ION_OF
 	help
 	  Choose this option if you wish to use ion on Hisilicon Platform.
 
Signature · 1 line
2.9.0
Acked-by on v1 1/1
#1 lore raw
Quoted 11 lines · Arnd Bergmann

The newly added Hi6220 Ion code fails to build when the ION_OF helpers are not present:

drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function `hi6220_ion_remove':
hi6220_ion.c:(.text.hi6220_ion_remove+0x4c): undefined reference to ion_destroy_platform_data' drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function hi6220_ion_probe':
hi6220_ion.c:(.text.hi6220_ion_probe+0x5c): undefined reference to ion_parse_dt' hi6220_ion.c:(.text.hi6220_ion_probe+0xf8): undefined reference to ion_destroy_platform_data'

This selects the symbol when needed.

Quoted 19 lines
Fixes 2b40182a19bc ("staging: android: ion: Add ion driver for Hi6220 SoC platform")
---
 drivers/staging/android/ion/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/android/ion/Kconfig +1 -0
index 94105544feef..c8fb4134c55d 100644
@@ -36,6 +36,7 @@ config ION_TEGRA
 config ION_HISI
 	tristate "Ion for Hisilicon"
 	depends on ARCH_HISI && ION
+	select ION_OF
 	help
 	  Choose this option if you wish to use ion on Hisilicon Platform.
 
Reviewed-by
#2 lore raw
Quoted 16 lines · Laura Abbott
Quoted 15 lines · Arnd Bergmann

The newly added Hi6220 Ion code fails to build when the ION_OF helpers are not present:

drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function `hi6220_ion_remove':
hi6220_ion.c:(.text.hi6220_ion_remove+0x4c): undefined reference to ion_destroy_platform_data' drivers/staging/android/ion/hisilicon/hi6220_ion.o: In function hi6220_ion_probe':
hi6220_ion.c:(.text.hi6220_ion_probe+0x5c): undefined reference to ion_parse_dt' hi6220_ion.c:(.text.hi6220_ion_probe+0xf8): undefined reference to ion_destroy_platform_data'

Quoted 5 lines
Quoted 2 lines

This selects the symbol when needed.

Quoted 23 lines
Quoted 22 lines
Fixes 2b40182a19bc ("staging: android: ion: Add ion driver for Hi6220 SoC

platform")

---
 drivers/staging/android/ion/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/android/ion/Kconfig +1 -0
index 94105544feef..c8fb4134c55d 100644
@@ -36,6 +36,7 @@ config ION_TEGRA
 config ION_HISI
        tristate "Ion for Hisilicon"
        depends on ARCH_HISI && ION
+       select ION_OF
        help
          Choose this option if you wish to use ion on Hisilicon Platform.