Expose verbose flag on subvolume delete
PATCH 1/1 Expose verbose flag on subvolume delete
Exposing the verbose flag that already had the logic for verbose output
Vincent Batts (1):
btrfs-progs: subvolume verbose delete flag
cmds-subvolume.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.9.0
PATCH 1/1 btrfs-progs: subvolume verbose delete flag
There was already the logic for verbose output, but the flag parsing did not include it.
--- cmds-subvolume.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
cmds-subvolume.c +3 -1
@@ -245,6 +245,7 @@ static const char * const cmd_subvol_delete_usage[] = {"" ,"-c|--commit-after wait for transaction commit at the end of the operation" ,"-C|--commit-each wait for transaction commit after deleting each subvolume" , +"-v|--verbose verbose output of operations" , NULL };
@@ -267,10 +268,11 @@ static int cmd_subvol_delete(int argc, char **argv)static const struct option long_options[] = { {"commit-after" , no_argument,NULL ,'c' },/* commit mode 1 */ {"commit-each" , no_argument,NULL ,'C' },/* commit mode 2 */ + {"verbose" , no_argument,NULL ,'v' }, {NULL ,0 ,NULL ,0 } }; - c =getopt_long (argc, argv,"cC" , long_options,NULL ); + c =getopt_long (argc, argv,"cCv" , long_options,NULL );if (c <0 )break ;
Signature · 1 line
2.9.0
David Sterba
AppliedRe: [PATCH] btrfs-progs: subvolume verbose delete flag
Quoted 4 lines · Vincent Batts
There was already the logic for verbose output, but the flag parsing did not include it.
Signed-off-by Vincent Batts <[email protected]>
Applied, thanks. I wonder where the original argument got lost. In the commit 2ed161bd281beca29feebebbc8c4227cc6e918c3 it to added to getopt but inside cmd_subvol_create. I'll fix it as well.
Re: [PATCH] btrfs-progs: subvolume verbose delete flag
Quoted 3 lines · David Sterba
Applied, thanks. I wonder where the original argument got lost. In the commit
2ed161bd281beca29feebebbc8c4227cc6e918c3it to added to getopt but insidecmd_subvol_create. I'll fix it as well.
Not sure. I found it while investigating feasibility of adding a flag to recursively delete subvolumes.
Which, do you have particular feelings about recursive deletes?