i2c: meson: add gxbb compatible string

From: Neil Armstrong <[email protected]>

Signed-off-by Neil Armstrong <[email protected]>

Signed-off-by Jerome Brunet <[email protected]>

---
 drivers/i2c/busses/i2c-meson.c | 1 +
 1 file changed, 1 insertion(+)

drivers/i2c/busses/i2c-meson.c +1 -0

index 76e28980904f..30977e31cd98 100644
@@ -473,6 +473,7 @@ static int meson_i2c_remove(struct platform_device *pdev)
 
 static const struct of_device_id meson_i2c_match[] = {
 	{ .compatible = "amlogic,meson6-i2c" },
+	{ .compatible = "amlogic,meson-gxbb-i2c" },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, meson_i2c_match);

From: Neil Armstrong <[email protected]>

Signed-off-by Neil Armstrong <[email protected]>

Signed-off-by Jerome Brunet <[email protected]>

---
 Documentation/devicetree/bindings/i2c/i2c-meson.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Documentation/devicetree/bindings/i2c/i2c-meson.txt +1 -1

index 682f9a6f766e..386357d1aab0 100644
@@ -1,7 +1,7 @@
 Amlogic Meson I2C controller
 
 Required properties:
- - compatible: must be "amlogic,meson6-i2c"
+ - compatible: must be "amlogic,meson6-i2c" or "amlogic,meson-gxbb-i2c"
  - reg: physical address and length of the device registers
  - interrupts: a single interrupt specifier
  - clocks: clock for the device

This patchset adds a specific compatible string in the Meson I2C driver for the Amlogic Meson gxbb SoC.

Other patch series (pinctrl and device tree) are being sent to complete the i2c support on meson gxbb

Neil Armstrong (2):
i2c: meson: add gxbb compatible string
dt-bindings: i2c-meson: add gxbb compatible string

Quoted 3 lines · Jerome Brunet

This patchset adds a specific compatible string in the Meson I2C driver for the Amlogic Meson gxbb SoC.

Quoted 6 lines

Other patch series (pinctrl and device tree) are being sent to complete the i2c support on meson gxbb

Neil Armstrong (2):
i2c: meson: add gxbb compatible string
dt-bindings: i2c-meson: add gxbb compatible string

Squashed both patches and applied to for-next, thanks!

Quoted 11 lines · Wolfram Sang

Quoted 9 lines · Jerome Brunet

This patchset adds a specific compatible string in the Meson I2C driver for the Amlogic Meson gxbb SoC.

Other patch series (pinctrl and device tree) are being sent to complete the i2c support on meson gxbb

Neil Armstrong (2):
i2c: meson: add gxbb compatible string
dt-bindings: i2c-meson: add gxbb compatible string

Quoted 1 line

Squashed both patches and applied to for-next, thanks!

Please don't squash. We ask people to split DT bindings for a reason being reviews and bindings may not go thru subsystem maintainers in the future. It also makes it harder to find things in the archives or patchwork (as does maintainer fixups of subject lines).

Quoted 12 lines · Rob Herring

Quoted 11 lines · Wolfram Sang

Quoted 9 lines · Jerome Brunet

This patchset adds a specific compatible string in the Meson I2C driver for the Amlogic Meson gxbb SoC.

Other patch series (pinctrl and device tree) are being sent to complete the i2c support on meson gxbb

Neil Armstrong (2):
i2c: meson: add gxbb compatible string
dt-bindings: i2c-meson: add gxbb compatible string

Quoted 6 lines

Quoted 1 line

Squashed both patches and applied to for-next, thanks!

Please don't squash. We ask people to split DT bindings for a reason being reviews and bindings may not go thru subsystem maintainers in the future. It also makes it harder to find things in the archives or patchwork (as does maintainer fixups of subject lines).

I intentionally don't ask people to send me the patches squashed. So, you will have them seperate in patchwork et al. I only squash them just before commiting to my tree. That's because I found that when digging through git history, it is much more convenient to have all the information in one commit.

Quoted 6 lines

I intentionally don't ask people to send me the patches squashed. So, you will have them seperate in patchwork et al. I only squash them just before commiting to my tree. That's because I found that when digging through git history, it is much more convenient to have all the information in one commit.

If git history was the only thing that mattered, then that would be fine. But it is not. Maintainers should apply what's on the list. Period.

Quoted 7 lines

Quoted 6 lines

I intentionally don't ask people to send me the patches squashed. So, you will have them seperate in patchwork et al. I only squash them just before commiting to my tree. That's because I found that when digging through git history, it is much more convenient to have all the information in one commit.

Quoted 3 lines

If git history was the only thing that mattered, then that would be fine. But it is not. Maintainers should apply what's on the list. Period.

Huh? If you would *ask* me to stop squashing, I am listening to reasons.

If you want to force arbitrary rules on me, I am not. There are reasons where squashing/modifying patches makes more sense compared to forcing the author to resend. DTS bindings may not be one, we can discuss that. But that rule without allowing exceptions seems impractical to me.

I did state some reasons previously. Consistent rules for submitters of DT bindings and being able to trace history beyond git. Now, I guess you aren't changing the rules, but you probably aren't requesting people to split DT bindings either? You might not be aware, but we also generate a DT only tree with git-filter-branch[1] for non-kernel projects to use bindings and dts files. For that, sure they will only get the DT binding part of it, but what commit text do they get? Finally, DT maintainer acks (which from me is a review really) apply to the bindings only. Sometimes I review the drivers, but not often. So I would like the git history of my reviews to be accurate in terms of what I actually reviewed.