Skip to contentSkip to conversation

breakpad: enable for uClibc

PATCH New gustavo.zacarias at free-electrons.com 2 participants 2 messages Sep 15, 2016 – Sep 16, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 breakpad: enable for uClibc

From: Gustavo Zacarias <[email protected]>

There's nothing holding it off for uClibc-based toolchains so enable it.

---
 Config.in                         | 3 ++-
 package/google-breakpad/Config.in | 8 +++++---
 2 files changed, 7 insertions(+), 4 deletions(-)
Config.in +2 -1
index e614c8f..f3b6649 100644
@@ -553,7 +553,8 @@ config BR2_GOOGLE_BREAKPAD_ENABLE
 	bool "Enable google-breakpad support"
 	select BR2_PACKAGE_GOOGLE_BREAKPAD
 	depends on BR2_INSTALL_LIBSTDCPP
-	depends on BR2_TOOLCHAIN_USES_GLIBC
+	depends on BR2_USE_WCHAR
+	depends on (BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC)
 	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
 	help
 	  This option will enable the use of google breakpad, a library
package/google-breakpad/Config.in +5 -3
index 7b8eeb1..06895af 100644
@@ -6,7 +6,8 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
 config BR2_PACKAGE_GOOGLE_BREAKPAD
 	bool "google-breakpad"
 	depends on BR2_INSTALL_LIBSTDCPP
-	depends on BR2_TOOLCHAIN_USES_GLIBC
+	depends on BR2_USE_WCHAR
+	depends on (BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC)
 	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
 	help
 	  Google-Breakpad is a library and tool suite that allows you
@@ -29,6 +30,7 @@ config BR2_PACKAGE_GOOGLE_BREAKPAD
 
 	  http://code.google.com/p/google-breakpad/
 
-comment "google-breakpad requires a glibc toolchain w/ C++ enabled"
+comment "google-breakpad requires a glibc or uClibc toolchain w/ wchar, C++ enabled"
 	depends on BR2_PACKAGE_GOOGLE_BREAKPAD_ARCH_SUPPORTS
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_USES_GLIBC
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
+		!(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_UCLIBC)
Signature · 1 line
2.7.3
#1 lore raw

PATCH 1/1 breakpad: enable for uClibc

Hello,

Quoted 9 lines · gustavo.zacarias at free-electrons.com

From: Gustavo Zacarias <[email protected]>

There's nothing holding it off for uClibc-based toolchains so enable it.

---
 Config.in                         | 3 ++-
 package/google-breakpad/Config.in | 8 +++++---
 2 files changed, 7 insertions(+), 4 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com