Skip to contentSkip to conversation

musb: Export musb_root_disconnect for use in modules

PATCH Superseded Hans de Goede 3 participants 6 messages Sep 16, 2016 – Sep 17, 2016

Subsystems (2)
USB MUSB multipoint high speed dual-role controller

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Hans de Goede

author
#0 lore raw

PATCH 1/1 musb: Export musb_root_disconnect for use in modules

Export musb_root_disconnect for use in modules, so that musb glue code build as module can use it.

Signed-off-by Hans de Goede <[email protected]>
---
 drivers/usb/musb/musb_virthub.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/musb/musb_virthub.c +1 -0
index fe08e77..61b5f1c 100644
@@ -245,6 +245,7 @@ void musb_root_disconnect(struct musb *musb)
 			usb_otg_state_string(musb->xceiv->otg->state));
 	}
 }
+EXPORT_SYMBOL_GPL(musb_root_disconnect);
 
 
 /*---------------------------------------------------------------------*/
Signature · 1 line
2.9.3
maintainer
#1 lore raw

PATCH 1/1 musb: Export musb_root_disconnect for use in modules

Quoted 13 lines · Hans de Goede

Export musb_root_disconnect for use in modules, so that musb glue code build as module can use it.

Signed-off-by Hans de Goede <[email protected]>
---
 drivers/usb/musb/musb_virthub.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/musb/musb_virthub.c +0 -0
index fe08e77..61b5f1c 100644

drivers/usb/musb/musb_virthub.c void musb_root_disconnect(struct musb *musb) · line 251

Quoted 7 lines
drivers/usb/musb/musb_virthub.c +1 -0
@@ -245,6 +245,7 @@ void musb_root_disconnect(struct musb *musb)
 			usb_otg_state_string(musb->xceiv->otg->state));
 	}
 }
+EXPORT_SYMBOL_GPL(musb_root_disconnect);
 
 
 /*---------------------------------------------------------------------*/

Does this fix a build error somehow? Who reported it?

#2 lore raw

PATCH 1/1 musb: Export musb_root_disconnect for use in modules

Quoted 5 lines · Greg Kroah-Hartman
Quoted 1 line · Hans de Goede

+EXPORT_SYMBOL_GPL(musb_root_disconnect);

Does this fix a build error somehow? Who reported it?

Yes, the sunxi driver uses this symbol and the build bots reported it
yesterday.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160916/1c94a40d/attachment-0001.sig>

maintainer
#3 lore raw

PATCH 1/1 musb: Export musb_root_disconnect for use in modules

Quoted 9 lines · Mark Brown
Quoted 5 lines · Greg Kroah-Hartman
Quoted 1 line · Hans de Goede

+EXPORT_SYMBOL_GPL(musb_root_disconnect);

Does this fix a build error somehow? Who reported it?

Yes, the sunxi driver uses this symbol and the build bots reported it yesterday.

then all of that should have been in this patch :(

So much for me trying to be subtle...

author
#4 lore raw

PATCH 1/1 musb: Export musb_root_disconnect for use in modules

Hi,

Quoted 6 lines · Greg Kroah-Hartman
Quoted 5 lines · Mark Brown
Quoted 3 lines · Greg Kroah-Hartman
Quoted 1 line · Hans de Goede

+EXPORT_SYMBOL_GPL(musb_root_disconnect);

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Does this fix a build error somehow? Who reported it?

Yes, the sunxi driver uses this symbol and the build bots reported it yesterday.

then all of that should have been in this patch :(

So much for me trying to be subtle...

Sorry, you're right, I'll add a Fixes tag, and I'll mention this fixes a buildbot reported error too.

I'll do a v2 with this right away.

For the next time, is there any official format to mention the buildbot report or some such ?

Regards,

Hans

maintainer
#5 lore raw

PATCH 1/1 musb: Export musb_root_disconnect for use in modules

Quoted 18 lines · Hans de Goede

Hi,

Quoted 6 lines · Greg Kroah-Hartman
Quoted 5 lines · Mark Brown
Quoted 3 lines · Greg Kroah-Hartman
Quoted 1 line · Hans de Goede

+EXPORT_SYMBOL_GPL(musb_root_disconnect);

Quoted 8 lines
Quoted 4 lines
Quoted 1 line

Does this fix a build error somehow? Who reported it?

Yes, the sunxi driver uses this symbol and the build bots reported it yesterday.

then all of that should have been in this patch :(

So much for me trying to be subtle...

Quoted 7 lines

Sorry, you're right, I'll add a Fixes tag, and I'll mention this fixes a buildbot reported error too.

I'll do a v2 with this right away.

For the next time, is there any official format to mention the buildbot report or some such ?

like normal:
"Reported-by: ...."