php: bump 7.0.11
PATCH 1/1 php: bump 7.0.11
See the attached patch.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160916/ab3181d6/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-php-bump-7.0.11.patch
Type: text/x-patch
Size: 1360 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160916/ab3181d6/attachment.bin>
PATCH 1/1 php: bump 7.0.11
Hello,
Quoted 1 line · Tatsuyuki Ishi
See the attached patch.
Thanks for this patch. However, we prefer to have patches "inline" rather as attached files, as it makes the review easier. We recommend to use "git send-email" to send patches.
In addition, your patches does not apply. Your change to php.hash is:
# From http://php.net/downloads.php
-sha256 970c322ba3e472cb0264b8ba9d4d92e87918da5d0cca53c4aba2a70545b8626d php-7.0.9.tar.xz +sha256 d4cccea8da1d27c11b89386f8b8e95692ad3356610d571253d00ca67d524c735 php-7.0.11.tar.xz sha256 44cab15d57b2fb8fa916ff9291059a34b0c3fa99298c2b08a5082f334613753a yaml-2.0.0RC8.tgz sha256 bb13da909a7a7ae1f9e499166103a2d24628993238ce03a8aae3eaa492c0b736 pthreads-3.1.6.tgz sha256 dc09445c0395bf21d06f21af64697d95244e1a06baade88afa7e07ef75d9b180 Weakref-0.3.2.tgz
But this does not match the php.hash in current Buildroot master, which doesn't have any reference to the yaml, pthreads or Weakref tarballs.
Could you rework your patch and send an updated version?
Thanks a lot!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 php: bump 7.0.11
Thank you, the following is the updated patch.
From: Tatsuyuki Ishi <[email protected]>
--- package/php/php.hash | 2 +- package/php/php.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
package/php/php.hash +0 -1
@@ -1,2 +1,2 @@ # From http://php.net/downloads.php -sha256 970c322ba3e472cb0264b8ba9d4d92e87918da5d0cca53c4aba2a70545b8626d
php-7.0.9.tar.xz
+sha256 d4cccea8da1d27c11b89386f8b8e95692ad3356610d571253d00ca67d524c735 php-7.0.11.tar.xz
package/php/php.mk +0 -0
@@ -4,7 +4,7 @@ # ###########################################################
#####################
-PHP_VERSION = 7.0.9
+PHP_VERSION = 7.0.11
PHP_SITE = http://www.php.net/distributions
PHP_SOURCE = php-$(PHP_VERSION).tar.xz
PHP_INSTALL_STAGING = YES
--
2.9.3
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160917/864f35fa/attachment.html>
PATCH 1/1 php: bump 7.0.11
Hello,
Quoted 1 line · Tatsuyuki Ishi
Thank you, the following is the updated patch.
Thanks. But this patch also cannot be applied, for two reasons:
- The changelog part of the message such as "Thank you, the following..." should not be part of the commit log, but instead should be below the "---" so that it does not get integrated in the Git history when the patch is applied.
- Since you haven't used git send-email, your patch is line-wrapped (i.e long lines are wrapped), so it cannot be applied.
Could you rework your patch to take into account those comments?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
PATCH 1/1 php: bump 7.0.11
From: Tatsuyuki Ishi <[email protected]>
--- package/php/php.hash | 2 +- package/php/php.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
package/php/php.hash +0 -1
@@ -1,2 +1,2 @@ # From http://php.net/downloads.php -sha256 970c322ba3e472cb0264b8ba9d4d92e87918da5d0cca53c4aba2a70545b8626d
php-7.0.9.tar.xz
+sha256 d4cccea8da1d27c11b89386f8b8e95692ad3356610d571253d00ca67d524c735
php-7.0.11.tar.xz
package/php/php.mk +1 -1
@@ -4,7 +4,7 @@ # ################################################################################ -PHP_VERSION = 7.0.9 +PHP_VERSION = 7.0.11 PHP_SITE = http://www.php.net/distributions PHP_SOURCE = php-$(PHP_VERSION).tar.xz PHP_INSTALL_STAGING = YES
Signature · 4 lines
2.9.3 v3, I think it's finally proper, sending in plain text.
PATCH 1/1 php: bump 7.0.11
Hello,
Quoted 2 lines · Tatsuyuki Ishi
From: Tatsuyuki Ishi <[email protected]>
Missing Signed-off-by line.
Review
Quoted 6 lines
(quoted diff) +1
-1@@ -1,2 +1,2 @@ # From http://php.net/downloads.php -sha256 970c322ba3e472cb0264b8ba9d4d92e87918da5d0cca53c4aba2a70545b8626d php-7.0.9.tar.xz +sha256 d4cccea8da1d27c11b89386f8b8e95692ad3356610d571253d00ca67d524c735 php-7.0.11.tar.xz
You're still not using git send-email, so this patch has been rewrapped by your e-mail client.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com