Skip to contentSkip to conversation

blktrace: add dependency on NPTL

PATCH New Rahul Bedarkar 2 participants 3 messages Sep 16, 2016 – Sep 17, 2016

lore
Share & tools
lore

Rahul Bedarkar

author
#0 lore raw

PATCH 1/2 blktrace: add dependency on NPTL

blkiomon.c assumes that clock_nanosleep() is always available. But it is only available with NPTL. Since it unconditionally uses it, we add dependency on NPTL.

Fixes:
http://autobuild.buildroot.net/results/c87/c87cd4a7b0bed938506bcf7e88d4cda60e28e6e5/

Signed-off-by Rahul Bedarkar <[email protected]>
---
 package/blktrace/Config.in | 5 +++++
 1 file changed, 5 insertions(+)
package/blktrace/Config.in +5 -0
index 38c0947..684157c 100644
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_BLKTRACE
 	bool "blktrace"
 	depends on BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS
+	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()
 	select BR2_PACKAGE_LIBAIO
 	help
 	  blktrace is a block layer IO tracing mechanism which provides

@@ -8,3 +9,7 @@ config BR2_PACKAGE_BLKTRACE
 	  up to user space.
 
 	  http://git.kernel.dk/?p=blktrace.git;a=summary
+
+comment "blktrace needs a toolchain w/ NPTL"
+	depends on BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS
+	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
Signature · 1 line
2.6.2
author
#1 lore raw

PATCH 2/2 blktrace: needs MMU support

iowatcher/main.c uses system() which uses fork().

Signed-off-by Rahul Bedarkar <[email protected]>
---
 package/blktrace/Config.in | 2 ++
 1 file changed, 2 insertions(+)
package/blktrace/Config.in +2 -0
index 684157c..dedfa03 100644
@@ -2,6 +2,7 @@ config BR2_PACKAGE_BLKTRACE
 	bool "blktrace"
 	depends on BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # clock_nanosleep()
+	depends on BR2_USE_MMU # system()
 	select BR2_PACKAGE_LIBAIO
 	help
 	  blktrace is a block layer IO tracing mechanism which provides

@@ -11,5 +12,6 @@ config BR2_PACKAGE_BLKTRACE
 	  http://git.kernel.dk/?p=blktrace.git;a=summary
 
 comment "blktrace needs a toolchain w/ NPTL"
+	depends on BR2_USE_MMU
 	depends on BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
Signature · 1 line
2.6.2
#2 lore raw

PATCH 1/2 blktrace: add dependency on NPTL

In reply to Rahul Bedarkar

Hello,

Quoted 11 lines · Rahul Bedarkar

blkiomon.c assumes that clock_nanosleep() is always available. But it is only available with NPTL. Since it unconditionally uses it, we add dependency on NPTL.

Fixes:
http://autobuild.buildroot.net/results/c87/c87cd4a7b0bed938506bcf7e88d4cda60e28e6e5/

Signed-off-by Rahul Bedarkar <[email protected]>
---
 package/blktrace/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

Both applied, thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com