avr32: fix 'undefined reference to `___copy_from_user'
PATCH 1/1 avr32: fix 'undefined reference to `___copy_from_user'
avr32 builds fail with:
arch/avr32/kernel/built-in.o: In function `arch_ptrace':
(.text+0x650): undefined reference to ___copy_from_user' arch/avr32/kernel/built-in.o:(___ksymtab+___copy_from_user+0x0): undefined reference to ___copy_from_user'kernel/built-in.o: In function `proc_doulongvec_ms_jiffies_minmax':
(.text+0x5dd8): undefined reference to ___copy_from_user' kernel/built-in.o: In function proc_dointvec_minmax_sysadmin':
sysctl.c:(.text+0x6174): undefined reference to ___copy_from_user' kernel/built-in.o: In function ptrace_has_cap':
ptrace.c:(.text+0x69c0): undefined reference to ___copy_from_user' kernel/built-in.o:ptrace.c:(.text+0x6b90): more undefined references to ___copy_from_user' follow
--- arch/avr32/lib/copy_user.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/avr32/lib/copy_user.S +2 -2
@@ -23,8 +23,8 @@ */ .text .align 1 - .global copy_from_user - .type copy_from_user, @function + .global ___copy_from_user + .type ___copy_from_user, @function ___copy_from_user: branch_if_kernel r8, __copy_user ret_if_privileged r8, r11, r10, r10
Signature · 1 line
2.5.0
Quoted 15 lines · Guenter Roeck
avr32 builds fail with:
arch/avr32/kernel/built-in.o: In function `arch_ptrace':
(.text+0x650): undefined reference to___copy_from_user' arch/avr32/kernel/built-in.o:(___ksymtab+___copy_from_user+0x0): undefined reference to___copy_from_user'kernel/built-in.o: In function `proc_doulongvec_ms_jiffies_minmax':
(.text+0x5dd8): undefined reference to___copy_from_user' kernel/built-in.o: In functionproc_dointvec_minmax_sysadmin':
sysctl.c:(.text+0x6174): undefined reference to___copy_from_user' kernel/built-in.o: In functionptrace_has_cap':
ptrace.c:(.text+0x69c0): undefined reference to___copy_from_user' kernel/built-in.o:ptrace.c:(.text+0x6b90): more undefined references to___copy_from_user' follow
Quoted 3 lines
Fixes 8630c32275ba ("avr32: fix copy_from_user()")Cc Al Viro <[email protected]>Signed-off-by Guenter Roeck <[email protected]>
Right, gmail loves HTML. Let me try this again...
Thanks!
Quoted 20 lines · Håvard Skinnemoen
Quoted 15 lines · Guenter Roeck
avr32 builds fail with:
arch/avr32/kernel/built-in.o: In function `arch_ptrace':
(.text+0x650): undefined reference to___copy_from_user' arch/avr32/kernel/built-in.o:(___ksymtab+___copy_from_user+0x0): undefined reference to___copy_from_user'kernel/built-in.o: In function `proc_doulongvec_ms_jiffies_minmax':
(.text+0x5dd8): undefined reference to___copy_from_user' kernel/built-in.o: In functionproc_dointvec_minmax_sysadmin':
sysctl.c:(.text+0x6174): undefined reference to___copy_from_user' kernel/built-in.o: In functionptrace_has_cap':
ptrace.c:(.text+0x69c0): undefined reference to___copy_from_user' kernel/built-in.o:ptrace.c:(.text+0x6b90): more undefined references to___copy_from_user' followQuoted 3 lines
Fixes 8630c32275ba ("avr32: fix copy_from_user()")Cc Al Viro <[email protected]>Signed-off-by Guenter Roeck <[email protected]>
Quoted 6 lines
Right, gmail loves HTML. Let me try this again...
Thanks!
You are welcome ... I'll wait until tomorrow to see if Al wants to send this patch and the patch for the openrisc failure to Linus; if I don't hear back, I'll do it myself.
Guenter
Hans-Christian Noren Egtvedt
Acked-byQuoted 17 lines · Guenter Roeck
Quoted 16 lines · Håvard Skinnemoen
Quoted 15 lines · Guenter Roeck
avr32 builds fail with:
arch/avr32/kernel/built-in.o: In function `arch_ptrace':
(.text+0x650): undefined reference to___copy_from_user' arch/avr32/kernel/built-in.o:(___ksymtab+___copy_from_user+0x0): undefined reference to___copy_from_user'kernel/built-in.o: In function `proc_doulongvec_ms_jiffies_minmax':
(.text+0x5dd8): undefined reference to___copy_from_user' kernel/built-in.o: In functionproc_dointvec_minmax_sysadmin':
sysctl.c:(.text+0x6174): undefined reference to___copy_from_user' kernel/built-in.o: In functionptrace_has_cap':
ptrace.c:(.text+0x69c0): undefined reference to___copy_from_user' kernel/built-in.o:ptrace.c:(.text+0x6b90): more undefined references to___copy_from_user' follow
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
Fixes 8630c32275ba ("avr32: fix copy_from_user()")Cc Al Viro <[email protected]>Signed-off-by Guenter Roeck <[email protected]>Right, gmail loves HTML. Let me try this again...
Quoted 5 lines
Quoted 2 lines
Thanks!
You are welcome ... I'll wait until tomorrow to see if Al wants to send this patch and the patch for the openrisc failure to Linus; if I don't hear back, I'll do it myself.
Thanks, I have no other fixes for AVR32. But let me know if you want me to push it through linux-avr32.
Why did not Al add Håvard/me to CC in the first place? That way we might have avoided this build break in the first place?
Signature · 2 lines
Best regards, Hans-Christian Noren Egtvedt
Quoted 28 lines · Hans-Christian Noren Egtvedt
Quoted 17 lines · Guenter Roeck
Quoted 16 lines · Håvard Skinnemoen
Quoted 15 lines · Guenter Roeck
avr32 builds fail with:
arch/avr32/kernel/built-in.o: In function `arch_ptrace':
(.text+0x650): undefined reference to___copy_from_user' arch/avr32/kernel/built-in.o:(___ksymtab+___copy_from_user+0x0): undefined reference to___copy_from_user'kernel/built-in.o: In function `proc_doulongvec_ms_jiffies_minmax':
(.text+0x5dd8): undefined reference to___copy_from_user' kernel/built-in.o: In functionproc_dointvec_minmax_sysadmin':
sysctl.c:(.text+0x6174): undefined reference to___copy_from_user' kernel/built-in.o: In functionptrace_has_cap':
ptrace.c:(.text+0x69c0): undefined reference to___copy_from_user' kernel/built-in.o:ptrace.c:(.text+0x6b90): more undefined references to___copy_from_user' followQuoted 7 lines
Quoted 7 lines
Quoted 3 lines
Fixes 8630c32275ba ("avr32: fix copy_from_user()")Cc Al Viro <[email protected]>Signed-off-by Guenter Roeck <[email protected]>Right, gmail loves HTML. Let me try this again...
Quoted 9 lines
Quoted 5 lines
Quoted 2 lines
Thanks!
You are welcome ... I'll wait until tomorrow to see if Al wants to send this patch and the patch for the openrisc failure to Linus; if I don't hear back, I'll do it myself.
Thanks, I have no other fixes for AVR32. But let me know if you want me to push it through linux-avr32.
I have another related fix (for openrisc), so let me just send both. I'll do that in an hour or so.
Thanks,
Guenter
A message that is not in the archive (sent off-list or not yet received): CACiLriRCzX41SWh92cVSjDTKJEDAe+boMNy9JRHp5G9owe48Xw@mail.gmail.com
Quoted 17 lines · Håvard Skinnemoen
Quoted 15 lines · Guenter Roeck
avr32 builds fail with:
arch/avr32/kernel/built-in.o: In function `arch_ptrace':
(.text+0x650): undefined reference to___copy_from_user' arch/avr32/kernel/built-in.o:(___ksymtab+___copy_from_user+0x0): undefined reference to___copy_from_user'kernel/built-in.o: In function `proc_doulongvec_ms_jiffies_minmax':
(.text+0x5dd8): undefined reference to___copy_from_user' kernel/built-in.o: In functionproc_dointvec_minmax_sysadmin':
sysctl.c:(.text+0x6174): undefined reference to___copy_from_user' kernel/built-in.o: In functionptrace_has_cap':
ptrace.c:(.text+0x69c0): undefined reference to___copy_from_user' kernel/built-in.o:ptrace.c:(.text+0x6b90): more undefined references to___copy_from_user' follow
Quoted 7 lines
Quoted 4 lines
Fixes 8630c32275ba ("avr32: fix copy_from_user()")Cc Al Viro <[email protected]>Signed-off-by Guenter Roeck <[email protected]>
Al, I assume you'll send this to Linus ?
Thanks,
Guenter