Staging: lustre: Convert array index from the loop bound to the loop index.
PATCH v4 1/1 Staging: lustre: Convert array index from the loop bound to the loop index.
Convert array index from the loop bound to the loop index.
The structure cl_env_percpu[NR_CPUS] has been initializing for each possible cpu (i.e 0 to i). During initialization if any error will occurred, the error handling code should uninitialize cl_env_percpu upto i. But currently unitialization is repeatedly done for the same cl_env_percpu[i] element. This does not seems to be correct.
Used below semantic patch to identify this issue:
@@
expression e1,e2,ar;
@@
for(e1 = 0; e1 < e2; e1++) { <...
ar[
- e2
+ e1
]
...> }
Signed-off-by Sandhya Bankar <[email protected]>
---
Changes in v4:
* Correcting file permission issue.
drivers/staging/lustre/lustre/obdclass/cl_object.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/lustre/lustre/obdclass/cl_object.c +1 -1
@@ -1000,7 +1000,7 @@ static int cl_env_percpu_init(void)* thus we must uninitialize up to i, the rest are undefined. */ for (j =0 ; j < i; j++) { - cle = &cl_env_percpu[i]; + cle = &cl_env_percpu[j];lu_context_exit (&cle->ce_ses);lu_context_fini (&cle->ce_ses);lu_env_fini (&cle->ce_lu);
Signature · 1 line
1.7.1