Skip to contentSkip to conversation

staging: wlan-ng: fixed parenthesis alignment

PATCH Superseded Juliana R 2 participants 2 messages Sep 19, 2016 Staging

v1 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Juliana R

author
#0 lore raw

PATCH 1/1 staging: wlan-ng: fixed parenthesis alignment

This patch aims to fix a checkpatch warning
caused by open parenthesis alignment.

Signed-off-by Juliana R <[email protected]>
---
 drivers/staging/wlan-ng/cfg80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wlan-ng/cfg80211.c +1 -1
index bed4672..f1d93b7 100644
@@ -661,7 +661,7 @@ void prism2_connect_result(struct wlandevice *wlandev, u8 failed)
 void prism2_disconnected(struct wlandevice *wlandev)
 {
 	cfg80211_disconnected(wlandev->netdev, 0, NULL,
-		0, false, GFP_KERNEL);
+			      0, false, GFP_KERNEL);
 }
 
 void prism2_roamed(struct wlandevice *wlandev)
Signature · 1 line
2.9.3
#1 lore raw
Quoted 2 lines · Juliana R

This patch aims to fix a checkpatch warning
caused by open parenthesis alignment.

"This patch aims to fix" is not useful. We know it is a patch, and "aims to fix" suggests that you have not succeeded in fixing the issue. It would be better to say what you did, eg Move arguments to the right to align them with the open parenthesis, as suggested by checkpatch.

Quoted 1 line
Signed-off-by Juliana R <[email protected]>

I guess there is more to your last name than R? You need to put your full name.

Thanks for the patch :)

julia

Quoted 27 lines
---
 drivers/staging/wlan-ng/cfg80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wlan-ng/cfg80211.c +1 -2
index bed4672..f1d93b7 100644
@@ -661,7 +661,7 @@ void prism2_connect_result(struct wlandevice *wlandev, u8 failed)
 void prism2_disconnected(struct wlandevice *wlandev)
 {
 	cfg80211_disconnected(wlandev->netdev, 0, NULL,
-		0, false, GFP_KERNEL);
+			      0, false, GFP_KERNEL);
 }
 
 void prism2_roamed(struct wlandevice *wlandev)
--

2.9.3

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160919195828.GA32755%40spock.
For more options, visit https://groups.google.com/d/optout.