drm: Fix typo in encoder docs
Subsystems (2)
PATCH 1/1 drm: Fix typo in encoder docs
Corrected typo in bridge and encoder comparison. Also, added a one-line encoder description from the previous documentation.
--- drivers/gpu/drm/drm_encoder.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)
drivers/gpu/drm/drm_encoder.c +9 -8
@@ -31,20 +31,21 @@* * Encoders represent the connecting element between the CRTC (as the overall * pixel pipeline, represented by struct &drm_crtc) and the connectors (as the -* generic sink entity, represented by struct &drm_connector). Encoders are -* objects exposed to userspace, originally to allow userspace to infer cloning -* and connector/CRTC restrictions. Unfortunately almost all drivers get this -* wrong, making the uabi pretty much useless. On top of that the exposed -* restrictions are too simple for todays hardware, and the recommend way to -* infer restrictions is by using the DRM_MODE_ATOMIC_TEST_ONLY flag for the -* atomic IOCTL. +* generic sink entity, represented by struct &drm_connector). An encoder takes +* pixel data from a CRTC and converts it to a format suitable for any attached +* connector. Encoders are objects exposed to userspace, originally to allow +* userspace to infer cloning and connector/CRTC restrictions. Unfortunately +* almost all drivers get this wrong, making the uabi pretty much useless. On +* top of that the exposed restrictions are too simple for today's hardware, and +* the recommended way to infer restrictions is by using the +* DRM_MODE_ATOMIC_TEST_ONLY flag for the atomic IOCTL. * * Otherwise encoders aren't used in the uapi at all (any modeset request from * userspace directly connects a connector with a CRTC), drivers are therefore * free to use them however they wish. Modeset helper libraries make strong use * of encoders to facilitate code sharing. But for more complex settings it is * usually better to move shared code into a separate &drm_bridge. Compared to -* encoders bridges also have the benefit of not being purely an internal +* encoders, bridges also have the benefit of being purely an internal * abstraction since they are not exposed to userspace at all. * * Encoders are initialized with drm_encoder_init() and cleaned up using
Signature · 6 lines
2.5.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: warning for drm: Fix typo in encoder docs
== Series Details ==
== Series Details ==
Series: drm: Fix typo in encoder docs
URL : https://patchwork.freedesktop.org/series/12666/
State : warning
== Summary ==
Series 12666v1 drm: Fix typo in encoder docs
https://patchwork.freedesktop.org/api/1.0/series/12666/revisions/1/mbox/
Test kms_pipe_crc_basic:
Subgroup read-crc-pipe-b-frame-sequence:
pass -> SKIP (fi-hsw-4770r)fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15 fi-bsw-n3050 total:244 pass:202 dwarn:0 dfail:0 fail:0 skip:42 fi-byt-n2820 total:244 pass:208 dwarn:0 dfail:0 fail:1 skip:35 fi-hsw-4770k total:244 pass:226 dwarn:0 dfail:0 fail:0 skip:18 fi-hsw-4770r total:244 pass:221 dwarn:0 dfail:0 fail:0 skip:23 fi-ilk-650 total:244 pass:183 dwarn:0 dfail:0 fail:1 skip:60 fi-ivb-3520m total:244 pass:219 dwarn:0 dfail:0 fail:0 skip:25 fi-ivb-3770 total:244 pass:207 dwarn:0 dfail:0 fail:0 skip:37 fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14 fi-skl-6700hq total:244 pass:221 dwarn:0 dfail:0 fail:1 skip:22 fi-skl-6700k total:244 pass:219 dwarn:1 dfail:0 fail:0 skip:24 fi-skl-6770hq total:244 pass:228 dwarn:1 dfail:0 fail:1 skip:14 fi-snb-2520m total:244 pass:208 dwarn:0 dfail:0 fail:0 skip:36 fi-snb-2600 total:244 pass:207 dwarn:0 dfail:0 fail:0 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_2557/
4c518aef024daa0223692124baa2d7399f54dd97 drm-intel-nightly: 2016y-09m-19d-20h-40m-51s UTC integration manifest 991a333 drm: Fix typo in encoder docs
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 7 lines · Dhinakaran Pandiyan
Corrected typo in bridge and encoder comparison. Also, added a one-line encoder description from the previous documentation.
Cc Daniel Vetter <[email protected]>Cc Archit Taneja <[email protected]>Signed-off-by Dhinakaran Pandiyan <[email protected]>
Thanks for spotting these and creating the patch, applied to drm-misc. -Daniel
Quoted 41 lines
--- drivers/gpu/drm/drm_encoder.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)drivers/gpu/drm/drm_encoder.c +9
-8@@ -31,20 +31,21 @@* * Encoders represent the connecting element between the CRTC (as the overall * pixel pipeline, represented by struct &drm_crtc) and the connectors (as the -* generic sink entity, represented by struct &drm_connector). Encoders are -* objects exposed to userspace, originally to allow userspace to infer cloning -* and connector/CRTC restrictions. Unfortunately almost all drivers get this -* wrong, making the uabi pretty much useless. On top of that the exposed -* restrictions are too simple for todays hardware, and the recommend way to -* infer restrictions is by using the DRM_MODE_ATOMIC_TEST_ONLY flag for the -* atomic IOCTL. +* generic sink entity, represented by struct &drm_connector). An encoder takes +* pixel data from a CRTC and converts it to a format suitable for any attached +* connector. Encoders are objects exposed to userspace, originally to allow +* userspace to infer cloning and connector/CRTC restrictions. Unfortunately +* almost all drivers get this wrong, making the uabi pretty much useless. On +* top of that the exposed restrictions are too simple for today's hardware, and +* the recommended way to infer restrictions is by using the +* DRM_MODE_ATOMIC_TEST_ONLY flag for the atomic IOCTL. * * Otherwise encoders aren't used in the uapi at all (any modeset request from * userspace directly connects a connector with a CRTC), drivers are therefore * free to use them however they wish. Modeset helper libraries make strong use * of encoders to facilitate code sharing. But for more complex settings it is * usually better to move shared code into a separate &drm_bridge. Compared to -* encoders bridges also have the benefit of not being purely an internal +* encoders, bridges also have the benefit of being purely an internal * abstraction since they are not exposed to userspace at all. * * Encoders are initialized with drm_encoder_init() and cleaned up using Signature · 1 line
2.5.0
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel