Skip to contentSkip to conversation

avr32: migrate exception table users off module.h and onto extable.h

PATCH In review Paul Gortmaker 2 participants 4 messages Sep 19, 2016 – Sep 20, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 avr32: migrate exception table users off module.h and onto extable.h

These files were only including module.h for exception table related functions. We've now separated that content out into its own file "extable.h" so now move over to that and avoid all the extra header content in module.h that we don't really need to compile these files.

One uses "print_modules" so that prevents us removing module.h in that case, however.

Cc Haavard Skinnemoen <[email protected]>
Cc Hans-Christian Egtvedt <[email protected]>

---

[see: https://lkml.org/lkml/2016/7/24/224 for additional context if needed]

 arch/avr32/kernel/traps.c | 3 ++-
 arch/avr32/mm/fault.c     | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)
arch/avr32/kernel/traps.c +2 -1
index 682b2478691a..eb4a3fcfbaff 100644
@@ -11,7 +11,8 @@
 #include <linux/init.h>
 #include <linux/kallsyms.h>
 #include <linux/kdebug.h>
-#include <linux/module.h>
+#include <linux/extable.h>
+#include <linux/module.h>	/* print_modules */
 #include <linux/notifier.h>
 #include <linux/sched.h>
 #include <linux/uaccess.h>
arch/avr32/mm/fault.c +1 -1
index a4b7edac8f10..b3977e9208a3 100644
@@ -10,7 +10,7 @@
  */
 
 #include <linux/mm.h>
-#include <linux/module.h>
+#include <linux/extable.h>
 #include <linux/pagemap.h>
 #include <linux/kdebug.h>
 #include <linux/kprobes.h>
Signature · 1 line
2.8.4
Acked-by on v1 1/1
#1 lore raw
Quoted 6 lines · Paul Gortmaker

These files were only including module.h for exception table related functions. We've now separated that content out into its own file "extable.h" so now move over to that and avoid all the extra header content in module.h that we don't really need to compile these files.

Quoted 6 lines

One uses "print_modules" so that prevents us removing module.h in that case, however.

Cc Haavard Skinnemoen <[email protected]>
Cc Hans-Christian Egtvedt <[email protected]>

Do you have a series of fixes like this, or would you like me to push it through linux-avr32?

Quoted 7 lines

---

[see: https://lkml.org/lkml/2016/7/24/224 for additional context if needed]

 arch/avr32/kernel/traps.c | 3 ++-
 arch/avr32/mm/fault.c     | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

<snipp diff>

Signature · 1 line
Best regards, Hans-Christian Noren Egtvedt
#2 lore raw
Quoted 10 lines · [Re: [PATCH] avr32: migrate exception table users off module.h and onto…
Quoted 9 lines · Paul Gortmaker

These files were only including module.h for exception table related functions. We've now separated that content out into its own file "extable.h" so now move over to that and avoid all the extra header content in module.h that we don't really need to compile these files.

One uses "print_modules" so that prevents us removing module.h in that case, however.

Quoted 8 lines
Quoted 3 lines
Cc Haavard Skinnemoen <[email protected]>
Cc Hans-Christian Egtvedt <[email protected]>

Do you have a series of fixes like this, or would you like me to push it through linux-avr32?

Please push it through avr32 ;I hope to get down to just the one (abandoned) m32r arch patch remaining.

THanks,
Paul.
--

Quoted 13 lines
Quoted 8 lines

---

[see: https://lkml.org/lkml/2016/7/24/224 for additional context if needed]

 arch/avr32/kernel/traps.c | 3 ++-
 arch/avr32/mm/fault.c     | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

<snipp diff>

Signature · 1 line
Best regards, Hans-Christian Noren Egtvedt
#3 lore raw
Quoted 16 lines · Paul Gortmaker
Quoted 14 lines · [Re: [PATCH] avr32: migrate exception table users off module.h and onto…
Quoted 12 lines · Paul Gortmaker

These files were only including module.h for exception table related functions. We've now separated that content out into its own file "extable.h" so now move over to that and avoid all the extra header content in module.h that we don't really need to compile these files.

One uses "print_modules" so that prevents us removing module.h in that case, however.

Cc Haavard Skinnemoen <[email protected]>
Cc Hans-Christian Egtvedt <[email protected]>
Quoted 7 lines
Quoted 4 lines

Do you have a series of fixes like this, or would you like me to push it through linux-avr32?

Please push it through avr32 ;I hope to get down to just the one (abandoned) m32r arch patch remaining.

Ack, lined up for next release.

<snipp>

Signature · 1 line
Best regards, Hans-Christian Noren Egtvedt