drm/amdgpu: avoid out of bounds access on array interrupt_status_offsets
Subsystems (2)
PATCH v2 1/1 drm/amdgpu: avoid out of bounds access on array interrupt_status_offsets
From: Colin Ian King <[email protected]>
The check for an out of bound index into array interrupt_status_offsets is off-by-one. Fix this and also don't compared to a hard coded array size but use adev->mode_info.num_hpd instead.
--- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c +1 -1
@@ -2782,7 +2782,7 @@ static int dce_v6_0_hpd_irq(struct amdgpu_device *adev,uint32_t disp_int, mask, int_control, tmp;unsigned hpd; -if (entry->src_data >6 ) { +if (entry->src_data >= adev->mode_info.num_hpd) {DRM_DEBUG ("Unhandled interrupt: %d %d\n" , entry->src_id, entry->src_data);return 0 ; }
Signature · 1 line
2.9.3
Alex Deucher
AppliedQuoted 7 lines · Colin King
From: Colin Ian King <[email protected]>
The check for an out of bound index into array
interrupt_status_offsetsis off-by-one. Fix this and also don't compared to a hard coded array size but useadev->mode_info.num_hpdinstead.Signed-off-by Colin Ian King <[email protected]>
Applied! thanks,
Alex
Quoted 20 lines
--- drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/dce_v6_0.c +1
-2@@ -2782,7 +2782,7 @@ static int dce_v6_0_hpd_irq(struct amdgpu_device *adev,uint32_t disp_int, mask, int_control, tmp;unsigned hpd; -if (entry->src_data >6 ) { +if (entry->src_data >= adev->mode_info.num_hpd) {DRM_DEBUG ("Unhandled interrupt: %d %d\n" , entry->src_id, entry->src_data);return 0 ; } --2.9.3
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel