rcu: add missing prototype
PATCH 1/1 rcu: add missing prototype
make W=1 warns:kernel/rcu/tree.c:226:15: warning: no previous prototype for ‘rcu_rnp_online_cpus’ [-Wmissing-prototypes]
unsigned long rcu_rnp_online_cpus(struct rcu_node *rnp)
^~~~~~~~~~~~~~~~~~~
---
I couldn't figure out how this list is ordered, I'm happy to move this line if you want :)
--- kernel/rcu/tree.h | 1 + 1 file changed, 1 insertion(+)
kernel/rcu/tree.h +1 -0
@@ -668,6 +668,7 @@ static void rcu_sysidle_init_percpu_data(struct rcu_dynticks *rdtp);static bool rcu_nohz_full_cpu (struct rcu_state *rsp);static void rcu_dynticks_task_enter (void );static void rcu_dynticks_task_exit (void ); +static unsigned long rcu_rnp_online_cpus (struct rcu_node *rnp);#endif /* #ifndef RCU_TREE_NONCORE */
Signature · 2 lines
Cheers, Eric
Quoted 6 lines · Eric Engestrom
make W=1warns:kernel/rcu/tree.c:226:15: warning: no previous prototype for ‘rcu_rnp_online_cpus’ [-Wmissing-prototypes]
unsigned longrcu_rnp_online_cpus(struct rcu_node *rnp)^~~~~~~~~~~~~~~~~~~Signed-off-by Eric Engestrom <[email protected]>
You lost me on this one. It seems to be complaining about the initial definition.
Hmmm... Would making this function static __maybe_unused also resolve this?
Thanx, Paul
Quoted 25 lines
---
I couldn't figure out how this list is ordered, I'm happy to move this line if you want :)
--- kernel/rcu/tree.h | 1 + 1 file changed, 1 insertion(+)kernel/rcu/tree.h +1
-0@@ -668,6 +668,7 @@ static void rcu_sysidle_init_percpu_data(struct rcu_dynticks *rdtp);static bool rcu_nohz_full_cpu (struct rcu_state *rsp);static void rcu_dynticks_task_enter (void );static void rcu_dynticks_task_exit (void ); +static unsigned long rcu_rnp_online_cpus (struct rcu_node *rnp);#endif /* #ifndef RCU_TREE_NONCORE */ Signature · 2 lines
Cheers, Eric