Skip to contentSkip to conversation

nvmet: Make dsm number of ranges zero based

PATCH New Sagi Grimberg 2 participants 2 messages Sep 21, 2016 – Sep 22, 2016

Subsystems (2)
NVMe NVMe target
lore
Share & tools
lore

Sagi Grimberg

author maintainer
#0 lore raw

PATCH 1/1 nvmet: Make dsm number of ranges zero based

From: Alexander Solganik <[email protected]>

This caused the nvmet request data length to be
incorrect.

Signed-off-by Alexander Solganik <sashas at lightbitslabs.com>
Signed-off-by Sagi Grimberg <sagi at grimberg.me>
---
 drivers/nvme/target/io-cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/target/io-cmd.c +1 -1
index 4132b6b98182..4a96c2049b7b 100644
@@ -206,7 +206,7 @@ int nvmet_parse_io_cmd(struct nvmet_req *req)
 		return 0;
 	case nvme_cmd_dsm:
 		req->execute = nvmet_execute_dsm;
-		req->data_len = le32_to_cpu(cmd->dsm.nr) *
+		req->data_len = le32_to_cpu(cmd->dsm.nr + 1) *
 			sizeof(struct nvme_dsm_range);
 		return 0;
 	default:
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 nvmet: Make dsm number of ranges zero based

Looks fine, thanks Alex and Sagi.

Reviewed-by Christoph Hellwig <hch at lst.de>