Skip to contentSkip to conversation

mksh: add new package MirOS Korn Shell

PATCH Superseded Waldemar Brodkorb 2 participants 3 messages Sep 22, 2016 – Sep 23, 2016 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mksh: add new package MirOS Korn Shell

The MirOS Korn Shell is a quite complete posix shell implementation, is rather small and supports vi mode properly.

---
v1 -> v2:
- added hash file
- updated to latest release
- tested with shared and static builds
---
I am resending the patch from Kurt, not sure why he got no feedback yet. I can take over maintainership (DEVELOPERS entry), if Kurt won't do it. It is a great shell and if you ever try to debug functions in ash with set -x, you know why you want to switch to mksh.
It should properly cross-compile for every supported buildroot architecture with MMU. It is used for a long time in OpenADK as base system shell and it is pretty stable.

---
 package/Config.in      |  1 +
 package/mksh/Config.in | 22 ++++++++++++++++++++++
 package/mksh/mksh.hash |  4 ++++
 package/mksh/mksh.mk   | 31 +++++++++++++++++++++++++++++++
 system/Config.in       |  9 ++++++++-
 5 files changed, 66 insertions(+), 1 deletion(-)
 create mode 100644 package/mksh/Config.in
 create mode 100644 package/mksh/mksh.hash
 create mode 100644 package/mksh/mksh.mk
package/Config.in +1 -0
index 9ca6c15..287603b 100644
@@ -1654,6 +1654,7 @@ menu "Shell and utilities"
 comment "Shells"
 	source "package/bash/Config.in"
 	source "package/dash/Config.in"
+	source "package/mksh/Config.in"
 	source "package/zsh/Config.in"
 comment "Utilities"
 	source "package/at/Config.in"
package/mksh/Config.in new file +22 -0
new file mode 100644
index 0000000..9e2030a
@@ -0,0 +1,22 @@
+config BR2_PACKAGE_MKSH
+	bool "mksh"
+	depends on BR2_USE_MMU # fork()
+	help
+	  The MirBSD Korn Shell,
+
+	  mksh is a successor of pdksh but not affiliated with the pdksh
+	  developers or contributors. mksh is not affiliated with the
+	  AT&T Korn Shell, its past or present owners, other than that
+	  both attempt to implement the Korn Shell programming language.
+
+	  mksh targets users who desire a compact, fast, reliable,
+	  secure shell not cut off modern extensions; a shell with
+	  Unicode support; an actively developed, current, and portable
+	  product; one with developers that listen to their users? requests
+	  and implement them if they actually make sense.
+
+	  mksh aims to replace pdksh in all but very rare use cases
+	  (such as support for checking the Unix mbox) and in all operating
+	  environments (thus including patches from pdksh on e.g. Debian).
+
+	  http://mirbsd.de/mksh
package/mksh/mksh.hash new file +4 -0
new file mode 100644
index 0000000..d95001c
@@ -0,0 +1,4 @@
+# From http://www.mirbsd.org/mksh.htm#build
+md5	43fc3e32963cc1795a299bcec531d770	mksh-R53a.tgz
+# Calculated based on the hash above
+sha256	3bb2453c8cb65abbda24f9bdd8b8371e30a6e1c2f7a0d5474a3efae438639635	mksh-R53a.tgz
package/mksh/mksh.mk new file +31 -0
new file mode 100644
index 0000000..7ca58cd
@@ -0,0 +1,31 @@
+################################################################################
+#
+# mksh
+#
+################################################################################
+
+MKSH_VERSION = R53a
+MKSH_SOURCE = mksh-$(MKSH_VERSION).tgz
+MKSH_SITE = https://www.mirbsd.org/MirOS/dist/mir/mksh
+MKSH_LICENSE = MirOS, BSD-3c, ISC
+MKSH_LICENSE_FILES = COPYING
+
+define MKSH_CONFIGURE_CMDS
+	cd $(@D) && $(TARGET_MAKE_ENV) \
+		CPPFLAGS="-DMKSH_S_NOVI=0 $(TARGET_CPPFLAGS)" \
+		CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" \
+		LD="$(TARGET_LD)" LDFLAGS="$(TARGET_LDFLAGS)" LDLIBS="$(TARGET_LDLIBS)" \
+		TARGET_OS=Linux \
+		sh ./Build.sh -M
+endef
+
+define MKSH_BUILD_CMDS
+	cd $(@D) && $(TARGET_MAKE_ENV) \
+		sh ./Rebuild.sh
+endef
+
+define MKSH_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 0755 $(@D)/mksh $(TARGET_DIR)/bin/mksh
+endef
+
+$(eval $(generic-package))
system/Config.in +8 -1
index 77c665b..d3b2889 100644
@@ -276,13 +276,19 @@ config BR2_SYSTEM_BIN_SH_DASH
 	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	select BR2_PACKAGE_DASH
 
+config BR2_SYSTEM_BIN_SH_MKSH
+	bool "mksh"
+	depends on BR2_USE_MMU # mksh
+	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
+	select BR2_PACKAGE_MKSH
+
 config BR2_SYSTEM_BIN_SH_ZSH
 	bool "zsh"
 	depends on BR2_USE_MMU # zsh
 	depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 	select BR2_PACKAGE_ZSH
 
-comment "bash, dash, zsh need BR2_PACKAGE_BUSYBOX_SHOW_OTHERS"
+comment "bash, dash, mksh, zsh need BR2_PACKAGE_BUSYBOX_SHOW_OTHERS"
 	depends on !BR2_PACKAGE_BUSYBOX_SHOW_OTHERS && BR2_PACKAGE_BUSYBOX
 
 config BR2_SYSTEM_BIN_SH_NONE
@@ -295,6 +301,7 @@ config BR2_SYSTEM_BIN_SH
 	default "busybox" if BR2_SYSTEM_BIN_SH_BUSYBOX
 	default "bash"    if BR2_SYSTEM_BIN_SH_BASH
 	default "dash"    if BR2_SYSTEM_BIN_SH_DASH
+	default "mksh"    if BR2_SYSTEM_BIN_SH_MKSH
 	default "zsh"     if BR2_SYSTEM_BIN_SH_ZSH
 
 menuconfig BR2_TARGET_GENERIC_GETTY
Signature · 1 line
2.1.4
#1 lore raw

PATCH v2 1/1 mksh: add new package MirOS Korn Shell

Hello,

Quoted 5 lines · Waldemar Brodkorb

The MirOS Korn Shell is a quite complete posix shell implementation, is rather small and supports vi mode properly.

I was about to apply this, but there's an issue with the licensing. So while I'm at it, I'm also giving other comments.

The title should be just:

mksh: new package

Quoted 13 lines
package/mksh/Config.in new file +10 -0
@@ -0,0 +1,22 @@
+config BR2_PACKAGE_MKSH
+	bool "mksh"
+	depends on BR2_USE_MMU # fork()
+	help
+	  The MirBSD Korn Shell,
+
+	  mksh is a successor of pdksh but not affiliated with the pdksh
+	  developers or contributors. mksh is not affiliated with the
+	  AT&T Korn Shell, its past or present owners, other than that
+	  both attempt to implement the Korn Shell programming language.

package/mksh/Config.in line 20

Quoted 10 lines
package/mksh/Config.in new file +10 -0
+
+	  mksh targets users who desire a compact, fast, reliable,
+	  secure shell not cut off modern extensions; a shell with
+	  Unicode support; an actively developed, current, and portable
+	  product; one with developers that listen to their users? requests
+	  and implement them if they actually make sense.
+
+	  mksh aims to replace pdksh in all but very rare use cases
+	  (such as support for checking the Unix mbox) and in all operating
+	  environments (thus including patches from pdksh on e.g. Debian).

Those lines are too long. Please wrap the help text to a length of 72 characters per line.

package/mksh/Config.in

Quoted 5 lines
package/mksh/Config.in new file +5 -0
+MKSH_VERSION = R53a
+MKSH_SOURCE = mksh-$(MKSH_VERSION).tgz
+MKSH_SITE = https://www.mirbsd.org/MirOS/dist/mir/mksh
+MKSH_LICENSE = MirOS, BSD-3c, ISC
+MKSH_LICENSE_FILES = COPYING

There is no COPYING file in the source code, so this will cause build failure.

Where is the information about the licensing coming from? What is this "MirOS" license?

The man page references https://www.mirbsd.org/TaC-mksh.txt as containing the legalese. Maybe this needs to also be downloaded, and used as a license file. At least they clarify what this "MirOS" license is.

package/mksh/Config.in

Quoted 5 lines
package/mksh/Config.in new file +5 -0
+define MKSH_CONFIGURE_CMDS
+	cd $(@D) && $(TARGET_MAKE_ENV) \
+		CPPFLAGS="-DMKSH_S_NOVI=0 $(TARGET_CPPFLAGS)" \
+		CC="$(TARGET_CC)" CFLAGS="$(TARGET_CFLAGS)" \
+		LD="$(TARGET_LD)" LDFLAGS="$(TARGET_LDFLAGS)" LDLIBS="$(TARGET_LDLIBS)" \

TARGET_LDLIBS does not exist. Have you considered using $(TARGET_CONFIGURE_OPTS) here?

	$(TARGET_MAKE_ENV) $(TARGET_CONFIGURE_OPTS) \
		CPPFLAGS="-DMKSH_S_NOVI=0 $(TARGET_CPPFLAGS)" \
		TARGET_OS=Linux \
		sh ./Build.sh -M

system/Config.in

Quoted 2 lines
system/Config.in +0 -0
index 77c665b..d3b2889 100644

The changes in this file could possibly go to a separate patch.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

PATCH v2 1/1 mksh: add new package MirOS Korn Shell

Hi Thorsten,
Thorsten Glaser wrote,

Quoted 6 lines

Waldemar Brodkorb dixit:

Quoted 1 line

The MirOS Korn Shell is a quite complete posix shell implementation,

POSIX compatible, not 100% but closer than most others?

Quoted 8 lines
Quoted 1 line

+MKSH_LICENSE = MirOS, BSD-3c, ISC

Only MirOS and ISC unless you add printf.c (which I don?t see in the patch).

Quoted 1 line

+MKSH_LICENSE_FILES = COPYING

Huh?

Okay, seems to be a problem.
Is the License file for mksh (MirOS License) available in a file in the source tree?
Buildroot has a function to collect all license files of a created root filesystem.

Quoted 28 lines

package/mksh/mksh.mk line 15

Quoted 3 lines
package/mksh/mksh.mk new file +3 -0
+define MKSH_CONFIGURE_CMDS
+	cd $(@D) && $(TARGET_MAKE_ENV) \
+		CPPFLAGS="-DMKSH_S_NOVI=0 $(TARGET_CPPFLAGS)" \

You only need -DMKSH_S_NOVI=0 if you also add -DMKSH_SMALL and want the vi editing mode.

package/mksh/mksh.mk line 25

Quoted 7 lines
package/mksh/mksh.mk new file +7 -0
+		sh ./Build.sh -M
+endef
+
+define MKSH_BUILD_CMDS
+	cd $(@D) && $(TARGET_MAKE_ENV) \
+		sh ./Rebuild.sh
+endef

Arguable, but just call Build.sh without -M to configure *and* build it in *one* step.

package/mksh/mksh.mk line 29

Quoted 3 lines
package/mksh/mksh.mk new file +3 -0
+define MKSH_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 0755 $(@D)/mksh $(TARGET_DIR)/bin/mksh
+endef

Please also ship dot.mkshrc or some other sort of ~/.mkshrc so that users get a slightly more comfortable/usable environment, if you can afford it, byte-wise (it?s 15K), or at least make it configurable. (Also patch it, if needed, e.g. for an ls(1) without the -o option.)

Quoted 2 lines

Thanks,
//mirabilos (mksh upstream)

thx,
Waldemar