drivers: iio: max1027: Fix sparse warning: "dubious: x | !y"

PATCH Applied Sandhya Bankar 2 participants 2 messages Sep 23, 2016 – Sep 24, 2016 IIO

lore

Share & tools

lore

Sandhya Bankar

author

2016-09-23 20:04 UTC #0 lore raw

PATCH v2 1/1 drivers: iio: max1027: Fix sparse warning: "dubious: x | !y"

Fixing below warning:
drivers/iio/adc/max1027.c:241:34: warning: dubious: x | !y .

Signed-off-by Sandhya Bankar <[email protected]>

---
Changes in v2:
* Using MAX1027_TEMP instead of number.

 drivers/iio/adc/max1027.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

drivers/iio/adc/max1027.c +3 -1

index 712fbd2..d601818 100644
@@ -238,7 +238,9 @@ static int max1027_read_single_value(struct iio_dev *indio_dev,
 
 	/* Configure conversion register with the requested chan */
 	st->reg = MAX1027_CONV_REG | MAX1027_CHAN(chan->channel) |
-		  MAX1027_NOSCAN | !!(chan->type == IIO_TEMP);
+		  MAX1027_NOSCAN;
+	if (chan->type == IIO_TEMP)
+		st->reg |= MAX1027_TEMP;
 	ret = spi_write(st->spi, &st->reg, 1);
 	if (ret < 0) {
 		dev_err(&indio_dev->dev,

Signature · 1 line

1.8.3.1

Jonathan Cameron

maintainer Applied

2016-09-24 16:12 UTC #1 lore raw

Quoted 4 lines · Sandhya Bankar

Fixing below warning:
drivers/iio/adc/max1027.c:241:34: warning: dubious: x | !y .
Signed-off-by Sandhya Bankar <[email protected]>

Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.

Thanks,

Jonathan

Quoted 23 lines

---
Changes in v2:
* Using MAX1027_TEMP instead of number.

 drivers/iio/adc/max1027.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

drivers/iio/adc/max1027.c +3 -1

index 712fbd2..d601818 100644
@@ -238,7 +238,9 @@ static int max1027_read_single_value(struct iio_dev *indio_dev,
 
 	/* Configure conversion register with the requested chan */
 	st->reg = MAX1027_CONV_REG | MAX1027_CHAN(chan->channel) |
-		  MAX1027_NOSCAN | !!(chan->type == IIO_TEMP);
+		  MAX1027_NOSCAN;
+	if (chan->type == IIO_TEMP)
+		st->reg |= MAX1027_TEMP;
 	ret = spi_write(st->spi, &st->reg, 1);
 	if (ret < 0) {
 		dev_err(&indio_dev->dev,