gst1-imx: add menuconfig to select each plugin individually
PATCH v2 1/1 gst1-imx: add menuconfig to select each plugin individually
Also making it clearer as for what each plugin dependencies are.
---
Hi all,
Here is a v2 with the following changes:
- Add a comment stating that --enable-foo option doesn't exist
- Add dependencies inside the plugin ifdef statement when possible
- Kept linux/imx-gpu-viv/imx-codec outside since shared between several plugins
The Config.in ended up being the same since any select to a Freescale package creates a "recursive dependency".
Regards,
Gary
--- package/gstreamer1/gst1-imx/Config.in | 89 ++++++++++++++++++++++++++++----- package/gstreamer1/gst1-imx/gst1-imx.mk | 58 ++++++++++++++++++--- 2 files changed, 126 insertions(+), 21 deletions(-)
package/gstreamer1/gst1-imx/Config.in +76 -13
@@ -1,4 +1,8 @@ -config BR2_PACKAGE_GST1_IMX +comment "gst1-imx needs a toolchain w/ dynamic library" + depends on BR2_arm + depends on BR2_STATIC_LIBS + +menuconfig BR2_PACKAGE_GST1_IMX bool "gst1-imx" depends on BR2_arm # Only relevant for i.MX depends on !BR2_STATIC_LIBS
@@ -7,18 +11,77 @@ config BR2_PACKAGE_GST1_IMX This is a set of GStreamer 1.0 plugins for plugins for Freescale's i.MX platforms, which make use of the i.MX multimedia capabilities. - This software supports only the i.MX6 SoC family. + https://github.com/Freescale/gstreamer-imx - The IPU and PXP plugins are built when an imx-specific kernel is - enabled. - The V4L2 plugin is built when BR2_PACKAGE_GST1_PLUGINS_BAD is enabled. - The VPU plugin is built when BR2_PACKAGE_LIBIMXVPUAPI is enabled. - The EGL plugin is built when BR2_PACKAGE_IMX_GPU_VIV is enabled. - The G2D plugin is built when BR2_PACKAGE_IMX_GPU_VIV_G2D is enabled. - The MP3 plugin is built when BR2_PACKAGE_IMX_CODEC is enabled. +if BR2_PACKAGE_GST1_IMX - https://github.com/Freescale/gstreamer-imx +config BR2_PACKAGE_GST1_IMX_EGLVISINK + bool "imxeglvivsink" + depends on BR2_PACKAGE_IMX_GPU_VIV + help + Elements leveraging the 3D GPU -comment "gst1-imx needs a toolchain w/ dynamic library" - depends on BR2_arm - depends on BR2_STATIC_LIBS +comment "imxeglvivsink needs the Vivante 3D libraries" + depends on !BR2_PACKAGE_IMX_GPU_VIV + +config BR2_PACKAGE_GST1_IMX_G2D + bool "imxg2d" + depends on BR2_PACKAGE_IMX_GPU_VIV_G2D + help + Elements leveraging the 2D GPU + +comment "imxg2d needs the Vivante 2D libraries" + depends on !BR2_PACKAGE_IMX_GPU_VIV_G2D + +config BR2_PACKAGE_GST1_IMX_IPU + bool "imxipu" + depends on BR2_LINUX_KERNEL + help + Elements leveraging the IPU + +comment "imxipu needs an imx-specific Linux kernel to be built" + depends on !BR2_LINUX_KERNEL + +config BR2_PACKAGE_GST1_IMX_MP3ENCODER + bool "mp3encoder" + depends on BR2_PACKAGE_IMX_CODEC + help + Elements for MP3 encoding + +comment "mp3encoder needs the i.MX codec binaries" + depends on !BR2_PACKAGE_IMX_CODEC + +config BR2_PACKAGE_GST1_IMX_PXP + bool "imxpxp" + depends on BR2_LINUX_KERNEL + help + Elements leveraging the PXP + +comment "imxpxp needs an imx-specific Linux kernel to be built" + depends on !BR2_LINUX_KERNEL + +config BR2_PACKAGE_GST1_IMX_UNIAUDIODEC + bool "uniaudiodec" + depends on BR2_PACKAGE_IMX_CODEC + help + Elements for audio decoding + +comment "uniaudiodec needs the i.MX codec binaries" + depends on !BR2_PACKAGE_IMX_CODEC + +config BR2_PACKAGE_GST1_IMX_VPU + bool "imxvpu" + depends on BR2_PACKAGE_LIBIMXVPUAPI + help + Elements leveraging the VPU + +comment "imxvpu needs the VPU imxvpuapi library" + depends on !BR2_PACKAGE_LIBIMXVPUAPI + +config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC + bool "imxv4l2videosrc" + select BR2_PACKAGE_GST1_PLUGINS_BAD + help + Elements for V4L2 capture + +endif
package/gstreamer1/gst1-imx/gst1-imx.mk +50 -8
76 lines not on this page · raw message
Signature · 1 line
2.9.3
Thomas Petazzoni
AppliedPATCH v2 1/1 gst1-imx: add menuconfig to select each plugin individually
Hello,
Quoted 5 lines · Gary Bisson
Also making it clearer as for what each plugin dependencies are.
Signed-off-by Gary Bisson <[email protected]>---
Hi all,
Applied to master, thanks. I've just inverted some of the conditions to avoid the empty ifeq ... else statements.
Please check that the result is OK. Thanks! :-)
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH v2 1/1 gst1-imx: add menuconfig to select each plugin individually
Hi Thomas,
Quoted 11 lines · Thomas Petazzoni
Hello,
Quoted 5 lines · Gary Bisson
Also making it clearer as for what each plugin dependencies are.
Signed-off-by Gary Bisson <[email protected]>---
Hi all,Applied to master, thanks. I've just inverted some of the conditions to avoid the empty ifeq ... else statements.
Thanks!
Quoted 1 line
Please check that the result is OK. Thanks! :-)
I did test the different options and everything looks good.
Regards,
Gary