Skip to contentSkip to conversation

MAINTAINERS: Add some more headers to the IDE section

PATCH Applied Thomas Huth 3 participants 6 messages Sep 23, 2016 – Sep 26, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 MAINTAINERS: Add some more headers to the IDE section

The folder include/hw/ide/ belongs to the IDE section.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index d8a0cfc..acf6d6c 100644
@@ -791,6 +791,7 @@ M: John Snow <[email protected]>
 L: [email protected]
 S: Supported
 F: include/hw/ide.h
+F: include/hw/ide/
 F: hw/ide/
 F: hw/block/block.c
 F: hw/block/cdrom.c
Signature · 1 line
1.8.3.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · Thomas Huth

The folder include/hw/ide/ belongs to the IDE section.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index d8a0cfc..acf6d6c 100644

MAINTAINERS M: John Snow <[email protected]> · line 797

Quoted 7 lines
MAINTAINERS +1 -0
@@ -791,6 +791,7 @@ M: John Snow <[email protected]>
 L: [email protected]
 S: Supported
 F: include/hw/ide.h
+F: include/hw/ide/
 F: hw/ide/
 F: hw/block/block.c
 F: hw/block/cdrom.c

Ah, yeah. These got missed when they were moved over. Thanks.

#2 lore raw

Am 23.09.2016 um 18:42 hat John Snow geschrieben:

Quoted 24 lines · Thomas Huth
Quoted 12 lines

The folder include/hw/ide/ belongs to the IDE section.

---
MAINTAINERS | 1 +

1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index d8a0cfc..acf6d6c 100644
@@ -791,6 +791,7 @@ M: John Snow <[email protected]>
Quoted 8 lines

L: [email protected]
S: Supported
F: include/hw/ide.h
+F: include/hw/ide/
F: hw/ide/
F: hw/block/block.c
F: hw/block/cdrom.c

Ah, yeah. These got missed when they were moved over. Thanks.

Quoted 1 line

Who is supposed to merge this if you only give an R-b?

And didn't we want to move the internal header files back to hw/ instead of the global include directory?

Kevin

#3 lore raw
Quoted 25 lines · Kevin Wolf

Am 23.09.2016 um 18:42 hat John Snow geschrieben:

Quoted 24 lines · Thomas Huth
Quoted 12 lines

The folder include/hw/ide/ belongs to the IDE section.

---
MAINTAINERS | 1 +

1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index d8a0cfc..acf6d6c 100644
@@ -791,6 +791,7 @@ M: John Snow <[email protected]>
Quoted 8 lines

L: [email protected]
S: Supported
F: include/hw/ide.h
+F: include/hw/ide/
F: hw/ide/
F: hw/block/block.c
F: hw/block/cdrom.c

Ah, yeah. These got missed when they were moved over. Thanks.

Quoted 3 lines
Quoted 1 line

Who is supposed to merge this if you only give an R-b?

I've CC:ed this patch to qemu-trivial, so I hope it will get picked up there if John does not want to apply this directly.

Thomas

#4 lore raw
Quoted 26 lines · Thomas Huth
Quoted 25 lines · Kevin Wolf

Am 23.09.2016 um 18:42 hat John Snow geschrieben:

Quoted 24 lines · Thomas Huth
Quoted 12 lines

The folder include/hw/ide/ belongs to the IDE section.

---
MAINTAINERS | 1 +

1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index d8a0cfc..acf6d6c 100644
@@ -791,6 +791,7 @@ M: John Snow <[email protected]>
Quoted 8 lines

L: [email protected]
S: Supported
F: include/hw/ide.h
+F: include/hw/ide/
F: hw/ide/
F: hw/block/block.c
F: hw/block/cdrom.c

Ah, yeah. These got missed when they were moved over. Thanks.

Quoted 10 lines
Quoted 3 lines
Quoted 1 line

Who is supposed to merge this if you only give an R-b?

I've CC:ed this patch to qemu-trivial, so I hope it will get picked up there if John does not want to apply this directly.

Thomas

Sorry, I didn't realize I would be expected to merge this myself.

And I do want to move the files back, but I have to disentangle them and haven't done so yet. In the meantime, they should be recorded in MAINTAINERS.

I'll stage this page in my IDE branch, thanks

--js

Applied
#5 lore raw
In reply to Thomas Huth
Quoted 26 lines · Thomas Huth
Quoted 25 lines · Kevin Wolf

Am 23.09.2016 um 18:42 hat John Snow geschrieben:

Quoted 24 lines · Thomas Huth
Quoted 12 lines

The folder include/hw/ide/ belongs to the IDE section.

---
MAINTAINERS | 1 +

1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index d8a0cfc..acf6d6c 100644
@@ -791,6 +791,7 @@ M: John Snow <[email protected]>
Quoted 8 lines

L: [email protected]
S: Supported
F: include/hw/ide.h
+F: include/hw/ide/
F: hw/ide/
F: hw/block/block.c
F: hw/block/cdrom.c

Ah, yeah. These got missed when they were moved over. Thanks.

Quoted 10 lines
Quoted 3 lines
Quoted 1 line

Who is supposed to merge this if you only give an R-b?

I've CC:ed this patch to qemu-trivial, so I hope it will get picked up there if John does not want to apply this directly.

Thomas

Thanks, applied to my IDE tree:

https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git

--js